From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1A2DCA5FEF for ; Sun, 4 Oct 2026 15:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ijVzIve29PHeaUaMD0UnyB/2N/58uvZFm5f+2hPLu0=; b=bnfRCI/XqZ9PQKFNakuvMV2w5S W6BpgYu2vxURbbtIq0fv9RBdhR9IBhw/pSkcmB7lkpCwi0LBzb1mH78YgXxRtf18uOqg98BhU6U+W LlQFPxdyT59KOHtb9qYqQMsgPmE2yqUtxtJASKhkmeLILFHKJrpfUQtkaATEOtZbiPon8M713BPry woQx9he456DWXNAT9lxXRnaznpgS3fnwVLt4H/11w3JoDdYINpF9gKDqa7liaW1r+JMp67K7npBDO HK3rcJ5XroFU5zG1CL9HloCFj/inG+37j+4I5e3McYtN11XUfTxWHlk3OfVJ1ip2ddbtP5Q08bzAN CCVxdZSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xDO9q-0000000EzUR-36Xd; Sun, 04 Oct 2026 15:29:46 +0000 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xDO9m-0000000EzSo-20dd for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2026 15:29:46 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-4a003bd18e5so5705275e9.0 for ; Sun, 04 Oct 2026 08:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1791127781; x=1791732581; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9ijVzIve29PHeaUaMD0UnyB/2N/58uvZFm5f+2hPLu0=; b=jq6IcRNlczbKj4idOg1ibCBIss5o/eWZmbz/1nP04sI4S36/dElHTezNmbyQzFPTDF eQDLZhoiHdY+GlpAl5+20IBgpejhQizPpUUQmFqBl4Rjb4pLBfI6p7gMQ2M9FJ5vX74T OKHScIVfVdqL0DuEA/xMoA0vkorQ+t539vYeLDtbID/7j2F+6ChQBVLodAh5qPffXWaB Dgon3rLO8c28rtmG1K0ONhbJ8IRRVM+G8mpSQtsjChqBWQb2L7M8Umvgjbwlzvbz47Tg sjvCMPjVTsEF1jTAIMB8MQQirvDIwDVGQSpazauzmZs6RHPdGGKhQPqJHPswy+dU8kbm qeLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791127781; x=1791732581; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=9ijVzIve29PHeaUaMD0UnyB/2N/58uvZFm5f+2hPLu0=; b=I0jiJeMzqWkUoclFt1Z69yLFDvbp/Pgds6Xl8CdO/RHrLMxFPV57QqGLsrbevpsGG+ hhLPIFv0cizGB1ccO5Iff8pFWkIZ/CgTSYUJtu46j7sPht6Je5FxNCwvYUJi9S4M1KaA Sa/Rg9CAqqdp80AYk0tpx+fiXo6bEPwIyoWBcn+jQ5eOXv8dC+eTz60Yuwzmif4yrOkF yc8A7gXKo2VG0c2zv50SK/Yq0yF7IaVU+KUHuGJeySCzkoDIdaQIZnlfiS2OdWhyDZX6 py/5GSOjE5k4nNz2PMZn7MftO7/nF4Ev5FPZigLdYo4jG8VTwibTNkK9h7JZ+P/jrPNQ yzbA== X-Forwarded-Encrypted: i=1; AKwUvByDMTYKMMmBlwlynO+99rvTkGwEgUy2y9waoGY89fxqCIEbveresNPazwUVEqYrb23p2LhAFYHR0qfEtPXaSKwR@lists.infradead.org X-Gm-Message-State: AFuF++l/ziYVtxrJSe6A+6J12AYqHf7uyHOduMj+Sszfqi6dhEwdutAl c7xzcl24rvPmldpJB6P7CWTD3BiGzGlXfsR/R9g+p9ixKDNNZPvKMmCoBhX0116bafY= X-Gm-Gg: AYBFou1DmvoaSEA8sNsoulsBQ0w8wLIOsVtLbiIYXwN0+Za+uJTG3kHDGcfwpI8jNMX /2qo33XwAPuW6WD3wNZl3GP7xgkIzJhtuIh3uzGSm4vDMtoPmJaUZefxMAKP2/iC6Or5eCoJGZc HI0gPI+c91jnRZ/WX0zDp/PiBoi3tpLK/BKuD48ceZcmimVHKS9NV4cWvL6YuRu2+REZ6qDhst9 KE1ucSJChSaD2dMyfSvZJyfhsz2NNhug1xeaJqKjHwZZkUw0S9afh8d4P6BXc0l4SabYE266trf YGyokmqtHa7JAgZ+ZMroYuc9159XNTsMk8NtGGVmn4HMUY/ViogV6KG/YPDdE3o+op3VdFkRAKU lvLICeqP/0NORgyEedIV+HM1b1l8V5Jafc7zN53YnknASxHUMa3tyVwxewxyS2y/KxaR1vkgf8g SZjuitI0JWNBCOkeP3b/ylwG+xVecCTTas0XDx00cbR8AmnKsnb9BekR7Ylii1Qa/xuAY2RSE6s X/cdo+d X-Received: by 2002:a05:600c:8b22:b0:4a1:6811:8d with SMTP id 5b1f17b1804b1-4a1681100f1mr75606585e9.11.1791127780679; Sun, 04 Oct 2026 08:29:40 -0700 (PDT) Received: from [172.20.10.3] ([37.169.53.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a0280d1e38sm220447725e9.13.2026.10.04.08.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2026 08:29:39 -0700 (PDT) Message-ID: Date: Sun, 4 Oct 2026 17:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [RFC PATCH 6/6] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port To: Lucas Tanure , xianwei.zhao@amlogic.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20261004144046.391444-1-tanure@linux.com> <20261004144046.391444-7-tanure@linux.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20261004144046.391444-7-tanure@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261004_082944_919610_84CD4297 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/4/26 16:40, Lucas Tanure wrote: > The board carries a Realtek RTL8211F gigabit PHY on the external > management bus, connected to the MAC over RGMII. > > Enable the controller, hand it the ethernet pins and point it at the > PHY. The clock delays RGMII needs are supplied by the MAC rather than > the PHY: 2ns on transmit and 2000ps on receive, the values the vendor > kernel programs. > > The PHY interrupt output is wired to GPIOH_6, so describe it and let > link changes be reported instead of polled. The PHY reset pin is driven > by an RC network on the board, not by the SoC, so there is no reset line > to describe. > > Tested at 930Mbit/s sustained receive over a minute, with no MAC error > counters moving in either direction. > > Assisted-by: LLM > Signed-off-by: Lucas Tanure > --- > .../amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > index 0fa83362b417..5d0365ddde72 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts > @@ -14,6 +14,7 @@ / { > compatible = "khadas,vim4", "amlogic,a311d2", "amlogic,t7"; > > aliases { > + ethernet0 = ðmac; > serial0 = &uart_a; > mmc0 = &sd_emmc_c; > mmc1 = &sd_emmc_b; > @@ -256,6 +257,33 @@ xtal: xtal-clk { > }; > }; > > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_pins>, <ð_rgmii_pins>; > + pinctrl-names = "default"; > + > + /* > + * The RGMII clock delays are added by the MAC, so the PHY is > + * asked for the mode that adds none. > + */ > + phy-mode = "rgmii"; > + phy-handle = <&external_phy>; > + amlogic,tx-delay-ns = <2>; > + rx-internal-delay-ps = <2000>; > +}; > + > +&ext_mdio { > + external_phy: ethernet-phy@0 { > + /* Realtek RTL8211FD-CG */ > + reg = <0>; > + max-speed = <1000>; > + > + interrupt-parent = <&gpio_intc>; > + /* RGMII_INT on GPIOH_6 */ > + interrupts = <154 IRQ_TYPE_LEVEL_LOW>; > + }; > +}; > + > &i2c_m_ao_a { > status = "okay"; > pinctrl-0 = <&i2c0_ao_d_pins>; Reviewed-by: Neil Armstrong Thanks, Neil