From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 889DCC4167B for ; Thu, 22 Dec 2022 14:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7h7H/ExgV1ge7kukpkG+Y9ggQgUVV0VkjMxoypJItXA=; b=arBuEpNMqnervk MnQ1vKk72wv3WrErmmEshIwXa3N4itXUtzVieDjSJROyeiJpc+ZrYXuGUMComdjjrjr3TE93oI6dX 4b5KBuZp04nG9OGZSeapSNTsARXgmpFT4EM9214vPXsnuz4cnCR3PQXFKKpqZXibdMxmvSLIHuwib 5YqgG5HCRUlKsVPi/VDJxbCMnYCsWFcO+RVpWKgLKIEEwthAYnDIh+Zm/SfaYp0NRIBFQG7sv1uPr 3kvZYwgULst7fCbVGzz8V5WZt4zlx+PwiF9rVeJ+oAtBADTtCquXusprKglEQm2CqMjLdwcrlLk+O uFZfinpz/1DRv4vBcqqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8MGn-00CnRn-9a; Thu, 22 Dec 2022 14:10:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8M3C-00Cepc-Vn for linux-arm-kernel@lists.infradead.org; Thu, 22 Dec 2022 13:56:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 948CFB81D61; Thu, 22 Dec 2022 13:55:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1619C433D2; Thu, 22 Dec 2022 13:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671717355; bh=tc1btOSbBaMZEMUX8Y0A0tpBlXbf7iZKeoWMZ5GMRBY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h/xcKtKwDWcBW1YfeRk2m2xy8oi1Ssc4a9WJ+kG01SsNnJZwCP6fAHEX6VoKdvaCg /y3sfpROcHfrC4Z38FRHBCkKkTxUOfOGOPb03bfR/oQQu/f5kztn6ZZDnGenib5vc7 rU9IzQTAC+Em18Dx7RK429CbmeE+SbyRnkeAvPnZNvmJzY8fGsN/KHl09vh4X3EdhD 90vv/XEO1v/G4S8GIepOW/fteqE8ksRDDaIosyrEDbFtCd5MZjTj/8uHwHaowSV5Qw PkgCQyfF2BptVktsHGQRlinrz54K/SIrQx+JT1F43sZ9tJJD1m8D2tFBv8sY0QZjhs Mq4g+Whd2wQRA== Message-ID: Date: Thu, 22 Dec 2022 14:55:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH 2/7] dt-bindings: bus: add STM32 System Bus Content-Language: en-US To: Gatien CHEVALLIER , alexandre.torgue@foss.st.com, robh+dt@kernel.org, Oleksii_Moisieiev@epam.com, linus.walleij@linaro.org, gregkh@linuxfoundation.org Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loic.pallardy@st.com, devicetree@vger.kernel.org, mark.rutland@arm.com, arnd@arndb.de References: <20221221173055.11719-1-gatien.chevallier@foss.st.com> <20221221173055.11719-3-gatien.chevallier@foss.st.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_055559_382612_C2D42B2E X-CRM114-Status: GOOD ( 32.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/12/2022 14:39, Gatien CHEVALLIER wrote: > Hello, > > On 12/22/22 11:24, Krzysztof Kozlowski wrote: >> On 21/12/2022 18:30, Gatien Chevallier wrote: >>> Document STM32 System Bus. This bus is intended to control firewall >>> access for the peripherals connected to it. >>> >>> Signed-off-by: Loic PALLARDY >>> Signed-off-by: Gatien Chevallier >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel > As it is based on Oleksii's patchset and older threads: > [1]: > https://lore.kernel.org/all/20190318100605.29120-1-benjamin.gaignard@st.com/ > [2]: > https://lore.kernel.org/all/20200701132523.32533-1-benjamin.gaignard@st.com/ > > I wanted to include people that have already been included or > participated in these. > > I'm sorry I did miss/added some (extra) people. I will double-check for > next patchset version. Include people pointed by maintainers, they are not "extra". They are basic/required. It's worth to include additionally people from original feature-domain work, but as extra, not replacing get_maintainers! > >> >>> --- >>> .../devicetree/bindings/bus/st,sys-bus.yaml | 88 +++++++++++++++++++ >>> 1 file changed, 88 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/bus/st,sys-bus.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/bus/st,sys-bus.yaml b/Documentation/devicetree/bindings/bus/st,sys-bus.yaml >>> new file mode 100644 >>> index 000000000000..9c0e86612695 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/bus/st,sys-bus.yaml >>> @@ -0,0 +1,88 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/bus/stm32,sys-bus.yaml >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: STM32 System Bus >> >> Only one space. >> > > Ack. I already pushed a V2, that is now outdated with your review, where > this error is fixed. > >>> + >>> +description: | >>> + The STM32 System Bus is an internal bus to which some internal peripherals >>> + are connected. STM32 System Bus integrates a firewall controlling access to each >>> + device. This bus prevents non-accessible devices to be probed. >>> + >>> + To see which peripherals are securable, please check the SoC reference manual. >>> + >>> +maintainers: >>> + - Gatien Chevallier >>> + >>> +allOf: >>> + - $ref: /schemas/feature-controllers/feature-domain-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - st,stm32mp13-sys-bus >>> + - st,stm32mp15-sys-bus >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 1 >>> + >>> + '#feature-domain-cells': >> >> Use consistent quotes, either ' or " > > Ack, will change in V3. > >> >>> + minItems: 1 >> >> No. Cells must be const. This does not match cells at all... >> > > Ack, will change to const in V3. What do imply by saying it does not > match? cells do not have items, it's not an array but a number. > Note that I've changed it to "minimum" in V2. No, it must be const. > >>> + >>> + ranges: true >>> + >>> + feature-domain-controller: true >>> + >>> +patternProperties: >>> + "^.*@[0-9a-f]+$": >>> + description: Devices attached to system bus >>> + type: object >>> + properties: >>> + feature-domains: >>> + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains >> >> maxItems > > I don't think setting a max here is relevant as there can be numerous > feature-domains referenced. Then pick some high, reasonable number with minItems: 1. > > Maybe a min? > >> >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - "#address-cells" >>> + - "#size-cells" >>> + - feature-domain-controller >>> + - '#feature-domain-cells' >>> + - ranges >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + // In this example, >>> + // - the foo1 device refers to etzpc as his domain controller. >>> + // - same goes for foo2. >>> + // Access rights are verified before creating devices. >>> + >>> + etzpc: etzpc@5c007000 { >> >> Node names should be generic. >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> > > Ack, will change to "etzpc: bus@5c007000" in V3 > >>> + compatible = "st,stm32mp15-sys-bus"; >>> + reg = <0x5c007000 0x400>; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + feature-domain-controller; >>> + #feature-domain-cells = <1>; >>> + >>> + foo1: foo@1000000 { >> >> Node names should be generic. >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > Here, if I use real peripherals, I have an issue with the dependency to > YAML files. The feature-domains property is not defined in their > bindings. Therefore, the dt_binding_check fails on peripherals whose > YAML declare "additionalProperties: false" because the link to the > feature domain controller bindings does not exist. Then your patchset is not complete and not correct, right? The binding for the real example which you have in real world, should also allow it in such Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel