From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15B25C2BD09 for ; Fri, 12 Jul 2024 08:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SuWnWUF/RUb6fLSqSiXpDtfqG5ZTYPv5K0lNNEfLYCo=; b=OgrZkMgnUjYa3Tc3xKEdJvhi6A 4XPatAdibkspD3666ZF2sygDi+l9qYTL7Y5Hok492edTac7czJn1i7RN22sTjWJQJSOH4N+htSb8s Eu0j1dWoLSSzffZKQgoK/xAkjKhBVBuRTKXs8tFzwuRtDV8jJqLuEK9ajmC0XQfxmTx1ZllGQyqIm r2OjW9SMO3p2OPVshHsMP3OOCg+p6LbjKkbMSoJbDP7Ad6qeX7NKXF+2rb6+o+Xweecc2p1FQjjT+ UQY62O5ayGyjh+ikfGANGqqvnhtev3RD5Z7zrzB7Ss++5GN5xCgx4WY0eFlVc9WBoBw4mPXUwBfYd dMQJZ4Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSBpo-0000000GwaT-3wkM; Fri, 12 Jul 2024 08:40:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSBpX-0000000GwXM-1beF for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2024 08:40:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7CB931007; Fri, 12 Jul 2024 01:41:03 -0700 (PDT) Received: from [10.162.16.42] (a077893.blr.arm.com [10.162.16.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8634B3F762; Fri, 12 Jul 2024 01:40:35 -0700 (PDT) Message-ID: Date: Fri, 12 Jul 2024 14:10:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/12] KVM: arm64: nv: Honor absence of FEAT_PAN2 To: Marc Zyngier , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Cc: James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Joey Gouly References: <20240625133508.259829-1-maz@kernel.org> <20240625133508.259829-5-maz@kernel.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240625133508.259829-5-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_014039_661055_A8C18A5F X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/25/24 19:05, Marc Zyngier wrote: > If our guest has been configured without PAN2, make sure that > AT S1E1{R,W}P will generate an UNDEF. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/sys_regs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 832c6733db307..06c39f191b5ec 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -4585,6 +4585,10 @@ void kvm_calculate_traps(struct kvm_vcpu *vcpu) > HFGITR_EL2_TLBIRVAAE1OS | > HFGITR_EL2_TLBIRVAE1OS); > > + if (!kvm_has_feat(kvm, ID_AA64MMFR1_EL1, PAN, PAN2)) > + kvm->arch.fgu[HFGITR_GROUP] |= (HFGITR_EL2_ATS1E1RP | > + HFGITR_EL2_ATS1E1WP); > + > if (!kvm_has_feat(kvm, ID_AA64MMFR3_EL1, S1PIE, IMP)) > kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nPIRE0_EL1 | > HFGxTR_EL2_nPIR_EL1); As you had explained earlier about FGT UNDEF implementation, the above code change makes sense. FWIW Reviewed-by: Anshuman Khandual