From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF92C74A4B for ; Thu, 11 Jul 2019 09:27:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1147D208E4 for ; Thu, 11 Jul 2019 09:27:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TrCEx2yW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="BwUFcHBn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1147D208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=08ZQxh2iWtgw4lRkOOPTtq8gwlBwynbSpnjSduf/1mw=; b=TrCEx2yWyD5FB+ DbPzEuxYJvCtDdizidvsE6uCCWDXHvFmP+74SBcpBzjcJK2cqivroVvHvwf20pCZLIsnvsVBKvNd/ JPsvPIcqk1Z+wuP7yD6Mq9z3JEYfxlUjMW1ASa6MKfojDKdJZTs7biZfwufiYScN32/ivrIqX03PW T+cnSDvqI/bUqK8cZG61NmkMQ0cKyAVdfk6DqrkXYWCT9bIem3/6/l8qItvxrk4JG+WiCeXxF1OSv GrIEARGSKP95n9Jv27+98Ztg++TdJLT37nsB7pliI0DKi3HO6WoqHpxsxKc7iEj/8m3jOv1ErAGJW hzXF0GTWCgzKRtISEh8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlVMm-0005iS-VU; Thu, 11 Jul 2019 09:27:52 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlVMi-0005hg-Cl for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2019 09:27:50 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6B9Qltj019115; Thu, 11 Jul 2019 11:27:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=ozuHaFSyD+aZJ4haNAizK22rnLxhHA6aUOrq7v4rYzM=; b=BwUFcHBnsNVm3nBNpAUuttYo/2pyWXJoO+rXajtM4GNAlGhVGMdHqALX7vzbQnDTZm5Q aFtg9FJCiobvdsNyuS4/Tr/a160Goosfo41RUowkcDnUBF2ZVSe/oWcUn4+zgRT3xPyS QHSn0h2dlB6RhitmkIdM9nizn91BYHGlYGcTP4AFV1VZ+GBu7PPiiM2f6Bjlqs8bOmGK fhQZGbqpP6OcMYoSPja1MduluPvVF/S+XvofNbfbK3I+49Z4X0OyHCkqNON7EapvLHCD 7OyZBcjV6Z/fL8+o62L1vLwyz3iSQo0M5GFQ12/vMmGjoivVQTuaZHmReke6Up4wkiXO 4A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2tmvx04bpn-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 11 Jul 2019 11:27:34 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4779442; Thu, 11 Jul 2019 09:27:31 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 00F1C26BB; Thu, 11 Jul 2019 09:27:30 +0000 (GMT) Received: from SFHDAG6NODE3.st.com (10.75.127.18) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 11 Jul 2019 11:27:30 +0200 Received: from SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6]) by SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6%20]) with mapi id 15.00.1473.003; Thu, 11 Jul 2019 11:27:30 +0200 From: Philippe CORNU To: Olivier MOYSAN , "a.hajda@samsung.com" , "narmstrong@baylibre.com" , "Laurent.pinchart@ideasonboard.com" , "jonas@kwiboo.se" , "jernej.skrabec@siol.net" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Benjamin GAIGNARD" , Alexandre TORGUE , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" , "jsarha@ti.com" Subject: Re: [PATCH] drm/bridge: sii902x: add audio graph card support Thread-Topic: [PATCH] drm/bridge: sii902x: add audio graph card support Thread-Index: AQHVMXX5EUvh0puEZ0ygMEtXg5C9Kaa72VsAgAgKHwCAAS3HAA== Date: Thu, 11 Jul 2019 09:27:30 +0000 Message-ID: References: <1562141052-26221-1-git-send-email-olivier.moysan@st.com> <7c17b3f2-afee-7548-7620-b67d11d09b24@st.com> <20190710152720.GR15868@phenom.ffwll.local> In-Reply-To: <20190710152720.GR15868@phenom.ffwll.local> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-ID: <97E4496BC2C9B749B2D4DC4A340B3153@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-11_01:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190711_022749_028200_0CD80692 X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On 7/10/19 5:27 PM, Daniel Vetter wrote: > On Fri, Jul 05, 2019 at 12:41:03PM +0000, Philippe CORNU wrote: >> Hi Olivier, >> and many thanks for your patch. >> Good to have the audio graph card support, looks ok. >> Reviewed-by: Philippe Cornu > > Since you have drm-misc commit rights I'm assuming you're going to push > this too. Correct? > -Daniel Regarding this patch in particular, there is still missing an acked-by from a "bridge" maintainer. Also it could be nice to wait for the reviewed-by from Jiry as it knows well this sii driver and sent recently good patches on it (already merged). With that, Benjamin or I (or a bridge maintainer) can push this patch + the serie named "drm/bridge: sii902x: fix audio mclk management" as I think it is better to push this serie *before* this patch. Thanks, Philippe :-) >> Philippe :-) >> >> On 7/3/19 10:04 AM, Olivier Moysan wrote: >>> Implement get_dai_id callback of audio HDMI codec >>> to support ASoC audio graph card. >>> HDMI audio output has to be connected to sii902x port 3. >>> get_dai_id callback maps this port to ASoC DAI index 0. >>> >>> Signed-off-by: Olivier Moysan >>> --- >>> drivers/gpu/drm/bridge/sii902x.c | 23 +++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c >>> index dd7aa466b280..daf9ef3cd817 100644 >>> --- a/drivers/gpu/drm/bridge/sii902x.c >>> +++ b/drivers/gpu/drm/bridge/sii902x.c >>> @@ -158,6 +158,8 @@ >>> >>> #define SII902X_I2C_BUS_ACQUISITION_TIMEOUT_MS 500 >>> >>> +#define SII902X_AUDIO_PORT_INDEX 3 >>> + >>> struct sii902x { >>> struct i2c_client *i2c; >>> struct regmap *regmap; >>> @@ -690,11 +692,32 @@ static int sii902x_audio_get_eld(struct device *dev, void *data, >>> return 0; >>> } >>> >>> +static int sii902x_audio_get_dai_id(struct snd_soc_component *component, >>> + struct device_node *endpoint) >>> +{ >>> + struct of_endpoint of_ep; >>> + int ret; >>> + >>> + ret = of_graph_parse_endpoint(endpoint, &of_ep); >>> + if (ret < 0) >>> + return ret; >>> + >>> + /* >>> + * HDMI sound should be located at reg = <3> >>> + * Return expected DAI index 0. >>> + */ >>> + if (of_ep.port == SII902X_AUDIO_PORT_INDEX) >>> + return 0; >>> + >>> + return -EINVAL; >>> +} >>> + >>> static const struct hdmi_codec_ops sii902x_audio_codec_ops = { >>> .hw_params = sii902x_audio_hw_params, >>> .audio_shutdown = sii902x_audio_shutdown, >>> .digital_mute = sii902x_audio_digital_mute, >>> .get_eld = sii902x_audio_get_eld, >>> + .get_dai_id = sii902x_audio_get_dai_id, >>> }; >>> >>> static int sii902x_audio_codec_init(struct sii902x *sii902x, >>> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel