From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C95C433E1 for ; Sun, 12 Jul 2020 15:33:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE4B8206F4 for ; Sun, 12 Jul 2020 15:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MAki5t2f"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W9J4Lfge" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE4B8206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x/J1v7SXc5eNpBXU09tC9WeKbbQGaQtsmfVn6s7AE6U=; b=MAki5t2fDIEJcm9J0q6RS1WcR D18jAruKEYRyqkTARgH1lvvGqd/iD/O2l/znSfujEUI2gbxxFNaQUutoPM7K095CCGBastK7I5uCp bnNsYHWOT5kOrX4avwN5BaSHRKUr2/RuAZ7sKjuEDopc0Pjfw8Tcg2AESrTaoIGn/VSevJeOXahOu lT4bhxsLFRIDHp3VvMGuiHesTlZ3tzkH7IdGEk7hDnSlkuc3HTbxjikx4/1nb0JpCGwcQxKaDFxLC xCqoJY526HnH1Tc6eHnAHDi5GupjyCvpCaCPoA9AUJ+2p1J3Yd/fOtCDNAwmGIcLvFJ26MMc7/J1/ gG+FJSZbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1judwx-0007IG-Tr; Sun, 12 Jul 2020 15:31:31 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1judwu-0007Hr-MD for linux-arm-kernel@lists.infradead.org; Sun, 12 Jul 2020 15:31:29 +0000 Received: by mail-ed1-x544.google.com with SMTP id g20so8675974edm.4 for ; Sun, 12 Jul 2020 08:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OC8AObzew9aqd3OWFgWAH1kVdGnLQeAxyBxr457j2LY=; b=W9J4LfgeIK144Btt0OSLh+fJulag+sR0kLYVE2lDrPCcBOy+ajXJWVer78aAUIWXJm oofzVCY/g/c/gg9L7RL8YWB5vwjwBb6JHnectBiFiftnAtRBVaH0Z2VRpRDjtEuHUTdh vK8n5T2Cx+UsODr9SKNHypR6Xr0c0Ag0Wj2AAHJqYUDysbMnQcj0Ov6Uk3ByOj0ap40Z +/WKwmJ26niqbmuQBFaEV5L+mDLruaLzYtKOTSc5Oo4+RYd730nm4/A8No/ibttfXSuy lYlcVXOnO1HsfuW7Fq9RkLTJanXT8XLxf7Nci3GZ9OyHBEAhiwGkFn5BQaN9Lj1j2YLg X2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OC8AObzew9aqd3OWFgWAH1kVdGnLQeAxyBxr457j2LY=; b=dZaZL4vtTzSza2J/mafhb1hPPQqgpEQzJcDwHqQBW77MCRsnWKs17Z81dtFfE/cqnG 3iIF80k9/eS5C+NCGlUMVy68Y1X/yT/C7SNljzQdD+URLCftiNCoNZB/ibTTVQW4meFy pL1Xl8rU//wzQ2HM7mfgn/Y2YW9lpEXQbPEjkr+vGJXN5SmGSyj/9+zO7jEb/Nc32SJm CeFMu0FGd5ZxxzNMmtJHwO2uodbcH7Ssvp8DWJlOCh+NBuxbPvvB4CUZcwulqB0AQpNo wdEJTgbAhOR0n6wz8R/KKXgT6HOa0liD6C4VMMHtNBzu/r3aOsa6MvIMOpVONUWNf3ie IFpA== X-Gm-Message-State: AOAM533ffWnOHMFmiVpgBwEqHvLaLhzN0V5xQ/LeZOLrB8k91x7woqdN 8YBrElEXRFZXyHXEFL7WZWc1X7Jx X-Google-Smtp-Source: ABdhPJwJm7304izUL0IgGkG7yBGMirci+PY/YyegBIwPgXeaCR/OkgnpmwgdXrXRFn3RWKIOrW3fJw== X-Received: by 2002:a50:f058:: with SMTP id u24mr87330213edl.351.1594567886745; Sun, 12 Jul 2020 08:31:26 -0700 (PDT) Received: from ?IPv6:2a01:110f:b59:fd00:cdeb:44e7:80ea:5ee2? ([2a01:110f:b59:fd00:cdeb:44e7:80ea:5ee2]) by smtp.gmail.com with ESMTPSA id d5sm9570554eds.40.2020.07.12.08.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2020 08:31:26 -0700 (PDT) Subject: Re: [PATCH v29 13/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function To: Pavel Machek References: <20200622185919.2131-1-dmurphy@ti.com> <20200622185919.2131-14-dmurphy@ti.com> <20200711155749.GB22715@amd> <20200711202419.GA18347@duo.ucw.cz> From: Jacek Anaszewski Message-ID: Date: Sun, 12 Jul 2020 17:31:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200711202419.GA18347@duo.ucw.cz> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_113128_768782_B35697C1 X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/11/20 10:24 PM, Pavel Machek wrote: > On Sat 2020-07-11 19:19:22, Jacek Anaszewski wrote: >> On 7/11/20 5:57 PM, Pavel Machek wrote: >>> Hi! >>> >>>> Add the multicolor brightness call back to support the multicolor >>>> framework. This call back allows setting brightness on grouped channels >>> >>> Extra space before "brightness". >> >> And before "This". > > That one is intentional, I believe. > > https://www.independent.co.uk/life-style/gadgets-and-tech/news/one-space-or-two-spaces-after-a-full-stop-scientists-have-finally-found-the-answer-a8337646.html > > We are using fixed width fonts, so typewriter rules still apply here. But see the article [0]. Also, in [1], in the section "Computer era" you can find opposite examples in the modern systems. And grep returns following numbers for kernel Documentation folder: $ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l 18449 $ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l 63067 I prefer single space but will not fight for that too hard. Nonetheless, it would be good to use one style consistently, since most files I've looked at had problem with that. Both DT and LED documentation in this set is not consistent in this regard as well. [0] https://www.instructionalsolutions.com/blog/one-space-vs-two-after-period [1] https://en.wikipedia.org/wiki/Sentence_spacing -- Best regards, Jacek Anaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel