From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Henrik Grimler" <henrik@grimler.se>,
"Chanwoo Choi" <cw00.choi@samsung.com>
Subject: Re: [PATCH 8/8] arm64: dts: exynos: move MIPI phy to PMU node in Exynos5433
Date: Fri, 27 Jan 2023 23:16:43 +0100 [thread overview]
Message-ID: <e2bca7ec-4e0d-e4b5-9933-a5be81d63f2b@samsung.com> (raw)
In-Reply-To: <20230127194057.186458-9-krzysztof.kozlowski@linaro.org>
On 27.01.2023 20:40, Krzysztof Kozlowski wrote:
> The MIPI phy is actually part of the Power Management Unit system
> controller. It does not have own address space, thus keeping the node
> under soc causes warnings:
>
> exynos5433-tm2e.dtb: soc@0: video-phy: {'compatible': ['samsung,exynos5433-mipi-video-phy'], ...
> should not be valid under {'type': 'object'}
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 9da24fe958a3..842976addbd9 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -911,12 +911,20 @@ pinctrl_touch: pinctrl@14ce0000 {
> };
>
> pmu_system_controller: system-controller@105c0000 {
> - compatible = "samsung,exynos5433-pmu", "syscon";
> + compatible = "samsung,exynos5433-pmu", "simple-mfd", "syscon";
> reg = <0x105c0000 0x5008>;
> #clock-cells = <1>;
> clock-names = "clkout16";
> clocks = <&xxti>;
>
> + mipi_phy: mipi-phy {
> + compatible = "samsung,exynos5433-mipi-video-phy";
> + #phy-cells = <1>;
> + samsung,cam0-sysreg = <&syscon_cam0>;
> + samsung,cam1-sysreg = <&syscon_cam1>;
> + samsung,disp-sysreg = <&syscon_disp>;
> + };
> +
> reboot: syscon-reboot {
> compatible = "syscon-reboot";
> regmap = <&pmu_system_controller>;
> @@ -936,15 +944,6 @@ gic: interrupt-controller@11001000 {
> interrupts = <GIC_PPI 9 0xf04>;
> };
>
> - mipi_phy: video-phy {
> - compatible = "samsung,exynos5433-mipi-video-phy";
> - #phy-cells = <1>;
> - samsung,pmu-syscon = <&pmu_system_controller>;
> - samsung,cam0-sysreg = <&syscon_cam0>;
> - samsung,cam1-sysreg = <&syscon_cam1>;
> - samsung,disp-sysreg = <&syscon_disp>;
> - };
> -
> decon: decon@13800000 {
> compatible = "samsung,exynos5433-decon";
> reg = <0x13800000 0x2104>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-27 22:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 19:40 [PATCH 0/8] dt-bindings: phy/samsung: move MIPI and DP phys under PMU Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 1/8] dt-bindings: soc: samsung: exynos-pmu: allow phys as child Krzysztof Kozlowski
2023-01-27 21:23 ` Rob Herring
2023-01-29 10:40 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 2/8] dt-bindings: phy: samsung,dp-video-phy: deprecate syscon phandle Krzysztof Kozlowski
2023-01-30 21:15 ` Rob Herring
2023-01-31 17:32 ` Krzysztof Kozlowski
2023-02-03 13:38 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 3/8] dt-bindings: phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-01-30 21:16 ` Rob Herring
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 4/8] phy: samsung,dp-video-phy: " Krzysztof Kozlowski
2023-02-03 13:41 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 5/8] phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-02-03 13:42 ` Vinod Koul
2023-02-03 15:10 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420 Krzysztof Kozlowski
2023-01-27 22:54 ` Marek Szyprowski
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 7/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5250 Krzysztof Kozlowski
2023-01-27 22:53 ` Marek Szyprowski
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 8/8] arm64: dts: exynos: move MIPI phy to PMU node in Exynos5433 Krzysztof Kozlowski
2023-01-27 22:16 ` Marek Szyprowski [this message]
2023-03-06 11:39 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2bca7ec-4e0d-e4b5-9933-a5be81d63f2b@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=replicant@osuosl.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).