Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Allwinner DT Changes for 7.2
@ 2026-06-01 19:09 Chen-Yu Tsai
  2026-06-09 11:43 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2026-06-01 19:09 UTC (permalink / raw)
  To: soc
  Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel, Stephen Boyd

[-- Attachment #1: Type: text/plain, Size: 3042 bytes --]

The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:

  Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2

for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:

  arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)


As mentioned in the tag, this pull request contains a change that should
be shared between the soc and clk trees. However since I don't have any
clk changes to send this cycle, I think it can just go through the soc
tree without any issues.

----------------------------------------------------------------
Allwinner device tree changes for 7.2

Some changes for old chips and some for recent ones.

- A83T gained the MIPI CSI-2 receiver
- overlays enabled for Pine64 boards
- V3s gained the MBUS interconnect
- D1s / T113 and H616 gained the high speed timer
- T113s watchdog enabled (for reboot)
- H616 gained proper SRAM regions
- A523 family gained EL2 virtual timer interrupt and GPADC

This tag also contains a clk DT binding change that changes a private
header of the clk driver to export some extra clocks to the device tree
on the V3s.

----------------------------------------------------------------
Chen-Yu Tsai (1):
      Merge branch 'sunxi/shared-clk-dt-ids-for-7.2' into sunxi/dt-for-7.2

Jernej Skrabec (1):
      arm64: dts: allwinner: sun50i-h616: Add SRAM nodes

Marc Zyngier (1):
      arm64: dts: allwinner: Add EL2 virtual timer interrupt

Michal Piekos (4):
      riscv: dts: allwinner: d1s-t113: add hstimer node
      arm64: dts: allwinner: h616: add hstimer node
      arm: dts: allwinner: t113s: enable watchdog for reboot
      arm64: dts: allwinner: a523: add gpadc node

Paul Kocialkowski (5):
      clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header
      dt-bindings: media: sun6i-a31-csi: Add optional interconnect properties
      dt-bindings: media: sun6i-a31-isp: Add optional interconnect properties
      ARM: dts: sun8i: v3s: Add mbus node to represent the interconnect
      ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node

Peter Robinson (1):
      arm64: dts: allwinner: sun50i-a64: Enable DT overlays

 .../bindings/media/allwinner,sun6i-a31-csi.yaml    |  6 +++
 .../bindings/media/allwinner,sun6i-a31-isp.yaml    |  6 +++
 arch/arm/boot/dts/allwinner/sun8i-a83t.dtsi        | 43 ++++++++++++++++++++++
 arch/arm/boot/dts/allwinner/sun8i-t113s.dtsi       |  4 ++
 arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi         | 15 ++++++++
 arch/arm64/boot/dts/allwinner/Makefile             |  6 +++
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi     | 38 ++++++++++++++++++-
 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi     | 16 +++++++-
 arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi  |  9 +++++
 drivers/clk/sunxi-ng/ccu-sun8i-v3s.h               |  4 --
 include/dt-bindings/clock/sun8i-v3s-ccu.h          |  4 +-
 11 files changed, 143 insertions(+), 8 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-01 19:09 [GIT PULL] Allwinner DT Changes for 7.2 Chen-Yu Tsai
@ 2026-06-09 11:43 ` Krzysztof Kozlowski
  2026-06-09 11:48   ` Chen-Yu Tsai
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-09 11:43 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel, Stephen Boyd

On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> 
>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> 
> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> 
>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> 
> 
> As mentioned in the tag, this pull request contains a change that should
> be shared between the soc and clk trees. However since I don't have any
> clk changes to send this cycle, I think it can just go through the soc
> tree without any issues.

But the clock driver change cannot be in the DTS branch. This should go
via clock tree even if it is one change. And definitely not via DTS
branch.

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 11:43 ` Krzysztof Kozlowski
@ 2026-06-09 11:48   ` Chen-Yu Tsai
  2026-06-09 11:51     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2026-06-09 11:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel, Stephen Boyd

On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> > The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> >
> >   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> >
> > are available in the Git repository at:
> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> >
> > for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> >
> >   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> >
> >
> > As mentioned in the tag, this pull request contains a change that should
> > be shared between the soc and clk trees. However since I don't have any
> > clk changes to send this cycle, I think it can just go through the soc
> > tree without any issues.
>
> But the clock driver change cannot be in the DTS branch. This should go
> via clock tree even if it is one change. And definitely not via DTS
> branch.

It is a shared change, because it moves two symbols from the driver's
private header to the public DT binding header. I don't see how this
can go through just the clk tree when one of the subsequent patches
uses those new symbols.

"clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
interconnect".

The other way to go about this is to use raw numbers first, then
another patch in the next cycle to switch the numbers to actual
macros. IMHO not worth the churn and headache.


ChenYu


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 11:48   ` Chen-Yu Tsai
@ 2026-06-09 11:51     ` Krzysztof Kozlowski
  2026-06-09 12:38       ` Chen-Yu Tsai
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-09 11:51 UTC (permalink / raw)
  To: wens
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel, Stephen Boyd

On 09/06/2026 13:48, Chen-Yu Tsai wrote:
> On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
>>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
>>>
>>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
>>>
>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
>>>
>>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
>>>
>>>
>>> As mentioned in the tag, this pull request contains a change that should
>>> be shared between the soc and clk trees. However since I don't have any
>>> clk changes to send this cycle, I think it can just go through the soc
>>> tree without any issues.
>>
>> But the clock driver change cannot be in the DTS branch. This should go
>> via clock tree even if it is one change. And definitely not via DTS
>> branch.
> 
> It is a shared change, because it moves two symbols from the driver's
> private header to the public DT binding header. I don't see how this
> can go through just the clk tree when one of the subsequent patches
> uses those new symbols.
> 
> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
> interconnect".
> 
> The other way to go about this is to use raw numbers first, then
> another patch in the next cycle to switch the numbers to actual
> macros. IMHO not worth the churn and headache.

You can have a duplicated define.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 11:51     ` Krzysztof Kozlowski
@ 2026-06-09 12:38       ` Chen-Yu Tsai
  2026-06-09 13:18         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2026-06-09 12:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Stephen Boyd
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel

On Tue, Jun 9, 2026 at 8:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 09/06/2026 13:48, Chen-Yu Tsai wrote:
> > On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> >>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> >>>
> >>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> >>>
> >>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> >>>
> >>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> >>>
> >>>
> >>> As mentioned in the tag, this pull request contains a change that should
> >>> be shared between the soc and clk trees. However since I don't have any
> >>> clk changes to send this cycle, I think it can just go through the soc
> >>> tree without any issues.
> >>
> >> But the clock driver change cannot be in the DTS branch. This should go
> >> via clock tree even if it is one change. And definitely not via DTS
> >> branch.
> >
> > It is a shared change, because it moves two symbols from the driver's
> > private header to the public DT binding header. I don't see how this
> > can go through just the clk tree when one of the subsequent patches
> > uses those new symbols.
> >
> > "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
> > is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
> > interconnect".
> >
> > The other way to go about this is to use raw numbers first, then
> > another patch in the next cycle to switch the numbers to actual
> > macros. IMHO not worth the churn and headache.
>
> You can have a duplicated define.

I honestly did not know that it worked.

However, splitting what is effectively one logical change (*move*
something) into two patches just to be able to merge them through two
separate trees still seems wrong to me.

Would it help if Stephen gave an ack?


ChenYu


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 12:38       ` Chen-Yu Tsai
@ 2026-06-09 13:18         ` Krzysztof Kozlowski
  2026-06-09 13:26           ` Chen-Yu Tsai
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-09 13:18 UTC (permalink / raw)
  To: wens, Stephen Boyd
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel

On 09/06/2026 14:38, Chen-Yu Tsai wrote:
> On Tue, Jun 9, 2026 at 8:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 09/06/2026 13:48, Chen-Yu Tsai wrote:
>>> On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
>>>>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
>>>>>
>>>>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
>>>>>
>>>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
>>>>>
>>>>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
>>>>>
>>>>>
>>>>> As mentioned in the tag, this pull request contains a change that should
>>>>> be shared between the soc and clk trees. However since I don't have any
>>>>> clk changes to send this cycle, I think it can just go through the soc
>>>>> tree without any issues.
>>>>
>>>> But the clock driver change cannot be in the DTS branch. This should go
>>>> via clock tree even if it is one change. And definitely not via DTS
>>>> branch.
>>>
>>> It is a shared change, because it moves two symbols from the driver's
>>> private header to the public DT binding header. I don't see how this
>>> can go through just the clk tree when one of the subsequent patches
>>> uses those new symbols.
>>>
>>> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
>>> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
>>> interconnect".
>>>
>>> The other way to go about this is to use raw numbers first, then
>>> another patch in the next cycle to switch the numbers to actual
>>> macros. IMHO not worth the churn and headache.
>>
>> You can have a duplicated define.
> 
> I honestly did not know that it worked.
> 
> However, splitting what is effectively one logical change (*move*
> something) into two patches just to be able to merge them through two
> separate trees still seems wrong to me.

It is not really one logical change. Defining a new ABI (binding header
define) is considered one change. Merging binding change into driver
commit breaks rule of splitting bindings from implementation.

Second rule is that DTS branch CANNOT take driver changes. So if you do
not want to adhere to the above rule you still cannot combine it into
DTS branch.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 13:18         ` Krzysztof Kozlowski
@ 2026-06-09 13:26           ` Chen-Yu Tsai
  2026-06-09 13:46             ` Paul Kocialkowski
  0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2026-06-09 13:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: soc, Jernej Skrabec, Samuel Holland, linux-sunxi,
	linux-arm-kernel, Paul Kocialkowski

On Tue, Jun 9, 2026 at 10:18 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 09/06/2026 14:38, Chen-Yu Tsai wrote:
> > On Tue, Jun 9, 2026 at 8:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 09/06/2026 13:48, Chen-Yu Tsai wrote:
> >>> On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>>
> >>>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> >>>>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> >>>>>
> >>>>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> >>>>>
> >>>>> are available in the Git repository at:
> >>>>>
> >>>>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> >>>>>
> >>>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> >>>>>
> >>>>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> >>>>>
> >>>>>
> >>>>> As mentioned in the tag, this pull request contains a change that should
> >>>>> be shared between the soc and clk trees. However since I don't have any
> >>>>> clk changes to send this cycle, I think it can just go through the soc
> >>>>> tree without any issues.
> >>>>
> >>>> But the clock driver change cannot be in the DTS branch. This should go
> >>>> via clock tree even if it is one change. And definitely not via DTS
> >>>> branch.
> >>>
> >>> It is a shared change, because it moves two symbols from the driver's
> >>> private header to the public DT binding header. I don't see how this
> >>> can go through just the clk tree when one of the subsequent patches
> >>> uses those new symbols.
> >>>
> >>> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
> >>> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
> >>> interconnect".
> >>>
> >>> The other way to go about this is to use raw numbers first, then
> >>> another patch in the next cycle to switch the numbers to actual
> >>> macros. IMHO not worth the churn and headache.
> >>
> >> You can have a duplicated define.
> >
> > I honestly did not know that it worked.
> >
> > However, splitting what is effectively one logical change (*move*
> > something) into two patches just to be able to merge them through two
> > separate trees still seems wrong to me.
>
> It is not really one logical change. Defining a new ABI (binding header
> define) is considered one change. Merging binding change into driver
> commit breaks rule of splitting bindings from implementation.
>
> Second rule is that DTS branch CANNOT take driver changes. So if you do
> not want to adhere to the above rule you still cannot combine it into
> DTS branch.

Very well. I will drop the two changes and send a revised pull request.

Paul, can you redo the clk changes as requested in the next cycle?


Thanks
ChenYu


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 13:26           ` Chen-Yu Tsai
@ 2026-06-09 13:46             ` Paul Kocialkowski
  2026-06-09 14:02               ` Chen-Yu Tsai
  0 siblings, 1 reply; 9+ messages in thread
From: Paul Kocialkowski @ 2026-06-09 13:46 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Krzysztof Kozlowski, soc, Jernej Skrabec, Samuel Holland,
	linux-sunxi, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 3586 bytes --]

Hi,

Le Tue 09 Jun 26, 22:26, Chen-Yu Tsai a écrit :
> On Tue, Jun 9, 2026 at 10:18 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On 09/06/2026 14:38, Chen-Yu Tsai wrote:
> > > On Tue, Jun 9, 2026 at 8:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >>
> > >> On 09/06/2026 13:48, Chen-Yu Tsai wrote:
> > >>> On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >>>>
> > >>>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> > >>>>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> > >>>>>
> > >>>>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> > >>>>>
> > >>>>> are available in the Git repository at:
> > >>>>>
> > >>>>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> > >>>>>
> > >>>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> > >>>>>
> > >>>>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> > >>>>>
> > >>>>>
> > >>>>> As mentioned in the tag, this pull request contains a change that should
> > >>>>> be shared between the soc and clk trees. However since I don't have any
> > >>>>> clk changes to send this cycle, I think it can just go through the soc
> > >>>>> tree without any issues.
> > >>>>
> > >>>> But the clock driver change cannot be in the DTS branch. This should go
> > >>>> via clock tree even if it is one change. And definitely not via DTS
> > >>>> branch.
> > >>>
> > >>> It is a shared change, because it moves two symbols from the driver's
> > >>> private header to the public DT binding header. I don't see how this
> > >>> can go through just the clk tree when one of the subsequent patches
> > >>> uses those new symbols.
> > >>>
> > >>> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
> > >>> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
> > >>> interconnect".
> > >>>
> > >>> The other way to go about this is to use raw numbers first, then
> > >>> another patch in the next cycle to switch the numbers to actual
> > >>> macros. IMHO not worth the churn and headache.
> > >>
> > >> You can have a duplicated define.
> > >
> > > I honestly did not know that it worked.
> > >
> > > However, splitting what is effectively one logical change (*move*
> > > something) into two patches just to be able to merge them through two
> > > separate trees still seems wrong to me.
> >
> > It is not really one logical change. Defining a new ABI (binding header
> > define) is considered one change. Merging binding change into driver
> > commit breaks rule of splitting bindings from implementation.
> >
> > Second rule is that DTS branch CANNOT take driver changes. So if you do
> > not want to adhere to the above rule you still cannot combine it into
> > DTS branch.
> 
> Very well. I will drop the two changes and send a revised pull request.
> 
> Paul, can you redo the clk changes as requested in the next cycle?

Sure, so if I understand correctly, commit:
clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public headersunxi

should be split into two, one adding the definitions to the dt-bindings
headers first and a second one removing them from the clk driver?

Can it still make it for 7.2?

All the best,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Allwinner DT Changes for 7.2
  2026-06-09 13:46             ` Paul Kocialkowski
@ 2026-06-09 14:02               ` Chen-Yu Tsai
  0 siblings, 0 replies; 9+ messages in thread
From: Chen-Yu Tsai @ 2026-06-09 14:02 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: Krzysztof Kozlowski, soc, Jernej Skrabec, Samuel Holland,
	linux-sunxi, linux-arm-kernel

On Tue, Jun 9, 2026 at 10:46 PM Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> Hi,
>
> Le Tue 09 Jun 26, 22:26, Chen-Yu Tsai a écrit :
> > On Tue, Jun 9, 2026 at 10:18 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On 09/06/2026 14:38, Chen-Yu Tsai wrote:
> > > > On Tue, Jun 9, 2026 at 8:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >>
> > > >> On 09/06/2026 13:48, Chen-Yu Tsai wrote:
> > > >>> On Tue, Jun 9, 2026 at 8:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >>>>
> > > >>>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote:
> > > >>>>> The following changes since commit 254f49634ee16a731174d2ae34bc50bd5f45e731:
> > > >>>>>
> > > >>>>>   Linux 7.1-rc1 (2026-04-26 14:19:00 -0700)
> > > >>>>>
> > > >>>>> are available in the Git repository at:
> > > >>>>>
> > > >>>>>   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-dt-for-7.2
> > > >>>>>
> > > >>>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c247e565f:
> > > >>>>>
> > > >>>>>   arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:58 +0800)
> > > >>>>>
> > > >>>>>
> > > >>>>> As mentioned in the tag, this pull request contains a change that should
> > > >>>>> be shared between the soc and clk trees. However since I don't have any
> > > >>>>> clk changes to send this cycle, I think it can just go through the soc
> > > >>>>> tree without any issues.
> > > >>>>
> > > >>>> But the clock driver change cannot be in the DTS branch. This should go
> > > >>>> via clock tree even if it is one change. And definitely not via DTS
> > > >>>> branch.
> > > >>>
> > > >>> It is a shared change, because it moves two symbols from the driver's
> > > >>> private header to the public DT binding header. I don't see how this
> > > >>> can go through just the clk tree when one of the subsequent patches
> > > >>> uses those new symbols.
> > > >>>
> > > >>> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header"
> > > >>> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the
> > > >>> interconnect".
> > > >>>
> > > >>> The other way to go about this is to use raw numbers first, then
> > > >>> another patch in the next cycle to switch the numbers to actual
> > > >>> macros. IMHO not worth the churn and headache.
> > > >>
> > > >> You can have a duplicated define.
> > > >
> > > > I honestly did not know that it worked.
> > > >
> > > > However, splitting what is effectively one logical change (*move*
> > > > something) into two patches just to be able to merge them through two
> > > > separate trees still seems wrong to me.
> > >
> > > It is not really one logical change. Defining a new ABI (binding header
> > > define) is considered one change. Merging binding change into driver
> > > commit breaks rule of splitting bindings from implementation.
> > >
> > > Second rule is that DTS branch CANNOT take driver changes. So if you do
> > > not want to adhere to the above rule you still cannot combine it into
> > > DTS branch.
> >
> > Very well. I will drop the two changes and send a revised pull request.
> >
> > Paul, can you redo the clk changes as requested in the next cycle?
>
> Sure, so if I understand correctly, commit:
> clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public headersunxi
>
> should be split into two, one adding the definitions to the dt-bindings
> headers first and a second one removing them from the clk driver?

Correct.

> Can it still make it for 7.2?

If you send it out soon, then maybe I can send both in a PR to Stephen.
But the v3s dts patch is not going to make it.


ChenYu


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-06-09 14:03 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-01 19:09 [GIT PULL] Allwinner DT Changes for 7.2 Chen-Yu Tsai
2026-06-09 11:43 ` Krzysztof Kozlowski
2026-06-09 11:48   ` Chen-Yu Tsai
2026-06-09 11:51     ` Krzysztof Kozlowski
2026-06-09 12:38       ` Chen-Yu Tsai
2026-06-09 13:18         ` Krzysztof Kozlowski
2026-06-09 13:26           ` Chen-Yu Tsai
2026-06-09 13:46             ` Paul Kocialkowski
2026-06-09 14:02               ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox