From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B061CD8CAD for ; Tue, 9 Jun 2026 19:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zlJ1izUT3b9sB+0io6mLoy0ZthPU0QciI8/lQC0mX9k=; b=Wkg1f+GE6ds8Rh6rw7YfDgEvXa Qmo/cdKzhQ9QZGE551ney/wo0FbOOAudZqYB2zeERN9wcl0vX+XBamf/3TRP3Ua+D9cuOLqZIDVgM kN3ZVOpFCXAJiTjY1xxjFW0zMiI9ZxqFoEIypbE7vdQEHushK79P9dUmrOit87lQUWFbFmjA2Ik3D MXmhyOZErI+eH8CSW87ET77UOCwrf5hEiQM870wVeHzP1+BVHRFEBGtKxR/xIA+eQzr/mvwv/sxVa ZDh4m7mBySt0LTKVngY2vGTf91pTDdPYi82W1O7UItsfd2hxs0OrjmlmxWF+uK4qBP8kOP7cU7O/p IIphSHEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wX2EP-00000006IMz-2AuB; Tue, 09 Jun 2026 19:35:25 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wX2EN-00000006IMp-49iL for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2026 19:35:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1FE006024D; Tue, 9 Jun 2026 19:35:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E43171F00893; Tue, 9 Jun 2026 19:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781033722; bh=zlJ1izUT3b9sB+0io6mLoy0ZthPU0QciI8/lQC0mX9k=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Gd9LpgA160cfB/pEN+PDzhkZ7LFCleunnU1M3IKf0IBlUIXaY9QDopSebbZwf7Qag zmI6cLLBqG85XVBYEbj7bjBLOMVvrqsLXzqWMj61mrO1T1VsR8piS+6wF0FnWWPVhF TDx/+A6liba/InHQbSj4owgez1kYEOio+3iYbeOnFQfQz4uyp30QI0I2IJf7txJ1OD oDe61jjzYrLbpC7JlmU+jsvoS0KqTN32C7spSsDS7CDiYjnnHO8FpYuvheF3CHDeG4 CE5LRVhcsNTfVnjbCmIaGxlomAlGWu/7bN1PtYx30agk21czw/andOX84PRjlDvvUI Mtd64NkMtPrfA== Message-ID: Date: Tue, 9 Jun 2026 21:35:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/8] can: flexcan: use dedicated IRQ handlers for multi-IRQ platforms To: Ciprian Costea , Marc Kleine-Budde , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Haibo Chen References: <20260609142954.1807421-1-ciprianmarian.costea@oss.nxp.com> <20260609142954.1807421-2-ciprianmarian.costea@oss.nxp.com> From: Vincent Mailhol Content-Language: en-US Autocrypt: addr=mailhol@kernel.org; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN JFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbEBrZXJuZWwub3JnPsKZBBMWCgBBFiEE7Y9wBXTm fyDldOjiq1/riG27mcIFAmdfB/kCGwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQq1/riG27mcKBHgEAygbvORJOfMHGlq5lQhZkDnaUXbpZhxirxkAHwTypHr4A/joI 2wLjgTCm5I2Z3zB8hqJu+OeFPXZFWGTuk0e2wT4JzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrb YZzu0JG5w8gxE6EtQe6LmxKMqP6EyR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDl dOjiq1/riG27mcIFAmceMvMCGwwFCQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8V zsZwr/S44HCzcz5+jkxnVVQ5LZ4BANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: <20260609142954.1807421-2-ciprianmarian.costea@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2026 at 16:29, Ciprian Costea wrote: > From: Ciprian Marian Costea > > On platforms with multiple IRQ lines (S32G2, MCF5441X), all lines are > registered to the same flexcan_irq() handler. Since these are distinct IRQ > numbers, they can be dispatched concurrently on different CPUs. Both > instances then read the same iflag and ESR registers unconditionally, > leading to duplicate frame processing. > > Fix this by splitting the monolithic handler into focused parts: > - flexcan_do_mb(): processes mailbox events > - flexcan_do_state(): processes device state change events > - flexcan_do_berr(): processes bus error events > > Introduce dedicated IRQ handlers for multi-IRQ platforms: > - flexcan_irq_mb(): mailbox-only, used for mb-0, mb-1 IRQ lines > - flexcan_irq_boff(): state-change-only, used for boff/state IRQ line > - flexcan_irq_berr(): bus-error-only, used for berr IRQ line > > The combined flexcan_irq() handler is preserved for single-IRQ > platforms with no functional change. > > Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support") > Signed-off-by: Ciprian Marian Costea > Reviewed-and-tested-by: Haibo Chen > Tested-by: Enric Balletbo i Serra Reviewed-by: Vincent Mailhol Yours sincerely, Vincent Mailhol