From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 231A2C77B75 for ; Tue, 18 Apr 2023 11:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UQiFeHEOTeFRrTqK7vfITQxSkIMlIqmcknBfFtCm1OI=; b=J4MNCZUkkSbHp3 //Eq2VvVtRnahihKu1cTnlTh6XfGZzPP5u3hkvQ5plkas1QE8GShzo4KjxyVgHvk2/ps6GInpwb+e ZVfFNgXJYzIvCjNLodyFpJW6L3Za9xq0FcnlV/Ju4Ktmm5h7pYnresm+vUGMLVeuTvuW16YWMid3u HAWzWgwIU9Ooz2pbeWt+fNkRApdJAD4MxsBhJwABdjYjAxsDkh6h9xbFgJZYxz96rX1wJ17MOCVMe HG4iccELcc3PtnzotQlZBaNjm2lzMHWDHoRvLsxQJ8in7TKgqleVQiRa/CwysL2syj51bkjsX+KXU io3ODNi0fQITiduItiDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pojtu-0021ci-0R; Tue, 18 Apr 2023 11:53:34 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pojtr-0021Zm-1W; Tue, 18 Apr 2023 11:53:33 +0000 Received: from [192.168.1.90] (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9EAE96602338; Tue, 18 Apr 2023 12:53:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681818807; bh=F5bJnkMDohUh9rvK2TZXfUylvPcAO2pWW9e3hN5M+kk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YUXB4mlxVMv26uwQoJfBYvXdX77LTIslHy9CnC5wqb8CG8myJhTIkm6RVp5YmcgxL ge0idkj7yJrWuACks2Xkogd89V1gPN6lT4cu4zf9RQYEeKmxXy7UdsSb+OSaOIXseu D7mPLcyA9SATfml8FhdqfFc0nOO2u255937/Nucn1hcn6vu1sH/zO5x3M8UUaSRNVW B/K2EIy1nKFL1y2dU6/0x5/MqO/3n/ZH7gh8YOS6DvmX6OSeCHvv2q68j+xygd7xBG M1lr1afoplg/nviV3FCBg5ijeVfbjq2QntsfyHEDDs1c+xFU58+JMCc5V+aDCPRpyG BVLwQ58BhymwQ== Message-ID: Date: Tue, 18 Apr 2023 14:53:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add rk3588 timer Content-Language: en-US To: Johan Jonker , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sebastian Reichel , Sugar Zhang , Shreeya Patel , Kever Yang Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <20230418095344.274025-1-cristian.ciocaltea@collabora.com> <20230418095344.274025-4-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_045331_719922_941BE421 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/18/23 14:29, Johan Jonker wrote: > > > On 4/18/23 11:53, Cristian Ciocaltea wrote: >> Add DT node for Rockchip RK3588/RK3588S SoC timer. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi >> index 657c019d27fa..acd89a55374a 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi >> @@ -1400,6 +1400,14 @@ i2c5: i2c@fead0000 { >> status = "disabled"; >> }; >> > >> + rktimer: timer@feae0000 { > > There are multiple timers. > Use a label in line with the TRM. > Maybe change your label to "timer0" in that trend? Sure, will use "timer0". >> + compatible = "rockchip,rk3588-timer", "rockchip,rk3288-timer"; >> + reg = <0x0 0xfeae0000 0x0 0x20>; > >> + clocks = <&cru PCLK_BUSTIMER0>, <&cru CLK_BUSTIMER0>; >> + clock-names = "pclk", "timer"; >> + interrupts = ; > > Heiko's sort rules: > > compatible > reg > interrupts > [alphabetical] > status [if needed] Thanks for pointing this out! The sort rule was not obvious as there are many other nodes that don't conform. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel