Re: [PATCH v3 5/5] clk: samsung: add exynos7870 CLKOUT support

[Kaustabh Chakraborty <kauschluss@disroot.org>]

On 2025-02-19 13:41, Krzysztof Kozlowski wrote:
> On Wed, Feb 19, 2025 at 12:20:32AM +0530, Kaustabh Chakraborty wrote:
>> Exynos7870's CLKOUT registers are the same as Exynos5's. Add the PMU
>> compatible to the existing CLKOUT ID list.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  drivers/clk/samsung/clk-exynos-clkout.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
>> index 2ef5748c139b37ca5429b9071ee0e06f44fcf28e..9a31b1c311b45096f1d680b6724571854c08725c 100644
>> --- a/drivers/clk/samsung/clk-exynos-clkout.c
>> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
>> @@ -75,6 +75,9 @@ static const struct of_device_id exynos_clkout_ids[] = {
>>  	}, {
>>  		.compatible = "samsung,exynos5433-pmu",
>>  		.data = &exynos_clkout_exynos5,
>> +	}, {
>> +		.compatible = "samsung,exynos7870-pmu",
>> +		.data = &exynos_clkout_exynos5,
> 
> I wonder why do we need to keep growing this list? All devices are
> compatible, aren't they?

Well, there are two variants of compatibility having different mask
values.

> Do you use clkout, BTW?

Using the clocks defined by clkout? No. I added it as downstream
had it too. And the devices work fine without it. If you want me
to remove this patch and send the PMU patch to its respective
series I'll do that then (unless you object or suggest something
else).

> Best regards,
> Krzysztof