From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31274EDE98F for ; Thu, 14 Sep 2023 08:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+PTtiXgPryNJil8shumG/OZOMTGJWsif4eQKi3tdRuY=; b=J1MQi7WNOxtVH0 8w7KRgXBjwrXRCnMQyLGVFoPcGsDoKaSm5NwFQAYbvmruxbUUzTk3q741kyROwENNM8m4t0RW9uYd AMk9Xa/ZmnwG/xbEYSwebPbsgz6N1qkTg9iQbAnVZIW+r6mVm/F0zTsroQlp8Z3cLEraPkKqDbGC1 ymR6KL9p3yKclEJMJ7jKdUfDKQur8uTPSTlog/yOeVKMD7cKCd470nCNcfdCGD3T/4dqooGLq/+XE XOJm3bI7+s8QfshwIi9EwaFmJKcL9+jjiDqTjJ14Sd35dRlSj+aNv0oV+eG6xnzI9TV+90HR7M/Vq BPmiQcJqfIdNY8MmuqCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qghI3-007dn0-2m; Thu, 14 Sep 2023 08:01:31 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qghI2-007dma-0c for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 08:01:31 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-401b0d97850so6619995e9.2 for ; Thu, 14 Sep 2023 01:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694678488; x=1695283288; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=neHhhzHlruzM/bvrwbdgCTOdYr0CjWOhZQjc/HyIrV8=; b=smg2q7hlmCpmSV/NVqX9uxHTGRLcQ5qBp01GnOVrsmKrOYLrkYJqDLRb9Z8EcN7/3w fhhjqO1uUSsIi9f66g28nlYtqjGFsfWcTu5bEI5K1UeQe+fCtj9mKaBE9f7p07CvS3XI kMRKxmSNzQkJkrldJ90W8nN9hVLW1xF9Q8Cudx+aqoqdMVoZawF5v+/CsJzdMu206Vh4 eVNgV4mX++/zTIu38u5A+MCh0LkzdPMAy75qKxFKNB13YfnHNUOIHseiK4cuqpTkKvAZ BfE34eh45apclki1S6GXF9OUn6ZkXQUM7G2vzU/ycUbgXAUPKUhbnprPP03BbHxLVuPG 6haw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694678488; x=1695283288; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=neHhhzHlruzM/bvrwbdgCTOdYr0CjWOhZQjc/HyIrV8=; b=CEj1mR7Bn/J8axrzTRHrl05WdQ99mWGruyVe/zbGGM/bbprwwubQlPb3Lusk6K569X WJonsiuh6O7eT2HIZpuDXSX7T8CeiznC58ZTGWW9TSnb+wf5PmCuPpcROOHpSV70VCds nDB5XpwR9HOPQ68njV3y4blT1flluF0t4oYzQdcRiJYImmbpuLulsOyk4ZGdsXicqlYq 9HwWEAVM8lRc3RqN33iLB8KAEN8siCAzV0Pk7ryWHOXT3F40GK5Rq3iC4RWYqZZci80q JfKdARb4DbAWw9U2uPSRplYitIBRjrbTD8Ub5hJSzrqlAz1dF34STVQB5d8o3vl33eWj JMrg== X-Gm-Message-State: AOJu0Yz4t76Ukd4t2nH9MX73G13QkQVPwAxAzOG1tsvJsKfNyaiGtQFk 6ZwdGf+lXK/YLkd2+4qYUmBCvw== X-Google-Smtp-Source: AGHT+IFso3OC//te/RXHvw1AW0IiU72BrrwKpr4DwwZ5HlU8y8W3tOtFzamFowjrziqS++NJdjIMFA== X-Received: by 2002:a05:600c:219:b0:3fe:f45:772d with SMTP id 25-20020a05600c021900b003fe0f45772dmr3841053wmi.28.1694678487884; Thu, 14 Sep 2023 01:01:27 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id v26-20020a1cf71a000000b003fe1630a8f0sm4126065wmh.24.2023.09.14.01.01.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 01:01:25 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 10:01:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2] ARM: dts: exynos: enable polling in Exynos 4210 Content-Language: en-US To: Mateusz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Marek Szyprowski References: <20230911133417.14042-1-m.majewski2@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230911133417.14042-1-m.majewski2@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_010130_237318_BCDEB478 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/09/2023 15:34, Mateusz Majewski wrote: > It seems that thermal in Exynos 4210 is broken without this, as it will > never decrease cooling after increasing it. > > Signed-off-by: Mateusz Majewski > --- > v1 -> v2: Just uploaded separately from all the thermal: exynos: > patches with a shorter recipient list, no change otherwise. > > arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi > index 0e27c3375e2e..aae185b7f91c 100644 > --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi > @@ -391,8 +391,14 @@ &cpu_alert2 { > }; > > &cpu_thermal { > - polling-delay-passive = <0>; > - polling-delay = <0>; > + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. I fixed it up and applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel