From: Marc Zyngier <maz@kernel.org>
To: Jeremy Cline <jcline@redhat.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
Date: Wed, 05 Feb 2020 15:18:05 +0000 [thread overview]
Message-ID: <e3446187abb20eb2a95eae1f51b36ca1@kernel.org> (raw)
In-Reply-To: <20200205134146.82678-1-jcline@redhat.com>
On 2020-02-05 13:41, Jeremy Cline wrote:
> Fedora kernel builds on armv7hl began failing recently because
> kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> trace.h. Add the missing include.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
>
> I've not dug very deeply into what exactly changed between commit
> b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> handling").
>
> Fedora's build config is available at
> https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
This config doesn't have KVM enabled.
>
> virt/kvm/arm/trace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> index 204d210d01c2..cc94ccc68821 100644
> --- a/virt/kvm/arm/trace.h
> +++ b/virt/kvm/arm/trace.h
> @@ -4,6 +4,7 @@
>
> #include <kvm/arm_arch_timer.h>
> #include <linux/tracepoint.h>
> +#include <asm/kvm_arm.h>
>
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM kvm
After enabling KVM in the above config (which requires LPAE), I've
managed to reproduce
the problem.
Fix now queued, thanks.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-05 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 13:41 [PATCH] KVM: arm/arm64: Fix up includes for trace.h Jeremy Cline
2020-02-05 15:18 ` Marc Zyngier [this message]
2020-02-05 15:46 ` Jeremy Cline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3446187abb20eb2a95eae1f51b36ca1@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=jcline@redhat.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).