From: Marc Zyngier <maz@kernel.org>
To: Jing Zhang <jingzhangos@google.com>
Cc: suzuki.poulose@arm.com, catalin.marinas@arm.com,
qperret@google.com, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org, will@kernel.org,
kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com
Subject: Re: [PATCH] KVM: arm64: Remove redundant check for S2FWB
Date: Fri, 05 Feb 2021 17:24:06 +0000 [thread overview]
Message-ID: <e34480715d3d5e13e5238195d596feda@kernel.org> (raw)
In-Reply-To: <20210205044403.1559010-1-jingzhangos@google.com>
Hi Jing,
On 2021-02-05 04:44, Jing Zhang wrote:
> Remove redundant check for CPU feature S2FWB in dcache flush code
> to save some CPU cycles for every memslot flush and unmapping.
What CPU cycles? This is only a static branch. Can you actually
measure the overhead? What does it represent in the face of
a full memslot unmapping?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-05 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 4:44 [PATCH] KVM: arm64: Remove redundant check for S2FWB Jing Zhang
2021-02-05 17:24 ` Marc Zyngier [this message]
2021-02-05 18:56 ` Jing Zhang
2021-03-08 16:49 ` Will Deacon
2021-03-08 18:43 ` Jing Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e34480715d3d5e13e5238195d596feda@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=qperret@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).