* [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects
@ 2025-04-02 21:04 Wolfram Sang
2025-04-08 14:36 ` Alexandre Belloni
2025-04-11 14:32 ` Claudiu Beznea
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-04-02 21:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Boris Brezillon,
devicetree
NAND did not work on my USB-A9263. I discovered that the offending
commit converted the PIO bank for chip selects wrongly, so all A9263
boards need to be fixed.
Fixes: 1004a2977bdc ("ARM: dts: at91: Switch to the new NAND bindings")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
arch/arm/boot/dts/microchip/tny_a9263.dts | 2 +-
arch/arm/boot/dts/microchip/usb_a9263.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
index 471ea25296aa..93c5268a0845 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
@@ -152,7 +152,7 @@ nand_controller: nand-controller {
nand@3 {
reg = <0x3 0x0 0x800000>;
rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
- cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
nand-bus-width = <8>;
nand-ecc-mode = "soft";
nand-on-flash-bbt;
diff --git a/arch/arm/boot/dts/microchip/tny_a9263.dts b/arch/arm/boot/dts/microchip/tny_a9263.dts
index 3dd48b3e06da..fd8244b56e05 100644
--- a/arch/arm/boot/dts/microchip/tny_a9263.dts
+++ b/arch/arm/boot/dts/microchip/tny_a9263.dts
@@ -64,7 +64,7 @@ nand_controller: nand-controller {
nand@3 {
reg = <0x3 0x0 0x800000>;
rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
- cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
nand-bus-width = <8>;
nand-ecc-mode = "soft";
nand-on-flash-bbt;
diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts
index 60d7936dc562..ebaf198e1bc4 100644
--- a/arch/arm/boot/dts/microchip/usb_a9263.dts
+++ b/arch/arm/boot/dts/microchip/usb_a9263.dts
@@ -84,7 +84,7 @@ nand_controller: nand-controller {
nand@3 {
reg = <0x3 0x0 0x800000>;
rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
- cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
nand-bus-width = <8>;
nand-ecc-mode = "soft";
nand-on-flash-bbt;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects
2025-04-02 21:04 [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects Wolfram Sang
@ 2025-04-08 14:36 ` Alexandre Belloni
2025-04-11 14:32 ` Claudiu Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2025-04-08 14:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Claudiu Beznea, Boris Brezillon, devicetree
On 02/04/2025 23:04:46+0200, Wolfram Sang wrote:
> NAND did not work on my USB-A9263. I discovered that the offending
> commit converted the PIO bank for chip selects wrongly, so all A9263
> boards need to be fixed.
>
> Fixes: 1004a2977bdc ("ARM: dts: at91: Switch to the new NAND bindings")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
> arch/arm/boot/dts/microchip/tny_a9263.dts | 2 +-
> arch/arm/boot/dts/microchip/usb_a9263.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> index 471ea25296aa..93c5268a0845 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> @@ -152,7 +152,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> diff --git a/arch/arm/boot/dts/microchip/tny_a9263.dts b/arch/arm/boot/dts/microchip/tny_a9263.dts
> index 3dd48b3e06da..fd8244b56e05 100644
> --- a/arch/arm/boot/dts/microchip/tny_a9263.dts
> +++ b/arch/arm/boot/dts/microchip/tny_a9263.dts
> @@ -64,7 +64,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts
> index 60d7936dc562..ebaf198e1bc4 100644
> --- a/arch/arm/boot/dts/microchip/usb_a9263.dts
> +++ b/arch/arm/boot/dts/microchip/usb_a9263.dts
> @@ -84,7 +84,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> --
> 2.47.2
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects
2025-04-02 21:04 [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects Wolfram Sang
2025-04-08 14:36 ` Alexandre Belloni
@ 2025-04-11 14:32 ` Claudiu Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu Beznea @ 2025-04-11 14:32 UTC (permalink / raw)
To: Wolfram Sang, linux-arm-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nicolas Ferre,
Alexandre Belloni, Boris Brezillon, devicetree
On 03.04.2025 00:04, Wolfram Sang wrote:
> NAND did not work on my USB-A9263. I discovered that the offending
> commit converted the PIO bank for chip selects wrongly, so all A9263
> boards need to be fixed.
>
> Fixes: 1004a2977bdc ("ARM: dts: at91: Switch to the new NAND bindings")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to at91-dt, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-11 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-02 21:04 [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects Wolfram Sang
2025-04-08 14:36 ` Alexandre Belloni
2025-04-11 14:32 ` Claudiu Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).