From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1403AEE57DF for ; Mon, 11 Sep 2023 11:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JFuhg9q2rVP2D/Hir1+7fvW15DMGuV+ebJuM/2061oc=; b=oMVc+fu2et4/Wz WG1ZY/RKUDtAHvilr7OHgq73xiAgqr9Xdg/nMmtvzkBZGIkU56y2DCFQyzhlN/OoG5H6b9IO2Lx+e Zmvh1FoDcgZfJxVjrCB6DInpjmmqXdf4YI0ckY3r/cWqjps2bn8C25So1p/md44AM6juW/iJ1yhin c7njDb1i3E7qFay2NqWP3Z3o26rSF4h8hXwcG4uyH39LOjnmuOoRAEcu2ayKEX0wMfKJF+G0wuvUj GjfSaBWi4JXkcZPbibuMDtGRylZQvY6McfXin2qIHUEADL4NWpQhNeWRpzPiyuPgX9HTt1DrWZNxy DU9aGRCYcjoiBWgv9vDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfel5-000M1g-2A; Mon, 11 Sep 2023 11:07:11 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfel2-000M0F-2g for linux-arm-kernel@lists.infradead.org; Mon, 11 Sep 2023 11:07:10 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2bceb02fd2bso70856961fa.1 for ; Mon, 11 Sep 2023 04:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694430426; x=1695035226; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qmyHVYJDP9hmCywHRnsdxnvZ1q0Z/z3sEq/O/fzkRmM=; b=tlLIdL0Mlai6sVM7L1V2WFRCWqbE5dz7S5wWdOvPJe6aMe1yxWAgAYupmLy1nhXKKw cB9aJH5d4pgiaJlAKIx1ix257uo+S63fwGHSoe19KKwloHMkPvp4CZKCBkGLYBsZW3Di ZkElKCACIF70o/7HuVT4EUcbn7en0Jw8WFCxb162Y2MEyCwZXrePoUCniY7IELQijS1e IIopWatlp5YX+bznyjlqS5Ng6TGDAPQiQbIKaZ0Ptpo2MHcDGdaIyk77SXm1jVLDinmI I8CWcFabfG32ksz2P+u92cC5+BLz3UJuNAmuP3KsrA9tJvAYuKLRm0US64+q/5CZuMg5 9rtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694430426; x=1695035226; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qmyHVYJDP9hmCywHRnsdxnvZ1q0Z/z3sEq/O/fzkRmM=; b=j2TcsmnUo0RM27iPyw58vBkqC1Y+4IhaTMm/8zbHfoKNAeIYU8b6yvYbXFX+j8ilnt 00CxaGCMM7HDit75BD5tAvwnB2vkSdw4ZZSVFRdcI8PFT6yeHn+hL5z25JLFThCG8Z9b VcE8iXYPovn3G+wDRcMSbK3Q4IzVle2KtjisXYCw/ausc57tkZIK9SQKnChbEXkfTQW+ FhXk8n/DuUxuIqbsjcOvts178x9Xz27hiJX472Esc4sVeH7cXLCKSAxczDaX4OLYp64T OJFUQHKjvrY3B+8VUvfpCa7h8uQIZUQn3XEnWqUtERCSej08ZynuLGF4i2F9LMUuM0UC LxKw== X-Gm-Message-State: AOJu0YzhVhaoAz31p46XLD/f/ZRfk+wkIh655+iA2a/dupiH1PCBcrUF u7loitA4enTD9NszkSANjrzLHw== X-Google-Smtp-Source: AGHT+IFR8IFxIJ7reSkaYfAFLu1yRY1oO/AEBb0QIMYpht4GuEFk0sZxNE+qAxMWLhq3G4SDtzJ7xQ== X-Received: by 2002:a2e:9ed7:0:b0:2bd:124a:23d5 with SMTP id h23-20020a2e9ed7000000b002bd124a23d5mr8252127ljk.11.1694430425888; Mon, 11 Sep 2023 04:07:05 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id qn6-20020a170907210600b0099d9b50d786sm5219726ejb.199.2023.09.11.04.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 04:07:04 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 13:07:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver Content-Language: en-US To: Mukesh Ojha , corbet@lwn.net, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, mathieu.poirier@linaro.org, catalin.marinas@arm.com, will@kernel.org, linus.walleij@linaro.org, andy.shevchenko@gmail.com, vigneshr@ti.com, nm@ti.com, matthias.bgg@gmail.com, kgene@kernel.org, alim.akhtar@samsung.com, bmasney@redhat.com, quic_tsoni@quicinc.com Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@quicinc.com References: <1694290578-17733-1-git-send-email-quic_mojha@quicinc.com> <1694290578-17733-7-git-send-email-quic_mojha@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1694290578-17733-7-git-send-email-quic_mojha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230911_040708_911776_06511F22 X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/09/2023 22:16, Mukesh Ojha wrote: > +/** > + * qcom_minidump_region_register() - Register region in APSS Minidump table. > + * @region: minidump region. > + * > + * Return: On success, it returns 0 and negative error value on failure. > + */ > +int qcom_minidump_region_register(const struct qcom_minidump_region *region) > +{ > + struct minidump *md; > + int ret; > + > + md = qcom_smem_minidump_ready(); > + if (!md) > + return -EPROBE_DEFER; > + > + if (!qcom_minidump_valid_region(region)) > + return -EINVAL; > + > + mutex_lock(&md->md_lock); > + ret = qcom_md_region_register(md, region); > + if (ret) > + goto unlock; > + > + qcom_md_update_elfheader(md, region); > +unlock: > + mutex_unlock(&md->md_lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(qcom_minidump_region_register); NAK, there is no user for this. Drop all exports from minidump drivers. Your upstream driver *must not* expose stuff to your vendor drivers. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel