From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A63ACD37B0 for ; Mon, 18 Sep 2023 04:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m68cIskHOIEXYMjzeuZ6Rdi+Qv2UxMx/CERg/ZrXo8M=; b=ngU/IcRioaPW1/ KEkKVVrMpNSrdUVvRuTfwBRfbFyJWBKbsDLTN8uij499XX14W8NPiIPb1cE3phS4f2cOMv0uE2L+f TZ2sPeaJ45bdu6Jt1H5JVWU95XcM5SeMTX24KyWneapBL/3+LpmQmAOB0tElMRklMOYwUSV/3SSJv jhk+L7QERJV5sIZ2WZsnrGmZFkD2CBymHv/1ipkYLviJJxz1TZ/sjL96+z2Uu9JPQbvtEeRcDWVVS UxDyf5FgGMNCKFOZIgE4Pina+N3FzUgjsl++KGzb0x49Z+GjOZlT0SR6HP5g9nhcWPK+cFYLK6fSp IvYG20xm+YieZ/9H3MPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qi5eF-00EMRo-1s; Mon, 18 Sep 2023 04:14:11 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qi5eC-00EMQ0-0y for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 04:14:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695010445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+naNdgA3bFvfUIv4tJXTTMUwzR4YQ9euXBZfFED9oXc=; b=bl3l2u1XqElK6jVzafWBPtI31I0ra3u+VMoFEAOOl63/FZT9tlCg9ax7O70Q5mt7xaTJOv gkSqvhhHJ+EFj1yi8LW/lFFBFMX0InTZ+ZH5vNFXXn4IxmNKKk0RphOZ/JDJfRVKgxE3aF GSDIE7RCLwwdq5le0/HB/NfYzRYvvlo= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-3Anas8NLOPS0PIyLxXfaNg-1; Mon, 18 Sep 2023 00:13:59 -0400 X-MC-Unique: 3Anas8NLOPS0PIyLxXfaNg-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-274d83f0f5fso1314222a91.1 for ; Sun, 17 Sep 2023 21:13:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695010438; x=1695615238; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+naNdgA3bFvfUIv4tJXTTMUwzR4YQ9euXBZfFED9oXc=; b=YDk2HWub0R6sSoi57odBngQWopZNtSJ5ECP+fC5dpjH68tX0R+8j8nZLGbpj9/eDqb T+g9w1PltFPUfNQxr1sOrZSC3FbpZZ8oieg9zOzFL+C21vveFMclNhLWsbRzDGn4fZ1t jGgw2Xg8W7CA0jynAkhKYi2hql7fospedJMwmJjrGmdk+dz3eFnII/cBiFWXuK//d7q0 rN4o5TsXXm25B0RY4bWsS9EEmxOffreQ29cEEUbuGcw2bymODcsJpe2ICX2/p+ELdFf3 Fs+mhbc1TQcbi1eu2xyB9rxTQ1ezWTWfMXZcQz77woKJRTDoV46mAhue+dCja/XuJnVV nJCg== X-Gm-Message-State: AOJu0YwBj0qsrTBtfz0d2DzCCrNZGOgjsZewH/YzhXCRnWQZcJZAyxCb xBq2K6w/CsdpmoxvtPCbmh5DnsL4GiCc2T5UbiSQqnd/BFS9KzK5TjTdgnKV/lwcyhdKAb1QO/b x/jBeiAzTqvcj9znX/qCjxD19ABkO5ur0lj4= X-Received: by 2002:a17:90b:a4a:b0:268:d05c:2d7e with SMTP id gw10-20020a17090b0a4a00b00268d05c2d7emr7199799pjb.14.1695010438620; Sun, 17 Sep 2023 21:13:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1foMotPOeb/U6/yukF28+ks3ZQRkPSCrKuGwYeHbXeH4thsw0w9Gpz7n9powcJl9wMU41Zg== X-Received: by 2002:a17:90b:a4a:b0:268:d05c:2d7e with SMTP id gw10-20020a17090b0a4a00b00268d05c2d7emr7199783pjb.14.1695010438337; Sun, 17 Sep 2023 21:13:58 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id s8-20020a17090a074800b00262eb0d141esm6923176pje.28.2023.09.17.21.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Sep 2023 21:13:57 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 14:13:50 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v2 13/35] ACPI: Rename acpi_scan_device_not_present() to be about enumeration To: James Morse , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev Cc: x86@kernel.org, Salil Mehta , Russell King , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-14-james.morse@arm.com> From: Gavin Shan In-Reply-To: <20230913163823.7880-14-james.morse@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230917_211408_458542_62B3BF5D X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/14/23 02:38, James Morse wrote: > acpi_scan_device_not_present() is called when a device in the > hierarchy is not available for enumeration. Historically enumeration > was only based on whether the device was present. > > To add support for only enumerating devices that are both present > and enabled, this helper should be renamed. It was only ever about > enumeration, rename it acpi_scan_device_not_enumerated(). > > No change in behaviour is intended. > > Signed-off-by: James Morse > --- > drivers/acpi/scan.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index ed01e19514ef..17ab875a7d4e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -289,10 +289,10 @@ static int acpi_scan_hot_remove(struct acpi_device *device) > return 0; > } > > -static int acpi_scan_device_not_present(struct acpi_device *adev) > +static int acpi_scan_device_not_enumerated(struct acpi_device *adev) > { > if (!acpi_device_enumerated(adev)) { > - dev_warn(&adev->dev, "Still not present\n"); > + dev_warn(&adev->dev, "Still not enumerated\n"); > return -EALREADY; > } > acpi_bus_trim(adev); > @@ -327,7 +327,7 @@ static int acpi_scan_device_check(struct acpi_device *adev) > error = -ENODEV; > } > } else { > - error = acpi_scan_device_not_present(adev); > + error = acpi_scan_device_not_enumerated(adev); > } > return error; > } > @@ -339,7 +339,7 @@ static int acpi_scan_bus_check(struct acpi_device *adev, void *not_used) > > acpi_bus_get_status(adev); > if (!acpi_device_is_present(adev)) { > - acpi_scan_device_not_present(adev); > + acpi_scan_device_not_enumerated(adev); > return 0; > } > if (handler && handler->hotplug.scan_dependent) Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel