From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76A7ECEACFB for ; Sat, 15 Nov 2025 00:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oM8CzPnGZcFfmoEB2jEcC8IhjxOo1DHDvAoRw6P4Wnw=; b=lRz6SSGPbf8s0gYmIXuNvul14u xd08sT69w3g8mYmW7Gx8AK0TCOAB67kQNeHI3T5qpPsFpGSyOH0Y8KF+r1R3kPuhDb6y0b/47MtHr t1hCdOhdLx/QgxFOY/Ukkje6HEugNW00mlZH5C+0AnbT3/UfUGgsPzJd8NQNfU+rbJlUCg2fe5u31 eJUzJ6vrPlBfkpJKR8AWLNeYbahKZPxZyqZQdLpTvH11wj1bwpwNxzUtEzOVmHKPU0GVJgU/SveGi gOBgyLV/NHscv0kAKaL2ui37gknlK7RQMh2aSdOIZWGPmo3QkdVnA4m5TbPPXnZ/opiFB5boUrl52 B3SLngkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vK41k-0000000DGmt-2S49; Sat, 15 Nov 2025 00:20:28 +0000 Received: from mleia.com ([178.79.152.223] helo=mail.mleia.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vK41g-0000000DGmY-38g1 for linux-arm-kernel@lists.infradead.org; Sat, 15 Nov 2025 00:20:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mleia.com; s=mail; t=1763166023; bh=GnY5W3eBSsTLkWB1SAWq/c5XiUGtQktCS4pe28VyhFk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jfvANMVm1W3hmXhUGr9bG0CN3hVWfNeSoSiuc6vjCaEnlbp0Aieg1A/CjlbVNsom4 5JLD2IQu0BaRlvUbg4/G8JUu5CLFASloMy4KW1SuBeYlbEXdtVFH+tmGKrgHzrpCnI 0/XseHZklgN0Ot1PfNQg2PSYTe7TWYuJPho/V/Ntl99NYxOrkBqkAx3IboNLOlwpZo XuAVJR/PGeZdV5MrVTkLEerogKq4hl1/9wBWOz/QnlpYtAE/pNeBvBLS5BGKTK3kit YwKLnq5WEgNX3whDsToHKa7jzkEl8YW1ExwOtgC+VI3gE3kbnpiFPZHlYZrNcT50sz plahVHEy22yaA== Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 2DC6A3E16D7; Sat, 15 Nov 2025 00:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mleia.com; s=mail; t=1763166023; bh=GnY5W3eBSsTLkWB1SAWq/c5XiUGtQktCS4pe28VyhFk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jfvANMVm1W3hmXhUGr9bG0CN3hVWfNeSoSiuc6vjCaEnlbp0Aieg1A/CjlbVNsom4 5JLD2IQu0BaRlvUbg4/G8JUu5CLFASloMy4KW1SuBeYlbEXdtVFH+tmGKrgHzrpCnI 0/XseHZklgN0Ot1PfNQg2PSYTe7TWYuJPho/V/Ntl99NYxOrkBqkAx3IboNLOlwpZo XuAVJR/PGeZdV5MrVTkLEerogKq4hl1/9wBWOz/QnlpYtAE/pNeBvBLS5BGKTK3kit YwKLnq5WEgNX3whDsToHKa7jzkEl8YW1ExwOtgC+VI3gE3kbnpiFPZHlYZrNcT50sz plahVHEy22yaA== Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi [91.159.24.186]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mleia.com (Postfix) with ESMTPSA id 998FB3E101C; Sat, 15 Nov 2025 00:20:22 +0000 (UTC) Message-ID: Date: Sat, 15 Nov 2025 02:20:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes To: Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Piotr Wojtaszczyk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/LPC32XX SOC SUPPORT" , open list Cc: imx@lists.linux.dev References: <20251114174712.1206027-1-Frank.Li@nxp.com> From: Vladimir Zapolskiy In-Reply-To: <20251114174712.1206027-1-Frank.Li@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20251115_002023_206644_D32BDC99 X-CRM114-Status: GOOD ( 20.02 ) /bin/ln: failed to access 'reaver_cache/texts/20251115_002023_206644_D32BDC99': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251115_002023_206644_D32BDC99 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank. On 11/14/25 19:47, Frank Li wrote: > Remove usb bus and elevate all children nodes because usb bus is not > existed and only group usb devices logically. > > Update register address and related full node name. > > Fix below CHECK_DTBS warnings: > arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: usb (simple-bus): $nodename:0: 'usb' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' > from schema $id: http://devicetree.org/schemas/simple-bus.yaml# > > Signed-off-by: Frank Li > --- > change in v2 > - elevate usb children node > - fab leave unchange now utils finish discussion. > --- > arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 77 ++++++++++++-------------- > 1 file changed, 35 insertions(+), 42 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi > index 4dff0d7694322..d6243adbc05bc 100644 > --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi > +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi > @@ -86,51 +86,44 @@ dma: dma-controller@31000000 { > #dma-cells = <2>; > }; > > - usb { > - #address-cells = <1>; > - #size-cells = <1>; > - compatible = "simple-bus"; > - ranges = <0x0 0x31020000 0x00001000>; > - > - /* > - * Enable either ohci or usbd (gadget)! > - */ > - ohci: usb@0 { > - compatible = "nxp,ohci-nxp", "usb-ohci"; > - reg = <0x0 0x300>; > - interrupt-parent = <&sic1>; > - interrupts = <27 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&usbclk LPC32XX_USB_CLK_HOST>; > - status = "disabled"; > - }; > + /* > + * Enable either ohci or usbd (gadget)! > + */ > + ohci: usb@31020000 { > + compatible = "nxp,ohci-nxp", "usb-ohci"; > + reg = <0x31020000 0x300>; > + interrupt-parent = <&sic1>; > + interrupts = <27 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&usbclk LPC32XX_USB_CLK_HOST>; > + status = "disabled"; > + }; > > - usbd: usbd@0 { > - compatible = "nxp,lpc3220-udc"; > - reg = <0x0 0x300>; > - interrupt-parent = <&sic1>; > - interrupts = <29 IRQ_TYPE_LEVEL_HIGH>, > - <30 IRQ_TYPE_LEVEL_HIGH>, > - <28 IRQ_TYPE_LEVEL_HIGH>, > - <26 IRQ_TYPE_LEVEL_LOW>; > - clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>; > - status = "disabled"; > - }; > + usbd: usbd@31020000 { > + compatible = "nxp,lpc3220-udc"; > + reg = <0x31020000 0x300>; > + interrupt-parent = <&sic1>; > + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>, > + <30 IRQ_TYPE_LEVEL_HIGH>, > + <28 IRQ_TYPE_LEVEL_HIGH>, > + <26 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>; > + status = "disabled"; > + }; > > - i2cusb: i2c@300 { > - compatible = "nxp,pnx-i2c"; > - reg = <0x300 0x100>; > - interrupt-parent = <&sic1>; > - interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&usbclk LPC32XX_USB_CLK_I2C>; > - #address-cells = <1>; > - #size-cells = <0>; > - }; > + i2cusb: i2c@31020300 { > + compatible = "nxp,pnx-i2c"; > + reg = <0x31020300 0x100>; > + interrupt-parent = <&sic1>; > + interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&usbclk LPC32XX_USB_CLK_I2C>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > > - usbclk: clock-controller@f00 { > - compatible = "nxp,lpc3220-usb-clk"; > - reg = <0xf00 0x100>; > - #clock-cells = <1>; > - }; > + usbclk: clock-controller@31020f00 { > + compatible = "nxp,lpc3220-usb-clk"; > + reg = <0x31020f00 0x100>; > + #clock-cells = <1>; > }; > > clcd: clcd@31040000 { As for me the change looks good, but I need some time to do a regression testing, I'll do it over the weekend. Thank you for the contribution! -- Best wishes, Vladimir