From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10910CA90AF for ; Wed, 13 May 2020 11:26:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB4FB2176D for ; Wed, 13 May 2020 11:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KSvE+xrA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB4FB2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yki6heqMLFwkR3xcr0Ht1IZInk0mR2AtJ9DPRc7/8U0=; b=KSvE+xrA9i7bTCBuRDWmax2Yt AHDpZNlmMhjnBrJDI3qE3h1fAuYdYCQw8hr9Q8viC9J92T+1G3dqycqNWI9HC3MPFXao8UanM/86j PsaYWXBk/K/bLw+DuGdukOQ8yVBnQMtSjix9cPVLlH/wDidnL+0rLC6KF26nWOIJGpWUA9YLmydjs Bz59JeBzADs8zT+779PLgxHkE3DnW34krYFDceLbJunu99u9dwyw72qmH8XDaU31P5/19iipeM40y oWgI1BDF2/rP5ScTyzjoVb1W90JAXGPCzHYOYKunymslGCEUdsv39gCeGzwIGLj3DfaZ6yP/IaxqG IgLcBdruw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYpWc-0006wp-Dd; Wed, 13 May 2020 11:26:10 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYpWY-0006vY-FL; Wed, 13 May 2020 11:26:08 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 957CDAF36; Wed, 13 May 2020 11:26:05 +0000 (UTC) Message-ID: Subject: Re: [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk From: Nicolas Saenz Julienne To: Lorenzo Pieralisi Date: Wed, 13 May 2020 13:26:00 +0200 In-Reply-To: <20200513111717.GA32365@e121166-lin.cambridge.arm.com> References: <20200505161318.26200-1-nsaenzjulienne@suse.de> <20200513111717.GA32365@e121166-lin.cambridge.arm.com> User-Agent: Evolution 3.36.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_042606_801933_4BD0E976 X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , f.fainelli@gmail.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tim.gover@raspberrypi.org, helgaas@kernel.org, wahrenst@gmx.net, linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3085363444533949279==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3085363444533949279== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-AhWRdoINwjRGD4bp+/gD" --=-AhWRdoINwjRGD4bp+/gD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2020-05-13 at 12:17 +0100, Lorenzo Pieralisi wrote: > On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote: > > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either b= e > > loaded directly from an EEPROM or, if not present, by the SoC's > > co-processor, VideoCore. This series adds support for the later. > >=20 > > Note that there are a set of constraints we have to consider: > > - We need to make sure the VideoCore firmware interface is up and > > running before running the VL805 firmware load call. > >=20 > > - There is no way to discern RPi4's VL805 chip from other platforms', > > so we need the firmware load to happen *before* running > > quirk_usb_handoff_xhci(). Failure to do so results in an unwarranted > > 5 second wait while the fixup code polls xHC's non-existing state. > >=20 > > By Florian's suggestion I've been spending some time exploring the devi= ce > > link[1] API in order to see if that could save us from explicitly creat= ing > > probe dependencies between pcie-brcmstb and firmware/raspberrypi (patch= #3). > > Technically these dependencies could be inferred from DT. It turns out > > Saravana > > Kannan has been looking at this already. A new boot mechanism, activate= d > > with > > fw_devlink=3Don takes care of the device probe ordering on devices with > > consumer/supplier relationships. For now this relationship is created b= ased > > on > > the usage of generic DT properties, but has no support for vendor-speci= fc DT > > properties, which we'd be forced to use in order to create a relationsh= ip > > between our two devices since our setup is highly non generic. There wi= ll > > probably be at some point support for such properties, and we will then= be > > able > > to revisit some of this code. > >=20 > > All this is based on the work by Tim Gover in RPi's downstream > > kernel[2]. > >=20 > > [1] https://www.kernel.org/doc/html/v4.13/driver-api/device_link.html > > [2]=20 > >=20 https://github.com/raspberrypi/linux/commit/9935b4c7e360b4494b4cb6e3ce79723= 8a1ab78bd > >=20 > > --- > >=20 > > Changes since v7: > > - Address Stefan's comments > >=20 > > Changes since v6: > > - Make rpi_firmware_init_vl805() more robust > > - Rewrite comments and patch descriptions to be more accessible to non= RPi > > fluent people > > - Removed Florian's Reviewed-by in patch #2 as function changed > > substantially > > - Tested with/witout u-boot > >=20 > > Changes since v5: > > - Fix issues reported by Kbuild test robot > >=20 > > Changes since v4: > > - Addressed Sergei's comments > > - Fix potential warning in patch #2 > >=20 > > Changes since v3: > > - Addressed Greg's comments > >=20 > > There was no v2, my bad. > >=20 > > Changes since v1: > > - Addressed Floarians comments > >=20 > > Nicolas Saenz Julienne (4): > > soc: bcm2835: Add notify xHCI reset property > > firmware: raspberrypi: Introduce vl805 init routine > > PCI: brcmstb: Wait for Raspberry Pi's firmware when present > > USB: pci-quirks: Add Raspberry Pi 4 quirk > >=20 > > drivers/firmware/Kconfig | 3 +- > > drivers/firmware/raspberrypi.c | 61 ++++++++++++++++++++++ > > drivers/pci/controller/pcie-brcmstb.c | 17 ++++++ > > drivers/usb/host/pci-quirks.c | 16 ++++++ > > include/soc/bcm2835/raspberrypi-firmware.h | 9 +++- > > 5 files changed, 104 insertions(+), 2 deletions(-) >=20 > Hi Nicolas, >=20 > should I queue this series via the PCI tree ? Just let me know, most of > the changes are not in the PCI tree, asking in order to > minimize/simplify conflicts handling if possible. Yes, I agree, it's better if you take the whole thing. Thanks, Nicolas --=-AhWRdoINwjRGD4bp+/gD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl672UkACgkQlfZmHno8 x/6lzQgAtDUjnjJd0Zuqd4pj4VT1XSzzQNMButVbZ5d+gcCtJR68q5lNzhejWtjL hc8ncq03srEPDueXQiuwqK/kMxG9emt5s65ZAW7cmlzNeq300bdyQLbJKRApXdPO ACtx3+KFOvLfOmeFzTD94DZL8yrfsTs3aEDuOgJeUfTheiUyySR3W+tWLUsJ9Fwo aT3NaDPv/7raoV3TOJ/+lfXHZ3Mu2fbvawVjDaea0ksVLCgHP+0RKVljzIty9HUJ TCuM5xm6H817e4x2d41HQliJeHTxAuA5ZUKHrYmtrJ3Z76Fs+XrwesCvM+vha9VS 5zKyHpHrTNN0ORi89ZN5EtKhUNrpvg== =XtBQ -----END PGP SIGNATURE----- --=-AhWRdoINwjRGD4bp+/gD-- --===============3085363444533949279== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3085363444533949279==--