From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7470AC38A02 for ; Fri, 28 Oct 2022 16:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2GLIUj8NgsuAw+tEU2Mk9bHQGN+wVbwP+j1lgiS7EEs=; b=f8iGqv4mJNK6So R7sXvaPNAd0KHgY8N/LPvxU0MbSaPY4HNkBJsML76SLMFpqi5qD/iemDSdS6sRSB8/A/DYYUuSjWG F5fZIWrQkgRvrHluEOr8QtsiYBuxl1gSlle+KYXzWyOO3aOxFDtAGbGFJR6tJ3lfSeWMdprFAWlyU z4E0aXH7nfvcpi5jH6Xl/qcyYvI3ngT1xqzgzRJmarkgbTMdfgiUFXWrpxJe1loa3yiOYn2/9L+M7 42fUNwiKMFDJARem/xB6LRT68+/l4WpE6oYTVm5VDXkOjXaUlU12rREraLJY3OEC+5unTarEXZiat lWVtR5lnXIqbBkSAFYfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooRmc-000jWc-FU; Fri, 28 Oct 2022 16:00:34 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooRl8-000ihj-1T for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 15:59:03 +0000 Received: by mail-oi1-x229.google.com with SMTP id u132so6639150oib.0 for ; Fri, 28 Oct 2022 08:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=kGV5CRuXO/AflfNqwOyb3q124XfnO4+Le7SUJ2VJU3I=; b=YEtveQ5geZPkTIxyIW1RGzgwGnwFThDcL8Wv8vKpWOWescIp3AKZvU140u86bHSctS /WHC/hmjpHBos5Hsg0sNydLxJm4tylUPI8AzWzyWluY1vVuXG/7OjgnTWV2zDOBQ2tgh 2YIIErFMOMyFYdwhQ285czT3VOJpUm8T9YJgxEQvLj1Rd4ZX/bFyImyiSJ0Mc/1okjkI JcInEEarNY+WFTfmOAsL5smiQld4j8i/XdWjxxwznnvmmqB6CYjLjXOT73p7CvI2Dnwr CTHW1+tadB0YLfZ02AD8Tk0QlPInG43fpuM7w8eLUkFLnrVfJ3NmH2HDECrKJlDIDVuA oNlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kGV5CRuXO/AflfNqwOyb3q124XfnO4+Le7SUJ2VJU3I=; b=SpStG0PTDctq8q0iUQA5WAYzIKo5kAEtjNwwBeF86G8WIFRWuIQQSLW+o/y65TsshD sjELKF6O4A59B4BHs0HZqit42dbsWUG1JdF4iQBj1Hhcg9+1pO9Y9ESqYQzPNekEnKE8 5qfeVzkndwzz2NHKBjVyNkPIxkkcR8PCuMlFeCaY8xOXC6k/HvSLHqpMGTbsXN5WxjBQ AA+6FZKYnEf0qREBxEvEXkYRR2JsXQRi6VCqBw14tubYR2gscGsmvcvx8FeqBiwfp4af KeighBhT7fZoA0WnFZ6aJimjZ9vhDPRME74FmcIZ5ZyTI0xd/qNktbr6Wr5fPI69hdgt G3GQ== X-Gm-Message-State: ACrzQf1i1fle9GTeBA2JovIb9au4cX+gThk7d/QrwLNViO/r41oycnAH VuqTvSsUnG/P+SjmJgEZqRs= X-Google-Smtp-Source: AMsMyM4SI17djKyPfTO294g8vpTQAc+lvUiYSSoWh5QXmXPQBgV9ybiftpT43M5gbq2CZaSK3grXfg== X-Received: by 2002:a05:6808:2083:b0:355:2c71:7e58 with SMTP id s3-20020a056808208300b003552c717e58mr8578008oiw.168.1666972740889; Fri, 28 Oct 2022 08:59:00 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l23-20020a544517000000b00359ba124b07sm1626854oil.36.2022.10.28.08.58.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 08:59:00 -0700 (PDT) Message-ID: Date: Fri, 28 Oct 2022 08:58:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, Daniel Lezcano , linux-hwmon@vger.kernel.org References: <20221028140833.280091-1-cristian.marussi@arm.com> <20221028140833.280091-7-cristian.marussi@arm.com> From: Guenter Roeck Subject: Re: [PATCH 7/8] hwmon: (scmi) Register explicitly with Thermal Framework In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_085902_238291_F9F5F1E0 X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/28/22 08:35, Cristian Marussi wrote: [ ... ] >>> + /* >>> + * Try to register a temperature sensor with the Thermal Framework: >>> + * skip sensors not defined as part of any thermal zone (-ENODEV) but >>> + * report any other errors related to misconfigured zones/sensors. >>> + */ >>> + tzd = devm_thermal_of_zone_register(dev, th_sensor->info->id, th_sensor, >>> + &scmi_hwmon_thermal_ops); >>> + if (IS_ERR(tzd)) { >>> + devm_kfree(dev, th_sensor); >>> + >>> + if (PTR_ERR(tzd) != -ENODEV) >>> + return PTR_ERR(tzd); >>> + >>> + dev_info(dev, "Sensor '%s' not attached to any thermal zone.\n", >>> + sensor->name); >> >> There were complaints about this message as it is noisy. If you send >> another version, please drop it unless attaching each sensor to a thermal >> zone is strongly expected. If you don't send another version, I'll drop it >> while applying. >> > > Ok fine for me. I am waiting to have some feedback from Sudeep too, but > I do not have plan for another version as of now. > > As a side note, though, I understand the 'noisiness' argument, but, > sincerely this same message in the original HWMON code was the only > reason why I spotted that something was wrong with the SCMI/HWMON > interactions and discovered the indexes/ids mismatch...if not for > that it would have gone un-noticed that a perfectly configured > ThermalZone/Sensor was not working properly... > (un-noticed at least until something would have been burnt to fire > in my house .. joking :P) > Good point. Did you ever check the returned error code ? Maybe we could use it to distinguish "it is not attached to a thermal zone because it is not associated with one" from "attaching to a thermal zone failed because its configuration is bad/incomplete". Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel