Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: muhammadabdul.wahab@centralesupelec.fr (Muhammad Abdul WAHAB)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Adding missing features of Coresight PTM components
Date: Wed, 5 Oct 2016 12:23:18 +0200	[thread overview]
Message-ID: <e4115ffb-5fcb-4322-7270-b0ca87065880@centralesupelec.fr> (raw)
In-Reply-To: <CANLsYkybp0Lm-WStT=__yyug1Z9hFG7dgCp8E=iL5_x9C1vv-w@mail.gmail.com>

Hi Mathieu,

> The rule of thumb when writing a patch description is to specify "why"
> rather than "what" you are doing.  The above describe the why alright
> and should be kept.  Everything below until your SOB describe what you
> are doing and should be removed.

I modified the patch according to your remarks and will submit it.

 > There is indeed an indentation problem here but it can't be fixed in
 > this patch.  Please do another patch for this.

I created another patch for it.

 > The sysFS mode users can do what they want, including configurations
 > not supported by the HW.  There are so many rules and exception that
 > adding a check for every one of they doesn't scale up.  I suggest to
 > remove the above check.

This check was removed. The return stack feature is not available in ETM 
and the corresponding bit is reserved and should be zero. That's why an 
additional check was made.

 > You patch doesn't apply on my tree.  Please use "git format-patch" for
 > your next submission.  Last but not least the email address in the
 > "from:" part of the submission doesn't match the one in the SOB - they
 > have to be similar.

All the above suggestions were made and will be submitted in the 2nd 
version of the patch.

Thank you,
M.Abdul WAHAB

  reply	other threads:[~2016-10-05 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <583ccfa4-ee4e-561a-5480-d0f243194ee3@supelec.fr>
2016-10-04 16:26 ` [PATCH] Adding missing features of Coresight PTM components Mathieu Poirier
2016-10-05 10:23   ` Muhammad Abdul WAHAB [this message]
2016-09-29 10:27 Muhammad Abdul WAHAB

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4115ffb-5fcb-4322-7270-b0ca87065880@centralesupelec.fr \
    --to=muhammadabdul.wahab@centralesupelec.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox