From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCB6FEA824 for ; Wed, 25 Mar 2026 10:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CdQekOG2Kq3qRFabl7VSXT8Km9b04xHc5QXPgAhmcYI=; b=I9jmJEcn7j71WQcOMFVuDc4/Sa J4FtVs44uDzQZ1s3wZ41viYe0Dc69YolZ5hPdyq+6PFUyWoL9nKQ8FOztWzfoAhihOlTrdtAu+iaB Vzuprsn3dwMs7e29F21B0Z7WXn7/eF4r9JCc2rntqT65fs4O8S1uJabnFt/o7fjkMHPpwYtqjezp2 T7XAOqWyDzieL+4BQI/Iwi4BMhM1Rc4FSI+VBkqiYV1gsQuU6L6DiMkVYkDda/AZCfARTf1sva7PV P0TZ/ZIP/2AcRcUcWHZAVlxx4I78ji8oguiVPm1UGosbJEjn3xZimAXtjNsO7lpXGD0lQ7YNFHhBh +ltPz4hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5L6b-000000036Vm-1OL6; Wed, 25 Mar 2026 10:04:53 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5L6Y-000000036VI-45Dl; Wed, 25 Mar 2026 10:04:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2A1CA42B3E; Wed, 25 Mar 2026 10:04:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99004C4CEF7; Wed, 25 Mar 2026 10:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774433090; bh=mWCjyaxKu+x+LzWRgLuhujGHLbxlc3MmkD51VDioSIg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TNJpNZcIC+RvxqTV15Sf9sni6H4IWM0T+i3wt5MLiMfUHkfT34q1CwGBusWH1kE3/ dnN4SNi4+AvIgkYt4oSgjYjdYCeFsI6VrGO5PEXoPnnlOc1fbEncDzZgNiPcjbFygA /ZtI085ad/dYBptuY3ARMNcg2KQletfHZ9gpOpculjQh5nP+N4E8Zr8dD6BGl/fyUR zafOK0794Im+0DBGvQliZGSK7JRyRUDI4tpM02JeU+gvdZP2ymlEdlBc6wgAXyOd0B aK/i0OiLd75T1xW0NaawDtJsRy0EK96sVVOg5mJbXC0sIeQ13cP6pms6xqicRCBsL8 W+CvXhvSGQluw== Message-ID: Date: Wed, 25 Mar 2026 11:04:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/21] misc: open-dice: replace deprecated mmap hook with mmap_prepare Content-Language: en-US To: "Lorenzo Stoakes (Oracle)" , Andrew Morton Cc: Jonathan Corbet , Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Bodo Stroesser , "Martin K . Petersen" , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-staging@lists.linux.dev, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts References: <5a83ab00195dc8d0609fa6cc525493010ac4ead1.1774045440.git.ljs@kernel.org> From: "Vlastimil Babka (SUSE)" In-Reply-To: <5a83ab00195dc8d0609fa6cc525493010ac4ead1.1774045440.git.ljs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260325_030451_080216_8CEEA88C X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/20/26 23:39, Lorenzo Stoakes (Oracle) wrote: > The f_op->mmap interface is deprecated, so update driver to use its > successor, mmap_prepare. > > The driver previously used vm_iomap_memory(), so this change replaces it > with its mmap_prepare equivalent, mmap_action_simple_ioremap(). > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Lorenzo Stoakes (Oracle) Acked-by: Vlastimil Babka (SUSE) > --- > drivers/misc/open-dice.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/open-dice.c b/drivers/misc/open-dice.c > index 24c29e0f00ef..45060fb4ea27 100644 > --- a/drivers/misc/open-dice.c > +++ b/drivers/misc/open-dice.c > @@ -86,29 +86,32 @@ static ssize_t open_dice_write(struct file *filp, const char __user *ptr, > /* > * Creates a mapping of the reserved memory region in user address space. > */ > -static int open_dice_mmap(struct file *filp, struct vm_area_struct *vma) > +static int open_dice_mmap_prepare(struct vm_area_desc *desc) > { > + struct file *filp = desc->file; > struct open_dice_drvdata *drvdata = to_open_dice_drvdata(filp); > > - if (vma->vm_flags & VM_MAYSHARE) { > + if (vma_desc_test(desc, VMA_MAYSHARE_BIT)) { > /* Do not allow userspace to modify the underlying data. */ > - if (vma->vm_flags & VM_WRITE) > + if (vma_desc_test(desc, VMA_WRITE_BIT)) > return -EPERM; > /* Ensure userspace cannot acquire VM_WRITE later. */ > - vm_flags_clear(vma, VM_MAYWRITE); > + vma_desc_clear_flags(desc, VMA_MAYWRITE_BIT); > } > > /* Create write-combine mapping so all clients observe a wipe. */ > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > - vm_flags_set(vma, VM_DONTCOPY | VM_DONTDUMP); > - return vm_iomap_memory(vma, drvdata->rmem->base, drvdata->rmem->size); > + desc->page_prot = pgprot_writecombine(desc->page_prot); > + vma_desc_set_flags(desc, VMA_DONTCOPY_BIT, VMA_DONTDUMP_BIT); > + mmap_action_simple_ioremap(desc, drvdata->rmem->base, > + drvdata->rmem->size); > + return 0; > } > > static const struct file_operations open_dice_fops = { > .owner = THIS_MODULE, > .read = open_dice_read, > .write = open_dice_write, > - .mmap = open_dice_mmap, > + .mmap_prepare = open_dice_mmap_prepare, > }; > > static int __init open_dice_probe(struct platform_device *pdev)