From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Amelie Delaunay <amelie.delaunay@st.com>,
Etienne Carriere <etienne.carriere@st.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
Date: Tue, 2 Mar 2021 18:03:23 +0100 [thread overview]
Message-ID: <e44809f1-63a6-8c8b-a05f-52516fb2141f@linaro.org> (raw)
In-Reply-To: <YD5olWDZ50sLVn7w@vkoul-mobl>
On 02/03/2021 17:32, Vinod Koul wrote:
> On 24-02-21, 15:42, Daniel Lezcano wrote:
>> HZ unit conversion macros are available in units.h, use them and
>> remove the duplicate definition.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
>> index a54317e96c41..02dd12bb4692 100644
>> --- a/drivers/phy/st/phy-stm32-usbphyc.c
>> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
>> @@ -14,6 +14,7 @@
>> #include <linux/of_platform.h>
>> #include <linux/phy/phy.h>
>> #include <linux/reset.h>
>> +#include <linux/units.h>
>>
>> #define STM32_USBPHYC_PLL 0x0
>> #define STM32_USBPHYC_MISC 0x8
>> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
>> #define PLL_FVCO_MHZ 2880
>> #define PLL_INFF_MIN_RATE_HZ 19200000
>> #define PLL_INFF_MAX_RATE_HZ 38400000
>> -#define HZ_PER_MHZ 1000000L
>
> I dont see this in units.h, can you send this once it is merged upstream
Actually, it is the first patch of the series.
I asked Rafael if he can merge the entire series.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-03 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210224144222.23762-1-daniel.lezcano@linaro.org>
2021-02-24 14:42 ` [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Daniel Lezcano
2021-03-02 16:32 ` Vinod Koul
2021-03-02 17:03 ` Daniel Lezcano [this message]
2021-03-03 5:40 ` Vinod Koul
2021-03-03 6:09 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e44809f1-63a6-8c8b-a05f-52516fb2141f@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chunfeng.yun@mediatek.com \
--cc=etienne.carriere@st.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=rafael@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox