From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jonathan Cameron" <jic23@kernel.org>
Cc: Hartley Sweeten <hsweeten@visionengravers.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 08/49] iio: adc: ep93xx: Convert to platform remove callback returning void
Date: Tue, 19 Sep 2023 19:54:14 +0200 [thread overview]
Message-ID: <e45396906300c06ca8f9200843811ad47144dc55.camel@gmail.com> (raw)
In-Reply-To: <20230919174931.1417681-9-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On Tue, 2023-09-19 at 19:48 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/iio/adc/ep93xx_adc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
--
Alexander Sverdlin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-19 17:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230919174931.1417681-1-u.kleine-koenig@pengutronix.de>
2023-09-19 17:48 ` [PATCH 02/49] iio: adc: ab8500-gpadc: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 03/49] iio: adc: at91-sama5d2: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 04/49] iio: adc: at91: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 06/49] iio: adc: bcm_iproc: " Uwe Kleine-König
2023-09-19 18:54 ` Florian Fainelli
2023-09-19 17:48 ` [PATCH 08/49] iio: adc: ep93xx: " Uwe Kleine-König
2023-09-19 17:54 ` Alexander Sverdlin [this message]
2023-09-19 17:48 ` [PATCH 09/49] iio: adc: exynos: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 10/49] iio: adc: fsl-imx25-gcq: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 12/49] iio: adc: imx8qxp: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 13/49] iio: adc: imx93: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 14/49] iio: adc: meson_saradc: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 16/49] iio: adc: mxs-lradc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 20/49] iio: adc: stm32-adc-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 21/49] iio: adc: stm32-adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 22/49] iio: adc: stm32-dfsdm-adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 23/49] iio: adc: stm32-dfsdm-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 24/49] iio: adc: sun4i-gpadc-iio: " Uwe Kleine-König
2023-09-19 17:58 ` Jernej Škrabec
2023-09-19 17:49 ` [PATCH 30/49] iio: dac: lpc18xx_dac: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 31/49] iio: dac: stm32-dac-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 32/49] iio: dac: stm32-dac: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 49/49] iio: trigger: stm32-timer: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e45396906300c06ca8f9200843811ad47144dc55.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox