From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Landen Chao <landen.chao@mediatek.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Sean Wang <sean.wang@mediatek.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: dsa: mt7530: Add some return-value checks
Date: Wed, 16 Sep 2020 15:10:02 -0500 [thread overview]
Message-ID: <e46ec744-ec6a-e53a-03e8-1c75c910682f@embeddedor.com> (raw)
In-Reply-To: <20200916195017.34057-1-alex.dewar90@gmail.com>
On 9/16/20 14:50, Alex Dewar wrote:
[..]
>
> drivers/net/dsa/mt7530.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
[..]
>
> /* Enable Mediatek header mode on the cpu port */
> mt7530_write(priv, MT7530_PVC_P(port),
> @@ -2275,7 +2279,7 @@ mt7531_cpu_port_config(struct dsa_switch *ds, int port)
> {
> struct mt7530_priv *priv = ds->priv;
> phy_interface_t interface;
> - int speed;
> + int ret, speed;
Don't do this. Instead, declare each variable on its own line. In this case,
speed before ret.
Thanks
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 19:50 [PATCH] net: dsa: mt7530: Add some return-value checks Alex Dewar
2020-09-16 20:10 ` Gustavo A. R. Silva [this message]
2020-09-16 21:22 ` Alex Dewar
2020-09-16 21:23 ` Alex Dewar
2020-09-17 7:32 ` Landen Chao
2020-09-19 19:28 ` [PATCH v2] " Alex Dewar
2020-09-24 12:13 ` Landen Chao
2020-09-24 13:11 ` Alex Dewar
2020-09-24 13:25 ` Landen Chao
2020-09-24 14:05 ` [PATCH v3] " Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46ec744-ec6a-e53a-03e8-1c75c910682f@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=alex.dewar90@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=landen.chao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).