Re: [PATCH v5 0/5] media: imx-jpeg: Fix some motion-jpeg decoding

[Nicolas Dufresne <nicolas@ndufresne.ca>]

Hi Ming,

Le vendredi 18 avril 2025 à 15:08 +0800, ming.qian@oss.nxp.com a écrit :
> From: Ming Qian <ming.qian@oss.nxp.com>
> 
> To support decoding motion-jpeg without DHT, driver will try to decode a
> pattern jpeg before actual jpeg frame by use of linked descriptors
> (This is called "repeat mode"), then the DHT in the pattern jpeg can be
> used for decoding the motion-jpeg.
> 
> But there is some hardware limitation in the repeat mode, that may cause
> corruption or decoding timeout.
> 
> Try to make workaround for these limitation in this patchset.

You should maintain a changelog in your cover letter, this way we know
what has been fixed. You may be interested with "b4" tool, with "b4
prep" and "b4 send" the tool will assist you in doing the right thing.

More details on what is missing:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#respond-to-review-comments

Meanwhile, just reply to this message with the missing information.

regards,
Nicolas

> 
> Ming Qian (5):
>   media: imx-jpeg: Move mxc_jpeg_free_slot_data() ahead
>   media: imx-jpeg: Reset slot data pointers when free data
>   media: imx-jpeg: Cleanup after an allocation error
>   media: imx-jpeg: Change the pattern size to 128x64
>   media: imx-jpeg: Check decoding is ongoing for motion-jpeg
> 
>  .../media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h |   1 +
>  .../media/platform/nxp/imx-jpeg/mxc-jpeg.c    | 120 +++++++++++++-----
>  .../media/platform/nxp/imx-jpeg/mxc-jpeg.h    |   5 +
>  3 files changed, 97 insertions(+), 29 deletions(-)