From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42924FF8867 for ; Wed, 29 Apr 2026 08:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Eyta59uN5vtO1/WZbOs1P3QwqPOOCC4TOg4kNoocO1Q=; b=Y2lLB2sfhfBOsa/wmLrxKVF1ja sxHeo7CMl6ocjY7Jydyea04MbNjfKW1eQeevfgvwfyPeDoAKyf1RVhU4lrpA5ivNPsNEJfOs16vWe VQkOo7DfPONf1HFQ/kXBiY6zzVn8yMWhtMPBAhhf5QDJ3Njk3vS4MHlDTcn2k2lyI0BdnFtX0JQ5/ MV4B1Vzy4r0/Plu6QPjPQAMZkio5UA7IvpAaO48X0uEWpxuHUxJeBaKGgjGULju/PLFm4RhJNORc+ MTfWPs9ro5UR8sBHn097LbqqtJQ3c4DKYUJ8nZ9w+hSxEYJ3UU+l4xFAMg3qb/xJ3n2Mkc8w7H/YA Dylum7rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHzxS-00000003Dni-2j5U; Wed, 29 Apr 2026 08:07:46 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHzxR-00000003DnK-0UQH for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2026 08:07:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4B05460018; Wed, 29 Apr 2026 08:07:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8744BC19425; Wed, 29 Apr 2026 08:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777450063; bh=BPtgstPyJu9Z1XyYiv+Qqirlz2ojBbfdDJaNCno6c0Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qNjpzERFgA7GRrt3yoEzQ93KlfHO4r4qXsOOf6AFpc1HP7dYlsen6xWW+g6ViIsV2 BfC2cKTxEWNWm/DdyUJuoNAaglqHUG5gR6MCh+q1TscaCrlZRA5t2APQ6XbSCs2fGS lSUzjRW24WJ1bZJf4trJNpKRCpkSyjrjdBzqjFy9dLIGYQlALweX7nFtP1phi6FhKD RcoBzMz/Zugrf+4cKAzBPRK4NirMen2MaV8ay8GZhtdPS+ivdE3BsoKqwmYdl0wazA 2YQrgkHQWa+IbDp/2n73SAqVMsD1RFEVV5xWs2kB8EoYd77NIbYSw32MNDlZQslPGZ 2ZfiK1BOS3umw== Message-ID: Date: Wed, 29 Apr 2026 10:07:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] p54spi: convert to devicetree To: Arnd Bergmann Cc: Arnd Bergmann , Aaro Koskinen , Andreas Kemnade , Bartosz Golaszewski , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Felipe Balbi , Jakub Kicinski , Johannes Berg , Kevin Hilman , Krzysztof Kozlowski , Linus Walleij , Paolo Abeni , Rob Herring , Roger Quadros , Tony Lindgren , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Christian Lamparter References: <20260427142355.2532714-1-arnd@kernel.org> <20260427142355.2532714-4-arnd@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260427142355.2532714-4-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/04/2026 16:23, Arnd Bergmann wrote: > > - ret = gpio_request(p54spi_gpio_power, "p54spi power"); > - if (ret < 0) { > - dev_err(&priv->spi->dev, "power GPIO request failed: %d", ret); > + priv->gpio_powerdown = gpiod_get(&spi->dev, "powerdown", GPIOD_OUT_HIGH); > + if (IS_ERR(priv->gpio_powerdown)) { > + ret = PTR_ERR(priv->gpio_powerdown); > + dev_err(&priv->spi->dev, "powerdown GPIO request failed: %d", ret); Binding said it is optional, so this cannot be a failure. Also, please use ret = dev_err_probe syntax. > goto err_free; > } > > - ret = gpio_request(p54spi_gpio_irq, "p54spi irq"); > - if (ret < 0) { > - dev_err(&priv->spi->dev, "irq GPIO request failed: %d", ret); > - goto err_free_gpio_power; > - } > - > - gpio_direction_output(p54spi_gpio_power, 0); > - gpio_direction_input(p54spi_gpio_irq); > - > - ret = request_irq(gpio_to_irq(p54spi_gpio_irq), > - p54spi_interrupt, IRQF_NO_AUTOEN, "p54spi", > - priv->spi); > + ret = request_irq(spi->irq, p54spi_interrupt, IRQF_NO_AUTOEN, "p54spi", priv->spi); > if (ret < 0) { > dev_err(&priv->spi->dev, "request_irq() failed"); > - goto err_free_gpio_irq; > + goto err_free_gpio_power; > } > > - irq_set_irq_type(gpio_to_irq(p54spi_gpio_irq), IRQ_TYPE_EDGE_RISING); > > INIT_WORK(&priv->work, p54spi_work); > init_completion(&priv->fw_comp); > @@ -659,11 +636,9 @@ static int p54spi_probe(struct spi_device *spi) > > err_free_common: > release_firmware(priv->firmware); > - free_irq(gpio_to_irq(p54spi_gpio_irq), spi); > -err_free_gpio_irq: > - gpio_free(p54spi_gpio_irq); > + free_irq(priv->irq, spi); > err_free_gpio_power: > - gpio_free(p54spi_gpio_power); > + gpiod_put(priv->gpio_powerdown); > err_free: > p54_free_common(priv->hw); > return ret; > @@ -675,10 +650,8 @@ static void p54spi_remove(struct spi_device *spi) > > p54_unregister_common(priv->hw); > > - free_irq(gpio_to_irq(p54spi_gpio_irq), spi); > - > - gpio_free(p54spi_gpio_power); > - gpio_free(p54spi_gpio_irq); > + free_irq(priv->irq, spi); > + gpiod_put(priv->gpio_powerdown); > release_firmware(priv->firmware); > > mutex_destroy(&priv->mutex); > @@ -686,10 +659,19 @@ static void p54spi_remove(struct spi_device *spi) > p54_free_common(priv->hw); > } > > +struct of_device_id p54spi_of_ids[] = { static const > + { .compatible = "cnxt,3110x", }, > + { .compatible = "isil,p54spi", }, > + { .compatible = "st,stlc4550", }, > + { .compatible = "st,stlc4560", }, At least last two devices are then compatible, so this should be expressed in the binding with fallback and drop stlc4560 here. Maybe all of them are compatible. > + { }, > +}; > +MODULE_DEVICE_TABLE(of, p54spi_of_ids); > > static struct spi_driver p54spi_driver = { > .driver = { > .name = "p54spi", > + .of_match_table = p54spi_of_ids, > }, Best regards, Krzysztof