From: Ray Jui <ray.jui@broadcom.com>
To: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Wolfram Sang <wsa@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lori Hikichi <lori.hikichi@broadcom.com>,
Dhananjay Phadke <dphadke@linux.microsoft.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] i2c: iproc: handle only slave interrupts which are enabled
Date: Fri, 23 Oct 2020 10:18:23 -0700 [thread overview]
Message-ID: <e4f2c878-4117-d197-2d0b-fed8df90d4b3@broadcom.com> (raw)
In-Reply-To: <20201011182254.17776-3-rayagonda.kokatanur@broadcom.com>
[-- Attachment #1.1: Type: text/plain, Size: 1718 bytes --]
On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote:
> Handle only slave interrupts which are enabled.
>
> The IS_OFFSET register contains the interrupt status bits which will be
> set regardless of the enabling of the corresponding interrupt condition.
> One must therefore look at both IS_OFFSET and IE_OFFSET to determine
> whether an interrupt condition is set and enabled.
>
> Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> drivers/i2c/busses/i2c-bcm-iproc.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> index 834a98caeada..b54f5130d246 100644
> --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> @@ -507,12 +507,17 @@ static void bcm_iproc_i2c_process_m_event(struct bcm_iproc_i2c_dev *iproc_i2c,
> static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data)
> {
> struct bcm_iproc_i2c_dev *iproc_i2c = data;
> - u32 status = iproc_i2c_rd_reg(iproc_i2c, IS_OFFSET);
> + u32 slave_status;
> + u32 status;
> bool ret;
> - u32 sl_status = status & ISR_MASK_SLAVE;
>
> - if (sl_status) {
> - ret = bcm_iproc_i2c_slave_isr(iproc_i2c, sl_status);
> + status = iproc_i2c_rd_reg(iproc_i2c, IS_OFFSET);
> + /* process only slave interrupt which are enabled */
> + slave_status = status & iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET) &
> + ISR_MASK_SLAVE;
> +
> + if (slave_status) {
> + ret = bcm_iproc_i2c_slave_isr(iproc_i2c, slave_status);
> if (ret)
> return IRQ_HANDLED;
> else
>
Acked-by: Ray Jui <ray.jui@broadcom.com>
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4151 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-23 17:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 18:22 [PATCH v1 0/6] fix iproc driver to handle master read request Rayagonda Kokatanur
2020-10-11 18:22 ` [PATCH v1 1/6] i2c: iproc: handle Master aborted error Rayagonda Kokatanur
2020-10-23 17:14 ` Ray Jui
2020-10-11 18:22 ` [PATCH v1 2/6] i2c: iproc: handle only slave interrupts which are enabled Rayagonda Kokatanur
2020-10-23 17:18 ` Ray Jui [this message]
2020-10-11 18:22 ` [PATCH v1 3/6] i2c: iproc: update slave isr mask (ISR_MASK_SLAVE) Rayagonda Kokatanur
2020-10-23 17:19 ` Ray Jui
2020-10-11 18:22 ` [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function Rayagonda Kokatanur
2020-10-23 17:20 ` Ray Jui
2020-10-26 13:52 ` Rayagonda Kokatanur
2020-10-11 18:22 ` [PATCH v1 5/6] i2c: iproc: handle master read request Rayagonda Kokatanur
2020-10-14 3:20 ` Dhananjay Phadke
2020-10-14 9:12 ` Rayagonda Kokatanur
[not found] ` <CAHO=5PEtoJrFEPin0hH19Ubs9Zmhxiay4jSGAhXBFE=ft=+CYg@mail.gmail.com>
2020-10-23 17:26 ` Ray Jui
2020-10-26 13:55 ` Rayagonda Kokatanur
2020-10-11 18:22 ` [PATCH v1 6/6] i2c: iproc: handle rx fifo full interrupt Rayagonda Kokatanur
2020-10-12 22:03 ` Dhananjay Phadke
2020-10-23 17:42 ` Ray Jui
2020-10-26 15:13 ` Rayagonda Kokatanur
2020-10-27 0:36 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f2c878-4117-d197-2d0b-fed8df90d4b3@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brendanhiggins@google.com \
--cc=dphadke@linux.microsoft.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lori.hikichi@broadcom.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).