Re: [PATCH v2 1/4] arm64: dts: ti: j722s-evm: Add DT nodes for power regulators

["Kumar, Udit" <u-kumar1@ti.com>]

On 5/8/2025 9:21 PM, Yemike Abhilash Chandra wrote:
> Add device tree nodes for two regulators on the J722S-EVM. VSYS_3V3 is the
> output of LM5141-Q1, and it serves as an input to TPS22990 which produces
> VSYS_3V3_EXP [1]. VSYS_3V3_EXP serves as vin-supply to CSI RPI Connectors.
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>
> [1]: https://www.ti.com/lit/zip/sprr495
> ---
>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index 34b9d190800e..0f18fe710929 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -141,6 +141,17 @@ vsys_5v0: regulator-vsys5v0 {
>   		regulator-boot-on;
>   	};
>   
> +	vsys_3v3: regulator-vsys3v3 {
> +		/* output of LM5141-Q1 */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vsys_3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vmain_pd>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
>   	vdd_mmc1: regulator-mmc1 {
>   		/* TPS22918DBVR */
>   		compatible = "regulator-fixed";
> @@ -153,6 +164,17 @@ vdd_mmc1: regulator-mmc1 {
>   		bootph-all;
>   	};
>   
> +	vcc_3v3_exp: regulator-TPS22990 {

Please align this name with commit message

with change of vcc_3v3_exp to vsys_3v3_exp

Reviewed-by: Udit Kumar <u-kumar1@ti.com>


> +		/* output of TPS22990 */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_3v3_exp";

This name as well, please to vss_3v3_exp


> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vsys_3v3>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
>   	vdd_sd_dv: regulator-TLV71033 {
>   		compatible = "regulator-gpio";
>   		regulator-name = "tlv71033";