From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1532C32771 for ; Tue, 16 Aug 2022 10:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AlyDzD+bAK2Jt1awCWFRjb/HVAyDITfP+ZqVppzAHsw=; b=4RrN9JK/8hVknW bc+g+HLOm0YhyCY+YPU8LR34x1GQ2MfKyzW7AJl4eE+nVp3Vee5aOyyw7hVtvf9VZnPDRwkk4x5CT c3+j3z4pZrwiI1KigM+cnH9FQbjihszUEAPFHo9Dcan+2sE25oV4xVDBUvXNM7OUFVALAkt2Oq1Go vURUvkDAA31JyQbmvq4tbkC6fzz3/fgzpoJdfXD8K0vJMPF8tALP2C9GOocJm1Gd28bghz6nNmDqS 8SO6jyNThppOxsm5wUlf+9rtCODqRgpPJ9t129kXRN6WO9NxUXCsl76S7XLGhgiTckANz9sNv9juV ljcHW988rCtSEKjzPw0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNtO6-000ayK-IK; Tue, 16 Aug 2022 10:01:32 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNtO0-000aoa-P1 for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 10:01:26 +0000 Received: by mail-lf1-x129.google.com with SMTP id a9so14204760lfm.12 for ; Tue, 16 Aug 2022 03:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=CNCRgWb3pKggt17+aZXpum1u8S3P+8WTUXBySzZQI58=; b=u8tTO6zfQ0qFZw3+/8gsWraUU5j0AIjWN3x1bqyf9laYvSyQd8Itvzf1kOeWEqwBKB xUag+Gf5BJ3rGN146NfaO1a9XnNUCdxlyHbtGnBr+vxqGjAjm/pWC3qFkGjiyKGUovyB OZ1Fw0ahjmz7wdBBFqqV0lUmrmaC2O9bouLWCp8+ca/qTnmQ0CYhx9o45SDbRffY9ePL o62yihQQ1ZJRmvT/aAM9Zr9ybrLKdrllefTqpXF2azRLRdbCBkUe2z2/MAImVsR2N4YY khI6i4qbCzktf88KqfHralU+C+TaWi2roO9MAqAAiNXMtkl6DCIBvHJn0xNoCy1D3RB6 B01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=CNCRgWb3pKggt17+aZXpum1u8S3P+8WTUXBySzZQI58=; b=Pjzvyjb25BtaRTeFieZN/I4V0lCMCf+FtC5JQjcyv4prDOI0Lk2zNC0edhT1aVK/go Mw+zuB2N0oeGqpnjydih7BvjM7h/SFDV8sXC13W+sT6YLh/H1c4Re4bEv0t64Zwr6TMc /OjgFUphj0qAg2AAtSyCEN/tagrqBYdpv3nvjOmYI7ijaF0Rs9WqDufeeL4eCI5CBYfh ppXL+/bKmdxQixq8IqhyUa/z1ppDhGEGpiNU8YJNKq/piWBAz9OxVLwajEjihcerq/7p MfogsJif+boltBLpiP01gyCYbizZEDEmko8hpx035zSOJj2Ck4Hm62P3z6xQWIPVk66q DAcg== X-Gm-Message-State: ACgBeo0ZpvNr+kkXYhAGnnNTgwDnGNXt8kjbj9BmBCSAkEQmy1d5Wpzk u/tHdxhOaCSreQPeUq9HUMocEg== X-Google-Smtp-Source: AA6agR6lmsJwUYBKcY0okFYg8s4OfF3eRvQDWTjCiS+uHlaWGQrsC96OPA5p3aT8yTvYH2UFjTAU1A== X-Received: by 2002:ac2:4db6:0:b0:48a:f9b6:bac1 with SMTP id h22-20020ac24db6000000b0048af9b6bac1mr6550327lfe.669.1660644083188; Tue, 16 Aug 2022 03:01:23 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id u9-20020a05651c130900b0025fdcdad0e4sm1024424lja.35.2022.08.16.03.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 03:01:22 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 13:01:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 4/4] soc: sunxi: sram: Only iterate over SRAM children Content-Language: en-US To: Samuel Holland , Liam Girdwood , Mark Brown , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring Cc: Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220815043436.20170-1-samuel@sholland.org> <20220815043436.20170-5-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20220815043436.20170-5-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_030124_860979_D03CD109 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/08/2022 07:34, Samuel Holland wrote: > Now that a "regulators" child is accepted by the controller binding, the > debugfs show routine must be explicitly limited to "sram" children. > > Signed-off-by: Samuel Holland > --- > > (no changes since v2) > > Changes in v2: > - New patch for v2 > > drivers/soc/sunxi/sunxi_sram.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c > index 92f9186c1c42..6acaaeb65652 100644 > --- a/drivers/soc/sunxi/sunxi_sram.c > +++ b/drivers/soc/sunxi/sunxi_sram.c > @@ -120,6 +120,9 @@ static int sunxi_sram_show(struct seq_file *s, void *data) > seq_puts(s, "--------------------\n\n"); > > for_each_child_of_node(sram_dev->of_node, sram_node) { > + if (!of_node_name_eq(sram_node, "sram")) You should not rely on node names. They can change in DTS. Why do you need to test for the name? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel