From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 921A3C3DA5D for ; Mon, 22 Jul 2024 14:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Et89BBa0phNtHSpJR15GZYlePiM6YxYDP4ofRkAaSAk=; b=D/zZRov6foPGMh6JxtFIsZOyv/ 3EHVuguQ6ajbvuGjzOA69eenK+iXjGDPW5EOAczmeWeyc5KWwpEBJ68KbkoHFv3Y4pKbEz4jip6Fh vCmDqWI6hD/68+R7ox/v8rJGoxMjFDhwy5KRx0g8dcLN3svsUG8cQj8AfOtXjHB2CWOOZhcOCD/bw iuppmlr4iNc7wZtjnC6EhaRMeHmRlyzPx12Y12wnYO018EQ7x+Y2YgCJzQqxM2UlmjN4l8WftBbUf NpBtqqAzYY2ZU4Qw+Vecbuu24tJb02z5q1Qdcixuqz8eZZiXV6IzZFSE1gLmrUXUXKVdGjhPCotLZ iOtKPv2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVu9L-00000009o9Y-3iwJ; Mon, 22 Jul 2024 14:36:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVu8y-00000009o4p-22Ay for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 14:36:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27429FEC; Mon, 22 Jul 2024 07:36:29 -0700 (PDT) Received: from [10.2.76.71] (e132581.arm.com [10.2.76.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96D233F73F; Mon, 22 Jul 2024 07:36:01 -0700 (PDT) Message-ID: Date: Mon, 22 Jul 2024 15:36:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/6] perf auxtrace arm: Set the 'auxtrace' flag for AUX events To: Adrian Hunter , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , James Clark , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Jiri Olsa , Mark Rutland , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240721202113.380750-1-leo.yan@arm.com> <20240721202113.380750-3-leo.yan@arm.com> <785cf263-5a76-48d8-964b-c248297de47e@intel.com> Content-Language: en-US From: Leo Yan In-Reply-To: <785cf263-5a76-48d8-964b-c248297de47e@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_073604_609246_AB25F800 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/22/24 11:49, Adrian Hunter wrote: > On 21/07/24 23:21, Leo Yan wrote: >> Originally, the 'auxtrace' flag in the PMU event is used for AUX area >> sampling. It indicates a PMU event is for AUX tracing. >> >> Set this flag for AUX trace events on Arm. >> >> Signed-off-by: Leo Yan > > Note same as: > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20240715160712.127117-6-adrian.hunter%40intel.com%2F&data=05%7C02%7Cleo.yan%40arm.com%7C909e738ccfd84b1ad1dc08dcaa3bf922%7Cf34e597957d94aaaad4db122a662184d%7C0%7C0%7C638572421778104310%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=rJq9SLjbFOrZRkWIGLj8Xj682h%2BW%2FD8O0IL3ac0UcO4%3D&reserved=0 > > Either should be fine: > > Acked-by: Adrian Hunter Thank you for the patch, I will drop my one. Leo >> --- >> tools/perf/arch/arm/util/pmu.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/perf/arch/arm/util/pmu.c b/tools/perf/arch/arm/util/pmu.c >> index 1c9541d01722..b7fa1245e242 100644 >> --- a/tools/perf/arch/arm/util/pmu.c >> +++ b/tools/perf/arch/arm/util/pmu.c >> @@ -25,6 +25,7 @@ void perf_pmu__arch_init(struct perf_pmu *pmu) >> /* add ETM default config here */ >> pmu->selectable = true; >> pmu->perf_event_attr_init_default = cs_etm_get_default_config; >> + pmu->auxtrace = true; >> #if defined(__aarch64__) >> } else if (strstarts(pmu->name, ARM_SPE_PMU_NAME)) { >> pmu->selectable = true; >> @@ -32,8 +33,10 @@ void perf_pmu__arch_init(struct perf_pmu *pmu) >> pmu->perf_event_attr_init_default = arm_spe_pmu_default_config; >> if (strstarts(pmu->name, "arm_spe_")) >> pmu->mem_events = perf_mem_events_arm; >> + pmu->auxtrace = true; >> } else if (strstarts(pmu->name, HISI_PTT_PMU_NAME)) { >> pmu->selectable = true; >> + pmu->auxtrace = true; >> #endif >> } >> #endif >