From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17042C43381 for ; Mon, 4 Mar 2019 10:59:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD4E1206B8 for ; Mon, 4 Mar 2019 10:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cnS766Pq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n9k6xRPL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD4E1206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqXFKqwLM8xkkv5CA7wPh+pL5XdueIyxGEuQ7+7/h5M=; b=cnS766PqK5kn1i lnkVJfSj7K2vOjSUv2PZ4an5kI2J6PltdxarfCiFMX+Y7/fXLeivzU7JrvlV87PmvrJy+6mxngD0I nTwrYwZF95GqhTi/ZT3m5A0e7P2bT7j9NEczGLRgIKpPdK2zNp/Pbfg/Khxn6arjGmrXf1PN04S3W t4UuwdLHBqDVWzjd/BYHLuKUG7umczPJHKmXTgZt79yPYolGyoHkti1SLM+vA3tHxrwc2/Jb6KI1I mEG/JHHWNwRvLLWxhuLm3kNofeLW1Y+qVGsjIfUQ2SMX84mexTOlD8A1CRcNhxlF1IAkyn2xDPwz8 9CKXG96asCIHFBIVqerg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0lK7-0007NG-C8; Mon, 04 Mar 2019 10:59:55 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0lK3-0007Mt-T7 for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 10:59:53 +0000 Received: by mail-wr1-x443.google.com with SMTP id d17so5014282wre.10 for ; Mon, 04 Mar 2019 02:59:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2klST8JE6niPuT0xe7yojAP5OqBzaqSnk7a3fulW5bs=; b=n9k6xRPLfGW010MAscIytFj52pVOlSa58ke/Z/Jx18ypvybwG0cma1pAdZhAoZQgrt +Go9khd03vCFUC6PmkS6brIsHcPmnhnhMD6spo2v9q5UVUaYKS3Ge2UYSYhp3sxeB2HI VnpupqQUBQx/bulZMPMsdfoZ9i1hOipndNG3If2UPLlWs/SOJYk5OcXZwe6sFYx2n/nb WSQMKq4lLeydClfnS3YGQFlTDsBebLKHGlv9JSFNU++lxZmu5PEI4hCDNOZgCYNQsOzI uf3pVQ0ts/a3cs5gPpUIXmB3Ju2IEuEbcjPmPw3xkuOH8AVcERB24HxTbouJ0LbEW05+ h35g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2klST8JE6niPuT0xe7yojAP5OqBzaqSnk7a3fulW5bs=; b=XYoHK1g2xM0ErIViq2oYAO8bC+gLcCH3iL5rtz7qNhTI4R5fgQ7AVfqpkkQmqFtYUL K/GlGCSIQBcOGrWzxD8I+EV9uV5gorAVVEU3Zfk7IzrxP7/CrllNhiL0KDLEt21CnRJ0 VL24o9F3wpihMod7sA/5nAAuBmqliQ2fFacYZshQbSaG0KAKhJqtRE+fU9Yr72y8u9sn 7ikxuDt4XXG0aZSjshiOJxe1qs95z3X89vLKC2XfjowAuzMCCW9/dkFXd8875lpGHicf 6J1Xq9iK4MOK4weaB74BFSofOPKLcTAzai8qyd41I7BYNZHR/4lY1IQK8KxH6yxktXYq kVjw== X-Gm-Message-State: APjAAAWpne7Tf2Z1vTZdqBXPdMlLOgpU2jYdRxGJL8/Mo2N1vR4cZUqN IHBUXiJIfznfYfMbnl+eoHtgttj7 X-Google-Smtp-Source: APXvYqyyp/TJG4VzQya2Y5S2rImsfUDJfiE17VsyX2CdafIGTCQwvAj78oSiHYxmcqiwJhtiy4qWYw== X-Received: by 2002:adf:f9c4:: with SMTP id w4mr12703773wrr.218.1551697190408; Mon, 04 Mar 2019 02:59:50 -0800 (PST) Received: from [192.168.1.4] (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id t9sm6946258wrx.73.2019.03.04.02.59.49 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 02:59:49 -0800 (PST) Subject: Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node To: Wolfram Sang , Geert Uytterhoeven References: <20190303190059.31155-1-marek.vasut@gmail.com> <20190304105705.GA1000@kunai> From: Marek Vasut Openpgp: preference=signencrypt Message-ID: Date: Mon, 4 Mar 2019 11:59:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190304105705.GA1000@kunai> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_025952_577267_A4027187 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Linux-Renesas , Wolfram Sang , Simon Horman , Linux ARM , Marek Vasut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/4/19 11:57 AM, Wolfram Sang wrote: > >>> Add DA9063 PMIC node to the I2C bus. >>> >>> Signed-off-by: Marek Vasut >> >> Thanks for your patch! >> >> Reviewed-by: Geert Uytterhoeven > > Thanks for CCing me, I didn't get and missed the original patch. > >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>> @@ -377,6 +377,27 @@ >>> pinctrl-names = "i2c-exio4"; >>> }; >>> >>> +&i2c7 { >>> + status = "okay"; >>> + clock-frequency = <100000>; >> >> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. >> It looks like there are no other devices on the bus. >> >> Wolfram, what's your stance on this? > > Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but > seems not. Probably it slipped through the cracks. Do we want to update all of the other boards too ? I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted. -- Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel