From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E349C433F5 for ; Wed, 9 Mar 2022 17:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uaA5pDdl100WVShxYHmD6U6Jte66hUUR+rnRDXM6mZc=; b=ErlZ0AVGNdfKVJlIT85b2fdZlm SiIiNNvPjNIDUogAaqpOWcgE1rYGf64g2GU8bpWdilMXvZLIyf5XOU6LGhtCaSItMNDu2XO3qtRBp ra3qbeLLcIYpXuiwgFK3bK4g95waPFSseVVfKnPTjP3UGyIMmW9NQPxBUFv+MnVSWLJUCAauS/lwf Y5wqPxe73fm7ZG4FQt7qeaONc1JZGUi0zDwpKlvV9jC5jQLEkWFVKgoPVgmsdnknJ0D+qYUA0Zaps p4BMz+u5iY/WVRbC8j/rjd2atmAN+D6yzZKkUuKekHRTSRtpf65jOZPzdEEl9QWF/GfkNunoPN8KD aq/fuiCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS0Yc-009wEC-LR; Wed, 09 Mar 2022 17:57:07 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS0SR-009toW-BQ for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 17:50:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 958D4B82229; Wed, 9 Mar 2022 17:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57A8AC340E8; Wed, 9 Mar 2022 17:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646848240; bh=aV8HvlaK03F1JqH8FZ5kAKtPL9ZlQkIr+U5+kyN3JTg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WHqs8Lmd57dO5boy0fDzcMAEltLHxWw4qfn4uSWbMswtbqh5Oe5nN23B0Cc2hfpuA pSsBv8ivRtrGdE1xpqrfua4RK8s0flEDrFRRTJBfbUixv7iPWCecjodyjDVjxpgnEh q192hPGY0tDXvzj1GRlK03OFmWyieCqy9wTInLSoTxulKVXSBGDOWmgBGCcZXnLS1K VahWO0y470wI4rWlolYjY90KR92sVlZFXHDXGcYhLmiLHJj9lzhhPRq7gJn5fGvl70 qK2hvMkj1DYs4xfA8YENB+B4U73IZxuYf8BB3Ok+/pEEF6ehpTPw9E92uZai6UvCXM mOwCAtWvBwdow== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nS0SL-00DOyR-Nx; Wed, 09 Mar 2022 17:50:37 +0000 MIME-Version: 1.0 Date: Wed, 09 Mar 2022 17:50:37 +0000 From: Marc Zyngier To: Qian Cai , will@kernel.org Cc: Linu Cherian , tglx@linutronix.de, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com Subject: Re: [PATCH V3] irqchip/gic-v3: Workaround Marvell erratum 38545 when reading IAR In-Reply-To: References: <20220307143014.22758-1-lcherian@marvell.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: quic_qiancai@quicinc.com, will@kernel.org, lcherian@marvell.com, tglx@linutronix.de, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_095043_766307_533798CC X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-03-09 17:40, Qian Cai wrote: > On Mon, Mar 07, 2022 at 08:00:14PM +0530, Linu Cherian wrote: >> When a IAR register read races with a GIC interrupt RELEASE event, >> GIC-CPU interface could wrongly return a valid INTID to the CPU >> for an interrupt that is already released(non activated) instead of >> 0x3ff. >> >> As a side effect, an interrupt handler could run twice, once with >> interrupt priority and then with idle priority. >> >> As a workaround, gic_read_iar is updated so that it will return a >> valid interrupt ID only if there is a change in the active priority >> list >> after the IAR read on all the affected Silicons. >> >> Since there are silicon variants where both 23154 and 38545 are >> applicable, >> workaround for erratum 23154 has been extended to address both of >> them. >> >> Signed-off-by: Linu Cherian > > Reverting this commit from today's linux-next fixed > global-out-of-bounds > accesses running CPU hotplug workloads on a non-ThunderX server. > > psci: CPU88 killed (polled 0 ms) > ================================================================== > BUG: KASAN: global-out-of-bounds in is_affected_midr_range_list > Read of size 4 at addr ffffa0ec80ddcc6c by task swapper/88/0 > > CPU: 88 PID: 0 Comm: swapper/88 Not tainted > 5.17.0-rc7-next-20220309-dirty #25 > Call trace: > dump_backtrace > show_stack > dump_stack_lvl > print_address_description.constprop.0 > print_report > kasan_report > __asan_report_load4_noabort > is_affected_midr_range_list > is_midr_in_range_list at ./arch/arm64/include/asm/cputype.h:221 > (inlined by) is_affected_midr_range_list at > arch/arm64/kernel/cpu_errata.c:41 > verify_local_cpu_caps > verify_local_cpu_caps at arch/arm64/kernel/cpufeature.c:2787 > check_local_cpu_capabilities > verify_local_elf_hwcaps at arch/arm64/kernel/cpufeature.c:2852 > (inlined by) verify_local_cpu_capabilities at > arch/arm64/kernel/cpufeature.c:2922 > (inlined by) check_local_cpu_capabilities at > arch/arm64/kernel/cpufeature.c:2948 > secondary_start_kernel > __secondary_switched > > The buggy address belongs to the variable: > cavium_erratum_23154_cpus > > The buggy address belongs to the virtual mapping at > [ffffa0ec80dd0000, ffffa0ec82140000) created by: > map_kernel Urgh... Thanks for reporting this. Will, can you either drop this patch, or squash the following diff in? Thanks, M. diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c index 1d9d4f910de7..400a1c9cac90 100644 --- a/arch/arm64/kernel/cpu_errata.c +++ b/arch/arm64/kernel/cpu_errata.c @@ -225,6 +225,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = { MIDR_ALL_VERSIONS(MIDR_OCTX2_95XXN), MIDR_ALL_VERSIONS(MIDR_OCTX2_95XXMM), MIDR_ALL_VERSIONS(MIDR_OCTX2_95XXO), + {}, }; #endif -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel