From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5279C433F5 for ; Tue, 15 Feb 2022 23:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Y3NkubexlQePaj7ZX6gmHbIBNiYld5LKG1HrKOmeOcc=; b=X5MUuxyVJYJ8sP14RtYBfj9MGD AKwP5/unjJ3Ck1sKdFvGJwnoTAPgUKDYuCN587+JDAcv8/HZOm5cNAePsAlK0SQay745bVG1MkpLm dK7YZDOK7p4xSX4srbEnrGM3R3SsQrOw80okQDrSyvRs3PSt8aL38EoPOhWUEACwNQ/pGQVW0/rUX XMaKoEKIfxXlcSWqEunVU4O11kYff9Z/kWQV7I84qonvbGquwRbzA7/sfJwgqC5PgwunuF0y9Aht8 JK54EHmzWMOCyK5PaJgS82QwtffUIiov/nMiZDnQc6IfFLTsKo17DYb9vDvCV5NdaHjY81gdPGSds RJOjF6Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK7Po-004wpS-S2; Tue, 15 Feb 2022 23:39:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK7Pk-004wod-DG for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 23:39:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A94E1396; Tue, 15 Feb 2022 15:39:17 -0800 (PST) Received: from [10.163.46.213] (unknown [10.163.46.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A86FB3F66F; Tue, 15 Feb 2022 15:39:15 -0800 (PST) Subject: Re: [PATCH V2] arm64/hugetlb: Define __hugetlb_valid_size() To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org References: <1644491770-16108-1-git-send-email-anshuman.khandual@arm.com> <20220215164851.GD8458@willie-the-truck> From: Anshuman Khandual Message-ID: Date: Wed, 16 Feb 2022 05:09:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220215164851.GD8458@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_153920_547922_2824F77D X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/15/22 10:18 PM, Will Deacon wrote: > On Thu, Feb 10, 2022 at 04:46:10PM +0530, Anshuman Khandual wrote: >> arch_hugetlb_valid_size() can be just factored out to create another helper >> to be used in arch_hugetlb_migration_supported() as well. This just defines >> __hugetlb_valid_size() for that purpose. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> This applies on v5.17-rc3 >> >> Changes in V2: >> >> - s/arm64_hugetlb_valid_size/__hugetlb_valid_size per Catalin >> - Restored back warning in arch_hugetlb_migration_supported() per Catalin >> - Updated the commit message subject line as required >> >> Changes in V1: >> >> https://lore.kernel.org/all/1644197468-26755-1-git-send-email-anshuman.khandual@arm.com/ >> >> arch/arm64/mm/hugetlbpage.c | 26 +++++++++++++------------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c >> index ffb9c229610a..72ed07fe2c84 100644 >> --- a/arch/arm64/mm/hugetlbpage.c >> +++ b/arch/arm64/mm/hugetlbpage.c >> @@ -56,24 +56,19 @@ void __init arm64_hugetlb_cma_reserve(void) >> } >> #endif /* CONFIG_CMA */ >> >> +static bool __hugetlb_valid_size(unsigned long size); > > Why not reorder the code to avoid this forward declaration? That will create more code churn, which I tried to avoid. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel