From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F69CF2579 for ; Sun, 13 Oct 2024 08:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DUFnMNJUXza/njpSXxTH+Ff9y3vwCgrsFcCI5A2y8BU=; b=kEmkdD23xL1f7O/46HqPgSt98U dPe9T5KEQbUFqTBSBc/iGRDldaq8zx2SxkzsaTHra0U5ppVy5VYblo6hI/Hwug4X513r/8ONjFNHV cOquUisj1/rgKodpUmI4ZNUtQIGZyy8JJ1wsbG3BJP1bfhS4m2NFP0bo2BYGcg8TFewhvu7aJCGHz rO2MuW/xWO9B1hInqaLKo6ckAGITRlEImb1JRIW5RaREyukDt4rJU29R3I2VNff/tLjzEFLTwFet3 SCR/nT/H4xsQlTCthTXvvTxpFmYrTM5In5WZOlolI1p89mrADtJUe5XDeazjNy+keSkGtpAhMcA37 8aImbvMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szuK4-00000002Qoh-3IFV; Sun, 13 Oct 2024 08:51:32 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szuGa-00000002QPB-2Sxi; Sun, 13 Oct 2024 08:47:58 +0000 Received: from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A1DD04CE; Sun, 13 Oct 2024 10:46:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728809175; bh=vjMo2uToGmLVWARLnCV3SWBPMkV4Bwj6pFqquGlw13M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bQx0BdI9qDh2ug0/GU5yjGuc9NKhCyaZQa3rVRwHlmzaxNo871hKX4VRBn5Ll9Iu5 mpekhzd2aXY3NUGUnC7GzmCU+6a81BOV5/1uFMrNBV5/uZmmxU9MqxnkpGNwsWF+xM lCn9AksXMuUXMG32R3actdP8FGo9KC21cBcCzaM0= Message-ID: Date: Sun, 13 Oct 2024 14:17:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] staging: vchiq_arm: Fix drv_mgmt leak To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Dan Carpenter , Laurent Pinchart , kernel-list@raspberrypi.com, Stefan Wahren References: <20241013084529.377488-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Umang Jain In-Reply-To: <20241013084529.377488-1-umang.jain@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241013_014756_824003_70E9E40D X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, [Treat this series as RFC] On 13/10/24 2:15 pm, Umang Jain wrote: > 1/2 is a drive by fix. > 2/2 uses devres resouce management helper devm_kzalloc() to auto-free > struct vchiq_drv_mgmt on error and .remove() paths. > > It might be good to aware the devres issue and following talk might > give reviewers a helpful context: > > - https://lpc.events/event/16/contributions/1227/ > - https://archive.fosdem.org/2023/schedule/event/devm_kzalloc/ > > I am not totally sure if these problems, causes a blockers for these > patches. There are a couple of memory management issues I've spotted > which can be fixed? by devres (similar to this series) but probably I > will wait for initial feedback on this series. Was supposed to mark this as RFC for discussion and yes, I have realised I've not written a commit message for 2/2. > > Umang Jain (2): > staging: vchiq_arm: Drop blank lines > staging: vchiq_arm: Use devm_kzalloc for mgmt > > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >