From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD15C3DA4A for ; Mon, 5 Aug 2024 14:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IXvFEV23D3inzoK9UHnV6MZ+wdpqlZ9BXm/gNbTle7k=; b=KCwtrB7cjLnb/TA6rEZOuUEWtQ NID8kD4BBR8jf/dP6FwsPWbiA3SJPhidyQz+YizQ/VGWDXGGOhcMb52WDpW/OCJ/4nTtI1y9AS3TQ 7vC585dUWCSvj6SBbLRXFlixZCohAuD3ZBsBg3MrXmCzOhActLI5iRB00pcFhxKgTxQ5IooYEFZSU B5+/hVcg0qnDOAhuq6+Kl+2pq7nwTcfFJKC63PQrHiMDbIDvelF61+iBEsS1oCSQj6BhF3wJ5S/2a xHVZV0NJ4IknV8hLUih+w4QVMlXuUwJZx/qEZLEk/jDJnDOsTGG+wNCLul5ImjJZGiqzbm4GiQakB PSHmIo8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saz6L-0000000GDFx-3sSY; Mon, 05 Aug 2024 14:54:21 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saz5p-0000000GD7n-05PV for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 14:53:50 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id 791C720B7165; Mon, 5 Aug 2024 07:53:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 791C720B7165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1722869627; bh=IXvFEV23D3inzoK9UHnV6MZ+wdpqlZ9BXm/gNbTle7k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IN4D5riNkq/m8Ez+7VFOpa+SbYTTmcw2byacu+s6unfL5coCZYaPsNjYfpA6WehQQ Uuf1oq8U/XBpaU5Fh3R4Sy8bPnyDv+t2JANo0+mH7W4qbAPTDrY+rtUn+mkvq3EnNW GzSNvWTcQvxuyk/9WjtFRNWJkIpqql+P5jcO7muc= Message-ID: Date: Mon, 5 Aug 2024 07:53:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] arm64: hyperv: Use SMC to detect hypervisor presence To: Wei Liu Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240726225910.1912537-1-romank@linux.microsoft.com> <20240726225910.1912537-2-romank@linux.microsoft.com> Content-Language: en-US From: Roman Kisel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_075349_174416_269A0513 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/2/2024 6:21 PM, Wei Liu wrote: > On Fri, Jul 26, 2024 at 03:59:04PM -0700, Roman Kisel wrote: >> The arm64 Hyper-V startup path relies on ACPI to detect >> running under a Hyper-V compatible hypervisor. That >> doesn't work on non-ACPI systems. >> >> Hoist the ACPI detection logic into a separate function, >> use the new SMC added recently to Hyper-V to use in the >> non-ACPI case. >> >> Signed-off-by: Roman Kisel > > The change looks sensible. > > Within one minor comment fixed below: > > Acked-by: Wei Liu > > However I would also like to get an Acked-by or reivewed-by from someone > who works on the ARM64 side of things -- Saurabh, Boqun, Srivatsa, and > Jinank? > >> --- >> arch/arm64/hyperv/mshyperv.c | 36 ++++++++++++++++++++++++++----- >> arch/arm64/include/asm/mshyperv.h | 5 +++++ >> 2 files changed, 36 insertions(+), 5 deletions(-) >> > [...] >> diff --git a/arch/arm64/include/asm/mshyperv.h b/arch/arm64/include/asm/mshyperv.h >> index a975e1a689dd..a7a3586f7cb1 100644 >> --- a/arch/arm64/include/asm/mshyperv.h >> +++ b/arch/arm64/include/asm/mshyperv.h >> @@ -51,4 +51,9 @@ static inline u64 hv_get_msr(unsigned int reg) >> >> #include >> >> +#define ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_0 0x7948734d >> +#define ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_1 0x56726570 > > Presumably these are ASCII codes for an identifier string, please > provide comments to explain what they are. > Michael posted a suggestion to change that altogether; will elaborate on the topic in the thread with Michael. >> +#define ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_2 0 >> +#define ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_3 0 >> + >> #endif >> -- >> 2.34.1 >> -- Thank you, Roman