From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B3E5C76195 for ; Fri, 17 Mar 2023 09:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aWjV7tpcGP+gxE6ZIfuT+13n0bahwWxk+adaSGt6rVE=; b=xD7MIWJQ6f+IT3 hyXexFu95F+ZG46DD+c6bSysXAeeBEKo3a3jmS9ay0NvOiXp1JJQGZUo/c0E0R8+GOcsS4FRu96aO OncR5jnQJRXicFF8ZWANUHdXbBK7ZtyoD/MZ012oLlKdfhG8H1K3TpVG6xyaXwKCexHT+ZzuIoriy FVK2WlAihns6BV242xJ35BHJlyuHvkmIIqgfO58YpHt8e3ybm0PZxrFnAdJd7oLEwWiuAAiFUMQTk 2gkWVZ2vmV3I3CvVRovCzNAN0LE+vn1j4MtdUIATcOcg5QiGa9CygCe5xSZEeUV0+45H556GF3inp La2vTDCWm0lbwAZB17kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd65U-001fRl-31; Fri, 17 Mar 2023 09:09:24 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd65R-001fQz-1E for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 09:09:23 +0000 Received: by mail-ed1-x531.google.com with SMTP id eh3so17623121edb.11 for ; Fri, 17 Mar 2023 02:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679044159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bwh85sD/XE4ZPG7n6FYMfigvAZYyWZkG5V3jgNeiqVM=; b=GFTPf1vCyaFRN6hLZgI1MlNKMq6zQ2OHzOcjPhbUtzZnBVMeKtakMREJMCpzYDKIhr J6xfgdW3sdgohQHzg+8SDyxZ/iJ1AG4r/8+UDt60iXgVPtI9L0sQQx6SUKxJpxezCu5n 3jA4MEE2Dw9Jpcnm+8UJVcYusqbG6sA/+XGrqWa7whbbLfN7K58+93kMB4sI2ed+VPbl GZdhpMML212wvby4/1dNcMfOHr0NNkhC5dNUkyS5ZkTbP8PHYwWArDXHhkQ0bRLoBAxc cCVHZV1W8tESmnCm+DsJ5f/ccZPxuOqSF7TK5paq0DnOIz4zQsE2oe3YMVDUfyp/y7UD 3Z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679044159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bwh85sD/XE4ZPG7n6FYMfigvAZYyWZkG5V3jgNeiqVM=; b=MO6nkAz5+MOBFRgl+Zuhg1eSE6t/Lbct5YPzKSTF1SpgTo9KsTkGlykvcZdrlTiHFh 6yruSJIW2Xkvl4mtCNLsv/YNCQIOZsWuiI4myLvcoDWXug0Q0zs2B6AgvHxk50K96uaW yJP6L2YbahkGj4BOmG0kZejbr6F2ng5q6iL77XrcHet2HA3QLnGcocaSgLMJ+LvokDkT l/VQ7rUDPgB68OJtCqf8KQvqyii144L3dtgpdyvVKHhbtZVWCZ+NIm5FACnKEvxxByTf Pn68v7nnor4nZeRwJWg1WmBQgM6nnV0JMg/iW+NP1C0rU0W1sVzmSqEP6w9CYI+JX34k FIPg== X-Gm-Message-State: AO0yUKUTv7qmqlf9nv/DPAx00Rh7alYRWkyFAPYg1WIDaTMuKVZZoNql 2xICX6qvEqYyARFXFIq9/YdVRg== X-Google-Smtp-Source: AK7set+jbzzcgm/NqZwsPW4WXCK9O9EUDXRK3QLEtf2yNwHhKetE4b6qIjmPC0UTyg2eeknKx/lx5A== X-Received: by 2002:a17:906:1316:b0:8e4:96c4:94a with SMTP id w22-20020a170906131600b008e496c4094amr12506906ejb.56.1679044159545; Fri, 17 Mar 2023 02:09:19 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:848a:1971:93e0:b465? ([2a02:810d:15c0:828:848a:1971:93e0:b465]) by smtp.gmail.com with ESMTPSA id g20-20020a1709061e1400b00930f5ecbd8fsm723418ejj.219.2023.03.17.02.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 02:09:19 -0700 (PDT) Message-ID: Date: Fri, 17 Mar 2023 10:09:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings Content-Language: en-US To: Frank Li , shawnguo@kernel.org Cc: devicetree@vger.kernel.org, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de References: <20230316212712.2426542-1-Frank.Li@nxp.com> <20230316212712.2426542-2-Frank.Li@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230316212712.2426542-2-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_020921_420205_9B056DAB X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/2023 22:27, Frank Li wrote: > NXP imx8qm integrates 1 cdns3 IP. This is glue layer device bindings. > Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > Signed-off-by: Frank Li > --- > .../bindings/usb/fsl,imx8qm-cdns3.yaml | 122 ++++++++++++++++++ > 1 file changed, 122 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/fsl,imx8qm-cdns3.yaml > > diff --git a/Documentation/devicetree/bindings/usb/fsl,imx8qm-cdns3.yaml b/Documentation/devicetree/bindings/usb/fsl,imx8qm-cdns3.yaml > new file mode 100644 > index 000000000000..fc24df1e4483 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/fsl,imx8qm-cdns3.yaml > @@ -0,0 +1,122 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/fsl,imx8qm-cdns3.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP iMX8QM Soc USB Controller > + > +maintainers: > + - Frank Li > + > +properties: > + compatible: > + const: fsl,imx8qm-usb3 > + > + reg: > + items: > + - description: Address and length of the register set for iMX USB3 Platform Control Drop "Address and length of the"... or actually just maxItems: 1, because the description is a bit obvious. > + > + "#address-cells": > + enum: [ 1, 2 ] > + > + "#size-cells": > + enum: [ 1, 2 ] > + > + ranges: true > + > + clocks: > + description: > + A list of phandle and clock-specifier pairs for the clocks > + listed in clock-names. Drop description. > + items: > + - description: Standby clock. Used during ultra low power states. > + - description: USB bus clock for usb3 controller. > + - description: AXI clock for AXI interface. > + - description: ipg clock for register access. > + - description: Core clock for usb3 controller. > + > + clock-names: > + items: > + - const: usb3_lpm_clk > + - const: usb3_bus_clk > + - const: usb3_aclk > + - const: usb3_ipg_clk > + - const: usb3_core_pclk > + > + assigned-clocks: > + items: > + - description: Phandle and clock specifier of IMX_SC_PM_CLK_PER. > + - description: Phandle and clock specifoer of IMX_SC_PM_CLK_MISC. > + - description: Phandle and clock specifoer of IMX_SC_PM_CLK_MST_BUS. > + > + assigned-clock-rates: > + items: > + - description: Must be 125 Mhz. > + - description: Must be 12 Mhz. > + - description: Must be 250 Mhz. I would argue that both properties above are not needed. If your hardware requires fixed frequencies, clock provider can fix them, can't it? > + > + power-domains: > + maxItems: 1 > + > +# Required child node: > + > +patternProperties: > + "^usb@[0-9a-f]+$": > + $ref: cdns,usb3.yaml# > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - ranges > + - clocks > + - clock-names > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + usbotg3: usb@5b110000 { Drop label, unused > + compatible = "fsl,imx8qm-usb3"; > + ranges; > + reg = <0x5b110000 0x10000>; reg is second property > + clocks = <&usb3_lpcg IMX_LPCG_CLK_1>, > + <&usb3_lpcg IMX_LPCG_CLK_0>, > + <&usb3_lpcg IMX_LPCG_CLK_7>, > + <&usb3_lpcg IMX_LPCG_CLK_4>, > + <&usb3_lpcg IMX_LPCG_CLK_5>; > + clock-names = "usb3_lpm_clk", "usb3_bus_clk", "usb3_aclk", > + "usb3_ipg_clk", "usb3_core_pclk"; > + assigned-clocks = <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_PER>, > + <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MISC>, > + <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MST_BUS>; > + assigned-clock-rates = <125000000>, <12000000>, <250000000>; > + power-domains = <&pd IMX_SC_R_USB_2>; > + #address-cells = <1>; > + #size-cells = <1>; > + status = "disabled"; Drop status > + > + usbotg3_cdns3: usb@5b120000 { Drop label > + compatible = "cdns,usb3"; > + interrupt-parent = <&gic>; > + interrupts = , > + , > + , > + ; > + interrupt-names = "host", "peripheral", "otg", "wakeup"; > + reg = <0x5b120000 0x10000>, /* memory area for OTG/DRD registers */ > + <0x5b130000 0x10000>, /* memory area for HOST registers */ > + <0x5b140000 0x10000>; /* memory area for DEVICE registers */ > + reg-names = "otg", "xhci", "dev"; reg is second property, reg-names third. > + phys = <&usb3_phy>; > + phy-names = "cdns3,usb3-phy"; > + }; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel