From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 363EEC4345F for ; Tue, 30 Apr 2024 01:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kt5YJrFBeORyG3OcBWw6LpQECzTcD44pNWddd0J/96w=; b=LfpD0P0KHgOezB 8lxflfHbZjDdZXBcibY2M6MvOE1mZoTzZSx0/eXK+pSCkWPN3fb1wO8vStpLU5FFzlQqL9FReTNPa jJGVWQ6EHkYzaV6WoCWDZ8/6OUWavyYAXDYrYZgC5tf6mtmZatvKLwy+QJHi8ObEoyG9RtJCDR3tg jx2asp2wP0FRaNtVgRuI/2u9kAQT6avhJr6pDMBvnQdC5iMgcN9Smri4SI2iojJ+bje2VIj9QtmW/ b/fDvWb5ypDZ9bXUEkMJw9iHqRlFwuyi6OjufEG8a5itBkV/5QguAt6IUc2Ads/XokxgOXtophbdi uIsCQ+lG9PQni/dug7IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1cRt-00000004ha5-1F6m; Tue, 30 Apr 2024 01:38:25 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1cRp-00000004hZj-4BsD for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 01:38:23 +0000 Received: from [192.168.68.112] (ppp14-2-127-66.adl-apt-pir-bras32.tpg.internode.on.net [14.2.127.66]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id F402E200EF; Tue, 30 Apr 2024 09:38:17 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1714441100; bh=iO2Qb5vOGlEJy2p0kRpFmo54k139J+5qqBLF4SdTE8M=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=YWNZ6eSuJjdbazCq5Tr+/UMFUigvmiomlY34UiNQ8iZ6ukGL8t2ygckWbW1FQPw9r RUeeQGYiZKxASLXC4rgHy1PIE6o8XoALUjlioZrOuwUW5ZjmgYcKmbsc50mIeCVXni oJaGFoo+2fA6LPSY+LMM4E6fTl9NonCyWAwD0qFIwOLUvdmKadqtZK601bTUmdyXrY 2EUw64UOzIzHckNCD8Rn/cfiZ0KYODOl5DmnQS3GfkoC5O1+dma7eD9mhKmJ5HRMe5 ZAswFxFNqvUPPyphfQ23WKJRJ4REOwCXp1NerfE53XMINCfVWGcC1iO1OhYCemDU2M 661FS1yGDsWFA== Message-ID: Subject: Re: [PATCH v8 1/1] drivers: watchdog: revise watchdog bootstatus From: Andrew Jeffery To: Peter Yin Cc: patrick@stwcx.xyz, Wim Van Sebroeck , Guenter Roeck , Joel Stanley , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Tue, 30 Apr 2024 11:08:17 +0930 In-Reply-To: References: <20240428142937.785925-1-peteryin.openbmc@gmail.com> <20240428142937.785925-2-peteryin.openbmc@gmail.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_183822_359563_D30CD59E X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2024-04-29 at 22:54 +0800, Peter Yin wrote: > Hi Andrew, > I am not sure how to add the Fixes tag, Is it like this? > > Fixes: 6a6c7b006e5c (watchdog: aspeed: Add support for > aspeed,reset-mask DT property). Approximately, yes, but it must not be wrapped. Some more info is provided in the submitting-patches documentation: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes > Signed-off-by: Peter Yin > > Is it the correct commit ID or should I base on which commit ID? > The correct commit ID to use is the one that introduces the problem. Using `git blame drivers/watchdog/aspeed_wdt.c` it appears you're changing the behaviour that was introduced in 49d4d277ca54 ("aspeed: watchdog: Set bootstatus during probe"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49d4d277ca54e04170d39484c8758a0ea9bca37d Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel