From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D4CBC47422 for ; Sat, 27 Jan 2024 01:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2dlkbwH7DbYMwweZp3O5zjBjOmpL8lpkY4p90HtYAE=; b=s0I/qD2uqN85XG 4VvjeBIVakpSU5G6fVFBaSj56EAE6LbQpLs7ZOfIjBDC+cZO2vOLvAqa3kSxrWwwtIS09TPJl0Gx6 05OGoe1M381Sr8dlbKU/et8xIFBOgWQI0G64sQO9hHjKg6MaSNFUExNdexMTjpMpsTx9uW6GIkvtr N20Dq/+/0zPRq/+f2PQ8yciBwk3/KLZVH0x1AVQFwB4Ot/atjKZ57LO/t7DKgPbdcFj6hkz+rNKUu aqWVS65lvdY6koEQaUQ8XMyCXvBlsyAH89bNzwMacu//nbf85G1mWNWaBA7MLxnGUvAbrgd7JeWDC eLTrRECwwa2J4EV/kvaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTXqh-00000006Amp-1caa; Sat, 27 Jan 2024 01:51:11 +0000 Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTXqe-00000006Alx-2cQm; Sat, 27 Jan 2024 01:51:08 +0000 Message-ID: Date: Fri, 26 Jan 2024 17:51:06 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/17] media: media-entity.h: Fix kerneldoc Content-Language: en-US To: Ricardo Ribalda , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Sakari Ailus , Laurent Pinchart , Hans Verkuil , Hans Verkuil , Kieran Bingham , Bin Liu , Ezequiel Garcia , Philipp Zabel , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , Andrzej Hajda , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> <20240126-gix-mtk-warnings-v1-3-eed7865fce18@chromium.org> From: Randy Dunlap In-Reply-To: <20240126-gix-mtk-warnings-v1-3-eed7865fce18@chromium.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/26/24 15:16, Ricardo Ribalda wrote: > The fields seems to be documented twice. > > Signed-off-by: Ricardo Ribalda > --- > include/media/media-entity.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 2b6cd343ee9e..c79176ed6299 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -337,10 +337,6 @@ enum media_entity_type { > * @info.dev: Contains device major and minor info. > * @info.dev.major: device node major, if the device is a devnode. > * @info.dev.minor: device node minor, if the device is a devnode. > - * @major: Devnode major number (zero if not applicable). Kept just > - * for backward compatibility. > - * @minor: Devnode minor number (zero if not applicable). Kept just > - * for backward compatibility. > * > * .. note:: > * > I'd say that this is correct based on https://patchwork.kernel.org/project/linux-media/patch/20231223050707.14091-1-rdunlap@infradead.org/ Hans, can you please explain this message from you, on 2024-Jan-22, that I cannot find in the media patchwork: Subject: [git:media_stage/master] media: media-entity.h: fix Excess kernel-doc description warnings This is an automatic generated email to let you know that the following patch were queued: Subject: media: media-entity.h: fix Excess kernel-doc description warnings Author: Randy Dunlap Date: Fri Dec 22 21:07:07 2023 -0800 Remove the @major: and @minor: lines to prevent the kernel-doc warnings: include/media/media-entity.h:376: warning: Excess struct member 'major' description in 'media_entity' include/media/media-entity.h:376: warning: Excess struct member 'minor' description in 'media_entity' Signed-off-by: Randy Dunlap Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil include/media/media-entity.h | 4 ---- 1 file changed, 4 deletions(-) --- diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 2b6cd343ee9e..c79176ed6299 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -337,10 +337,6 @@ enum media_entity_type { * @info.dev: Contains device major and minor info. * @info.dev.major: device node major, if the device is a devnode. * @info.dev.minor: device node minor, if the device is a devnode. - * @major: Devnode major number (zero if not applicable). Kept just - * for backward compatibility. - * @minor: Devnode minor number (zero if not applicable). Kept just - * for backward compatibility. * * .. note:: * Thanks. -- #Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel