From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B66EC7EE22 for ; Sun, 7 May 2023 07:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=luvMo5K7ysQ16TL7fd8X4B1mDBKb1ipGAiu8SmAiHg4=; b=vuj9k8UNkSM/Bb LhPoVMtVMYj4StFMGNzsoTdGLdx2VgUZ245jlPB+lqTKdvB8kPKNLTRlsKT2z/FG8J0o2KmVaP0bF FQYGVgiE05Opwl5pjwNzieH2QIhdyR4aPIDvGTvcfM3g5h2l8iFkHZXR7PJ8ZwDVDG7COV4QPWv5I F6vqY7/aHInuVcsdSk8uygPfmwpFiQICCez6b2ntOG+0HVss/iRr1HJrjIiMiNbeOJSMw26unnx75 PVAvQMjL38e+83hlKJTBMCSkgC4pZT0QMyW2sRRFyl5PIKh+9O1S8T4GdYanxYfr7rpRn4bdK8B1W 663haD6gddSrQWLzvqfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvZ28-00FRuP-1y; Sun, 07 May 2023 07:42:16 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvZ22-00FRsX-03 for linux-arm-kernel@lists.infradead.org; Sun, 07 May 2023 07:42:12 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-50b9ef67f35so6187823a12.2 for ; Sun, 07 May 2023 00:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683445325; x=1686037325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c7LsKf4hNT2P5PU2ttlrUN6/LYaDAzA948pWoMKox5c=; b=TX9CyL9LubB7HCIURG1+Ps8Dc78L8mIBTUrXGedjhosEQ9iGX02LHYszg9TadB6CIo 46yO19v0VUHLl0c2X3gChl153ImEt4S78UNNmTdjCtmq0Mg5eSwBpbOLhAupYxwkJKNJ oS/a/+Ed1XYEN2PJhetpM0ZjoYqIugG/vENX+nFzkLsJqi7FBL8rbcy6dSMMmtJpmjbN AJ5k5+eK/CYl7DJ6BZjPwSgPXGvHR58IALV+mBNX2Zw0OyvUEq6ps8Y1zwhXJCrbdS3F 7jbe5cLaSf2y9pzcu9lP/I2g6xCkmiZmmrQByTDD8u2loJ937K/2v512Zy+mKhzhRvjI XNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683445325; x=1686037325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c7LsKf4hNT2P5PU2ttlrUN6/LYaDAzA948pWoMKox5c=; b=KQhqPhAYcUW2sgDv61TzQ2ecaoA56VSjDNyxz66iMSxGTEJvWfTaAZ6mrwtS4gdOJE NflSKAa1Si6EbcxFrmXRpCHUrnIy7B9+PQtqaGE8wAHlI8tutAAi7iJIJG1I5HuculUF RNi2Zlh8zdKLfk7YgxuBXLEBnDcGH06QR/Kks5k0Rk63qxQGo2KsTrCazooKm7obeHQT ZyVRg0OfqrJdRbKEZLbNWyqVsmXvAukQaoHoP/+f+fmheVR9POeGWzai84SjWy6W0LV4 roGeeC8DCDH2yX0C//EcO6Z9vmJF3FOLUqFqLQtku3jpyzqiRdS725LWoRua/qxAKRj4 RdRA== X-Gm-Message-State: AC+VfDyjbWUkdc+UJTrLsB8es+OSh+dgCGXG6JKgfzbea0oJWSK0kf+E musJhn5cBwzKnmkRLniq+/GWQg== X-Google-Smtp-Source: ACHHUZ7nHVchL2fZ7oJnUcsF/P+oA4g2/9hI1INf/q09JsCXCI3jglN2cYEWYgHUD9C7ig0v6LaKlQ== X-Received: by 2002:a17:907:36c1:b0:94e:e082:15b2 with SMTP id bj1-20020a17090736c100b0094ee08215b2mr5508501ejc.55.1683445324962; Sun, 07 May 2023 00:42:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:183b:950f:b4d5:135a? ([2a02:810d:15c0:828:183b:950f:b4d5:135a]) by smtp.gmail.com with ESMTPSA id j23-20020a170906051700b00960005e09a3sm3350111eja.61.2023.05.07.00.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 00:42:04 -0700 (PDT) Message-ID: Date: Sun, 7 May 2023 09:42:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/6] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI To: Maxim Kiselev Cc: Andre Przywara , Icenowy Zheng , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Cristian Ciocaltea , Heiko Stuebner , Maxime Ripard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20230506073018.1411583-1-bigunclemax@gmail.com> <20230506073018.1411583-2-bigunclemax@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230507_004210_153638_030D522A X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/05/2023 14:59, Maxim Kiselev wrote: >> Should this not be set up as a fallback compatible, per Samuel's >> suggestion here: > > Ok, I'll do it in the next version. > >> I wonder what is the difference of DBI compatible. You refer to "helper >> functions", which sounds like driver... do you mean some parts of SPI >> controller? > > According to the D1 datasheet the SPI_DBI controller uses the same > registers layout as the regular SPI0 controller. > But also it has an additional DBI mode functionality. Support for this > mode is not yet implemented. > So there is no difference between 'sun50i-r329-spi' and > 'sun50i-r329-spi-dbi' controllers types in the SPI driver. > > Maybe we should drop 'sun50i-r329-spi-dbi' compatible struct from here > https://lore.kernel.org/lkml/20230506073018.1411583-5-bigunclemax@gmail.com/ > for a while the DBI mode functionality will not be implemented? You need both compatibles, but keep DBI compatible with regular one. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel