public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Asahi Lina <lina@asahilina.net>
To: Jamie Cunliffe <Jamie.Cunliffe@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	rust-for-linux@vger.kernel.org
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	steve.capper@arm.com
Subject: Re: [PATCH 0/3] Rust enablement for AArch64
Date: Tue, 7 Mar 2023 18:32:20 +0900	[thread overview]
Message-ID: <e76cb3e8-3d29-1caa-588c-29686c536d37@asahilina.net> (raw)
In-Reply-To: <20230125163739.3798252-1-Jamie.Cunliffe@arm.com>

On 26/01/2023 01.37, Jamie Cunliffe wrote:
> The first patch is from Miguel's tree to enable Rust support for
> AArch64. This has been tested with the Rust samples, and the generated
> code has also been manually inspected.
> 
> The second patch enables the PAC ret and BTI options in the Rust build
> flags to match the options that are used when building C.
> 
> The third patch disables the neon and fp target features to avoid fp &
> simd registers. The use of fp-armv8 will cause a warning from rustc
> about an unknown feature that is specified. The target feature is
> still passed through to LLVM, this behaviour is documented as part of
> the warning. This will be fixed in a future version of the rustc
> toolchain. This pull request should address it,
> https://github.com/rust-lang/rust/pull/107294
> 
> 
> Jamie Cunliffe (2):
>   arm64: rust: Enable PAC support for Rust.
>   arm64: rust: Disable neon and fp target features.
> 
> Miguel Ojeda (1):
>   arm64: rust: Enable Rust support for AArch64
> 
>  Documentation/rust/arch-support.rst |  1 +
>  arch/arm64/Kconfig                  |  1 +
>  arch/arm64/Makefile                 |  4 ++++
>  scripts/generate_rust_target.rs     | 13 ++++++++++++-
>  4 files changed, 18 insertions(+), 1 deletion(-)
> 

Just as a note, we ran into an issue with this patchset. There is a
missing `BINDGEN_TARGET_arm64` in rust/Makefile (around line 255).
Without that, bindgen fails.

 # Derived from `scripts/Makefile.clang`.
 BINDGEN_TARGET_x86     := x86_64-linux-gnu
+BINDGEN_TARGET_arm64   := aarch64-linux-gnu
 BINDGEN_TARGET         := $(BINDGEN_TARGET_$(SRCARCH))

(No need to credit us for that ^^)

Thanks!
~~ Lina

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-07  9:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 16:37 [PATCH 0/3] Rust enablement for AArch64 Jamie Cunliffe
2023-01-25 16:37 ` [PATCH 1/3] arm64: rust: Enable Rust support " Jamie Cunliffe
2023-01-25 19:50   ` Vincenzo Palazzo
2023-01-25 19:56   ` Vincenzo Palazzo
2023-01-26 16:35   ` Will Deacon
2023-01-26 17:56     ` Miguel Ojeda
2023-01-31 16:19       ` Will Deacon
2023-01-31 16:49         ` Björn Roy Baron
2023-01-31 18:55         ` Miguel Ojeda
2023-04-18 15:06           ` Jamie Cunliffe
2023-01-27 14:09   ` Gary Guo
2023-05-02 13:41   ` Asahi Lina
2023-01-25 16:37 ` [PATCH 2/3] arm64: rust: Enable PAC support for Rust Jamie Cunliffe
2023-01-25 19:54   ` Vincenzo Palazzo
2023-01-25 16:37 ` [PATCH 3/3] arm64: rust: Disable neon and fp target features Jamie Cunliffe
2023-01-25 17:49   ` Miguel Ojeda
2023-01-25 19:55   ` Vincenzo Palazzo
2023-01-26 16:37   ` Will Deacon
2023-01-25 18:01 ` [PATCH 0/3] Rust enablement for AArch64 Miguel Ojeda
2023-03-07  9:32 ` Asahi Lina [this message]
2023-03-07 12:17   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e76cb3e8-3d29-1caa-588c-29686c536d37@asahilina.net \
    --to=lina@asahilina.net \
    --cc=Jamie.Cunliffe@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=steve.capper@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox