Re: [PATCH 06/10] dt-bindings: mfd: syscon: Add Cvitek CV18xx rtcsys core and ctrl compatible

[Alexander Sverdlin <alexander.sverdlin@gmail.com>]

Hi Krzysztof!

On Mon, 2025-02-10 at 09:48 +0100, Krzysztof Kozlowski wrote:
> On 09/02/2025 23:06, Alexander Sverdlin wrote:
> > These syscon blocks will be used for CV18xx reset driver.
> 
> 
> No, implement proper reset block instead of abusing syscon.

I don't think it's an abuse... You need to look into the corresponding TRM [1].

4 bits I need to tweak (and one magic number into unlock register) are randomly
placed at random memory adresses and otherwise adjacent bits have random
unrelated functions from random unrelated subsystems.
If it's not syscon, I don't know what it is.

It has a reset HW block, as you and Inochi have correctly pointed out, for other
purposes, for resetting the SoC IP blocks. The overall SoC reset is complete
mamba jamba.

I was thinking now about a syscon driver, which will register_restart_handler()...

Inochi, do you have more insights into it? You've mentioned RTC and 8051...
Looking into TRM I don't get it, why a thing blessed to do all the housekeeping
(and called "System Controller" in imx8, for instance) happen to have RTC_ prefix...
Would RTC subsystem maintainer be happy with a monster driver which has ties
to all other subsystems?

[1] https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf
("rtc_ctrl_unlockkey", "rtc_ctrl0", "RTC_EN_WARM_RST_REQ", "RTC_EN_PWR_CYC_REQ").

-- 
Alexander Sverdlin.