From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9C14CCF9E3 for ; Mon, 10 Nov 2025 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UvdaQiXCxjFQh2GbC8svdb8+Ty/VpPxF16kIVDW7X8k=; b=bHKYzjZGYcJuVpekm8pGGRwBWJ NsDsZr31mRrdu+3UmyUVcbVHmiQqRxJAuUUF9nz+gY85SEz/3Jfhx6I/hvDVYlgDPM1r59MA5W8jp aVxq0SdhneN87uiL/BBVv71q3jSekqheS7mpMmzOZYrt2uI8U5mjBPvksh1uExSq5APcg0W19FfZt u/ANRxH5C+mhSScoVH4wTRtQOKntwdBmqfCjrJjq42TaiH+R8sEJV1mJr/tMyleos1p8fv95kw6Vt 6UzISFflfFki/0XdmsEF2tz6Ov7ZU+eLrs9eYKCBPIKcbQQ7rnje9EngGz09oNx/+WRsYMUHcCWAo tmRSOFlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vISc1-00000005YS8-0Id6; Mon, 10 Nov 2025 14:11:17 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vISbw-00000005YRc-41S4; Mon, 10 Nov 2025 14:11:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1762783872; x=1794319872; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=48QFvVDn/gQXwmUmio9XPnllOgtcyyXloU9GmXy3GXQ=; b=ZDg5Zht+M3uHdI+rvTKQCzVxGrvRJfv/4snLp1f1vynfLGFEDXDUeWMZ FomnT5jVzOpPsaqMhxCmh2C9BOmimeTnofE7YGJQgeaSsjL0gVD/TsHm4 ndTw8WtpVGga9Yk9ulVzcUyrwcCtpWfmwdfiLxGNGvO9SkhEAG2wCgZDU aiuSJv1eQHd+3mX+aYi5mCVwpXisEmJaK6nQahyk4xLCARY5SEyBidq4l HF7g5In6E5xPuzE5gUZPZtA50x4DLacBXs2iwGQAAfZPhjjyQ7VgmsY39 XQv+qi6y2S+efKI/a6iXHHuah+9iEUclhUC8iSA3U4tKOtDRsGFxul9Sz w==; X-CSE-ConnectionGUID: 7jHQAg5DRaCcnmeaPG7SRg== X-CSE-MsgGUID: cZ/bQKkfRpi6h9O940oGMw== X-IronPort-AV: E=Sophos;i="6.19,293,1754982000"; d="scan'208";a="280277302" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2025 07:11:09 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.87.151) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Mon, 10 Nov 2025 07:10:29 -0700 Received: from [10.159.245.205] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Mon, 10 Nov 2025 07:10:23 -0700 Message-ID: Date: Mon, 10 Nov 2025 15:10:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/13] irqchip/atmel-aic: Simplify with of_machine_get_match_data() To: Krzysztof Kozlowski , Rob Herring , Saravana Kannan , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Lorenzo Pieralisi , Daniel Lezcano , Bjorn Andersson , Konrad Dybcio , Thomas Gleixner , Alexandre Belloni , Claudiu Beznea , Maximilian Luz , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Daniel Lezcano , Thierry Reding , Jonathan Hunter CC: , , , , , , , , References: <20251106-b4-of-match-matchine-data-v1-0-d780ea1780c2@linaro.org> <20251106-b4-of-match-matchine-data-v1-8-d780ea1780c2@linaro.org> From: Nicolas Ferre Content-Language: en-US, fr Organization: microchip In-Reply-To: <20251106-b4-of-match-matchine-data-v1-8-d780ea1780c2@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251110_061113_142792_737434E8 X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/11/2025 at 20:07, Krzysztof Kozlowski wrote: > Replace open-coded getting root OF node, matching against it and getting > the match data with new of_machine_get_match_data() helper. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Nicolas Ferre Thanks Krzysztof, best regards, Nicolas > --- > > Depends on the first OF patch. > --- > drivers/irqchip/irq-atmel-aic-common.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c > index 3cad30a40c19..e68853815c7a 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.c > +++ b/drivers/irqchip/irq-atmel-aic-common.c > @@ -187,20 +187,11 @@ void __init aic_common_rtt_irq_fixup(void) > > static void __init aic_common_irq_fixup(const struct of_device_id *matches) > { > - struct device_node *root = of_find_node_by_path("/"); > - const struct of_device_id *match; > + void (*fixup)(void); > > - if (!root) > - return; > - > - match = of_match_node(matches, root); > - > - if (match) { > - void (*fixup)(void) = match->data; > + fixup = of_machine_get_match_data(matches); > + if (fixup) > fixup(); > - } > - > - of_node_put(root); > } > > struct irq_domain *__init aic_common_of_init(struct device_node *node, > > -- > 2.48.1 >