From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E29FCC3DA5D for ; Fri, 19 Jul 2024 21:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pxURwrQjaWVMnPupTe3e2QhQiBnQCCXPKt1vU7CQERU=; b=U7tJfU60YJO/QmmXMxlYf+xj0c Mu3f/Uqe/a6TnfU97tVM8ctkXyNIBMNJh3wAVq9suMaYO/LP5phr2cHuCAIbkNh6YRixHK6I7q+pl U+kzhlRpVAiOaQqQRlxSLO+/YEs+pRQ2QBIVfkwNetuagvCMouyPHWal+oGqKV6jxhqRyVRDsgUuj TP2PHYqYHOaGULQo2SJI7jCPdQI9Uir2IpLuKTaiySbhdT4xsaViiY9bkrEc4En2o1hU1GEIKyL20 mlEbustW23mpK51dqu+AKkmheC3kc2w7gVC88pcRQfTfo4z8aUz8HQX6qreM+btfqujI6SFXGRF+Y Z10hiz4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUvKx-00000003qRE-2LFW; Fri, 19 Jul 2024 21:40:23 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUvKb-00000003qLc-2EQ3 for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 21:40:03 +0000 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-70445bb3811so1268358a34.1 for ; Fri, 19 Jul 2024 14:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1721425198; x=1722029998; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pxURwrQjaWVMnPupTe3e2QhQiBnQCCXPKt1vU7CQERU=; b=T/J15ZP7Jq1YkDF0jC2RebjgdsfCPQ+ZJ2zkBHJTIeX98Vg6OYX7XyPr5kECwC7WNo jMJ3eHf76JRb2uUIi2Ok+mdD4MzbRcBygCMcKx2+D+2rPcR/7A3ylZWIiB1NkNByOmqr ITibmyKXyYTTglun95gVWSeXQwJ4BWT9EUjjU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721425198; x=1722029998; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pxURwrQjaWVMnPupTe3e2QhQiBnQCCXPKt1vU7CQERU=; b=w578ze/gm0cCp3UoTFvokvU0qV+TkMb83wwiq4vie+Z4cEz5xXVUPrrbRzxVsHJVG5 DUK1ihUdSlwhpakc4o2imFBwbVRZ6XRxqaBYSN8Lw2SHgzN55uf94dLgKeLvvnBNtblr IKI/muKtHMQW/rC8rG2qmMBZk1moTwMVa6/uOLiky0CZnfGoZzOUrEWlzs4+unQMl7V1 UH6iPJVP0l0TBsj5LJnbpSOumIn9PYqfUMgUnEWKVBHpZcWVAfpmfkFDf/v3u3Jb+/uB luLGQDos1IKEXaAgbaXXVfEscUHWkbiVUt4fvX2mprGg/WYWDDjtd2UTN5QncKIqxyG5 zAPw== X-Forwarded-Encrypted: i=1; AJvYcCV2TJ7rPXbE5g7PF9/0BwY2s/PCxpgpD295hUw8jc8BwmBBHkfJ0SfPG059szQb54kytSAJhkjmCO9rkyoknocAnEWbxzR2Z8VgvP9CfjJL0UGhf8w= X-Gm-Message-State: AOJu0Yx6XZHHT3TAhLtcgoVVjNJU5wd7KYVpa/QURyMzeXaj2I4XOdEE PS1a/ZxoEIJx2FOZkpS606EeWnE0EtcdZn06OYpl1T/NjCiDV55//bmDEr20jw== X-Google-Smtp-Source: AGHT+IE74f2iNObwpJtxfcq8M2viSwuF/AsMKv4hekSdNy/d0euPZyuEg0mshxbk4LRUVX4+1T2w8Q== X-Received: by 2002:a05:6830:418e:b0:703:7786:edab with SMTP id 46e09a7af769-708e379aa81mr11905980a34.4.1721425198123; Fri, 19 Jul 2024 14:39:58 -0700 (PDT) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-708f6189bd5sm460642a34.65.2024.07.19.14.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 14:39:57 -0700 (PDT) Message-ID: Date: Fri, 19 Jul 2024 16:39:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] greybus: gb-beagleplay: Add firmware upload API To: Andrew Lunn , Hariprasad Kelam Cc: Ayush Singh , jkridner@beagleboard.org, robertcnelson@beagleboard.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240719-beagleplay_fw_upgrade-v1-0-8664d4513252@beagleboard.org> <20240719-beagleplay_fw_upgrade-v1-3-8664d4513252@beagleboard.org> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_144001_608694_B3EC2178 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/19/24 2:15 PM, Andrew Lunn wrote: >>> drivers/greybus/Kconfig | 1 + >>> drivers/greybus/gb-beagleplay.c | 625 +++++++++++++++++++++++++++++++++++++++- > >>> +static u8 csum8(const u8 *data, size_t size, u8 base) >>> +{ >>> + size_t i; >>> + u8 sum = base; >> follow reverse x-mas tree > > Since this is not networking, even thought it was posted to the netdev > list, this comment might not be correct. I had a quick look at some > greybus code and reverse x-mas tree is not strictly used. > > Please see what the Graybus Maintainers say. Andrew is correct. The Greybus code does not strictly follow the "reverse christmas tree" convention, so there is no need to do that here. Please understand that, while checkpatch.pl offers good and well-intentioned advice, not everything it warns about must be fixed, and in some cases it suggests things certain maintainers don't agree with. -Alex > Andrew