From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AC17CCFA04 for ; Tue, 4 Nov 2025 08:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:From:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Fu9AdCheOvxz3Im1FXmK3GvN5Xitn31VIJ6mONdECE=; b=iugHH4gfXR+rGl92+1C/jRg7mu vpQ+wtO2Wq7SBgHV8vSe5ZcwamM2WABurpMGVjsUBgDE6yiF94hXdACRvm2Ug0gH0MMkHx8wl7Vdd oJUZknvbQSY2ctjCbJYPiBMfMDr0WtX6JGIWyia+KUBCvPTiA/cxx/oP4r7kxshSw7ZvWYTKSwZ7H 4p4XPXdXqXRioviiV2oNDKzqplAn5YYcNotf4eXKPT1Ncx3Z2jZzapnXU3QRnVB3HAlV0RmsSxKk/ rWaCerZPeBKeOe9QSDyP/2Yjm4m3is793oOnZk1X164v9OZVpEx4GuGs/b/PzniqNT60JU56dkc5d 0e8bJHlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGCes-0000000BSEM-0NR5; Tue, 04 Nov 2025 08:44:54 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGCen-0000000BSDb-3niZ for linux-arm-kernel@lists.infradead.org; Tue, 04 Nov 2025 08:44:52 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20251104084442euoutp0102088d40135302607f87347b0dc37851~0wUsqg9XY0417804178euoutp01G; Tue, 4 Nov 2025 08:44:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20251104084442euoutp0102088d40135302607f87347b0dc37851~0wUsqg9XY0417804178euoutp01G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1762245882; bh=4Fu9AdCheOvxz3Im1FXmK3GvN5Xitn31VIJ6mONdECE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=NIfzfLaKbrHZu0Gnes91/bNFpnUi+PCBujRxqfn1+x6PF4bWcGMTESoPuAVb8BCNe TtlBUOWDuOkNSnmVQ30DXStAE0ZC8Og/doIluRR7N6u64puk7uGLaCr147tEyKOLdV mk1n6uHGDW++q0sGM+SWQUfE/wNIAUBaBoIJ+ACU= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20251104084442eucas1p2af1bd88393f4d6a532df1cd41f32a287~0wUr8pCub0922509225eucas1p2b; Tue, 4 Nov 2025 08:44:42 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20251104084440eusmtip27dfa57d3ff654ed50f16a811242c3a65~0wUqFptgI2591225912eusmtip2U; Tue, 4 Nov 2025 08:44:39 +0000 (GMT) Message-ID: Date: Tue, 4 Nov 2025 09:44:38 +0100 MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH v4 23/35] vdso/datastore: Map pages through struct page To: Mark Brown , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Arnd Bergmann , "David S. Miller" , Andreas Larsson , Nick Alcock , John Stultz , Stephen Boyd , John Paul Adrian Glaubitz , Shuah Khan , Catalin Marinas , Will Deacon , Theodore Ts'o , "Jason A. Donenfeld" , Russell King , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Nagarathnam Muthusamy , Shannon Nelson , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, Aishwarya.TCV@arm.com Content-Language: en-US From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 8bit X-CMS-MailID: 20251104084442eucas1p2af1bd88393f4d6a532df1cd41f32a287 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20251104084442eucas1p2af1bd88393f4d6a532df1cd41f32a287 X-EPHeader: CA X-CMS-RootMailID: 20251104084442eucas1p2af1bd88393f4d6a532df1cd41f32a287 References: <20251014-vdso-sparc64-generic-2-v4-0-e0607bf49dea@linutronix.de> <20251014-vdso-sparc64-generic-2-v4-23-e0607bf49dea@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251104_004450_516608_9D0EB106 X-CRM114-Status: GOOD ( 28.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03.11.2025 16:24, Mark Brown wrote: > On Tue, Oct 14, 2025 at 08:49:09AM +0200, Thomas Weißschuh wrote: > >> An upcoming change will allocate the datapages dynamically instead of as >> part of the kernel image. Such pages can only be mapped through >> 'struct page' and not through PFNs. > I'm seeing some boot failures on some arm64 platforms in -next which are > bisecting to this patch in -next. Unfortunately the diagnostics aren't > super useful, we seem to just stop making progress in userspace with no > obvious output. One sample log from the FVP is: > > https://lava.sirena.org.uk/scheduler/job/2036229#L1268 > > which isn't super instructive. Not all platforms seem to be affected, > I've seen this on at least the Arm FVP, Orion O6 and Libretech Renegade > Elite. The diagnostics aren't very clear here but given that I'm seeing > the same issue and bisect result on multiple platforms it seemed worth > mentioning. Some platforms do seem fine. > > We do have some other serious breakage affecting arm64 in -next which > are making it hard to get a clear picture of which platforms are > affected, at least the FVP and O6 are unaffected by those other issues > (due to using MTE on platforms that don't have it, those platforms do > have MTE). I got almost the same result while bisecting on ARM 32bit Exynos-based boards, so the issue with this patchset is not fully ARM64 specific. For some reasons it also doesn't affect all systems though. It is even worse, because it affected only a subset of boards, but different for each tested commit. The observed failure looks exactly the same: ... [   10.199852] devtmpfs: mounted [   10.205013] Freeing unused kernel image (initmem) memory: 1024K [   10.210086] Run /sbin/init as init process INIT: version 2.88 booting (no more messages) The only difference is that bisecting on ARM32bit lead me to the next patch (10d91dac2ea5 ("vdso/datastore: Allocate data pages dynamically") / [PATCH v4 24/35]). Then I've tested it on ARM64bit (RaspberrryPi3b+ board) and got the following panic on 6a011a228293 ("vdso/datastore: Map pages through struct page") commit: VFS: Mounted root (ext4 filesystem) on device 179:3. Trying to move old root to /initrd ... okay devtmpfs: mounted Freeing unused kernel memory: 12672K Run /sbin/init as init process Unable to handle kernel paging request at virtual address ffffffffc20b5d48 Mem abort info: ESR = 0x0000000096000006 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x06: level 2 translation fault Data abort info: ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 swapper pgtable: 4k pages, 48-bit VAs, pgdp=000000000230b000 [ffffffffc20b5d48] pgd=0000000000000000, p4d=0000000003618403, pud=0000000003619403, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] SMP Modules linked in: CPU: 2 UID: 0 PID: 1 Comm: init Tainted: G W 6.18.0-rc1+ #16136 PREEMPT Tainted: [W]=WARN Hardware name: Raspberry Pi 3 Model B (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : vvar_fault+0x7c/0x17c lr : vvar_fault+0x24/0x17c ... Call trace: vvar_fault+0x7c/0x17c (P) special_mapping_fault+0x24/0xd0 __do_fault+0x3c/0x238 __handle_mm_fault+0xaa0/0x19e0 handle_mm_fault+0xcc/0x384 do_page_fault+0x1a0/0x720 do_translation_fault+0x60/0x6c do_mem_abort+0x44/0x94 el0_da+0x54/0x230 el0t_64_sync_handler+0xd0/0xe4 el0t_64_sync+0x198/0x19c Code: f2d83fe0 8b010063 d34cfc63 8b031803 (f9400461) ---[ end trace 0000000000000000 ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b SMP: stopping secondary CPUs Kernel Offset: disabled CPU features: 0x000000,00180000,40004000,0400421b Memory Limit: none ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- Reverting "clocksource: Remove ARCH_CLOCKSOURCE_DATA", "vdso/datastore: Allocate data pages dynamically" and "vdso/datastore: Map pages through struct page" on top of linux-next fixes booting on all tested boards. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland