From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B103FCD1292 for ; Thu, 4 Apr 2024 10:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Sbw9BMbSMjdQ9W8o67QYoJUx9izWw2mwQlN2q9wFHQ=; b=owqzjdC7Uqz1lV VhtsLVUO65cz66WQxI3WLgtBgFLTpz42tFBabRNOP2fdoXRskcviOmc00svW8o35hmWstGbgZllcG uRRa+2ptXfbqzTPq/XPPh4569dC9O4oKY59ppbCV6BHPLfJ8H/kRwj/3u8w2E5h/akJeoucdE36+a uNmz4mkOmfkQTROGCMiMYA4kkTWVbLOx3ZR09uDsW7jbAaSAaSPkIBpiGa96hK0bGizNHiWGIzb6q i9gnSSw1+wrL0Lczl/NyXborVLMyIHKYwChmhQZ4bjKJXLrYzm5qDYmkQTxzaGtBLWdYN7KvcVWMM WGyNYwZ3dmtFjqsyt+FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsKO4-00000002BX4-1fAC; Thu, 04 Apr 2024 10:32:04 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsKO1-00000002BVH-32xD for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 10:32:03 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a46a7208eedso118290366b.0 for ; Thu, 04 Apr 2024 03:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712226710; x=1712831510; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ejfPUiMbZ+VXCFA0N0LIaJrBvhVfb3UObLj4vbm6hQ4=; b=ebMO3sSh0h7IeCwCgLkkzn4l30T7Ycq7cRFgnxjS5NAM/qmcdCwf08PGV+WGoas8HX pNTZqeQ71QvwyATSb6uslRW0KagJiu7wlqUkAHK5FiIaSVD4BT6qAr4ret7UQJcFPDSA d6AtzxNP2k4R7fwtlL/Kp543rQD/mkmAIuQ1ldjPfsIpDHNsim+sJDBOC30auxNikshV /UoeNqzNSKvw9HJUjd11Pw+Z+tHqNct2InDQYNwIChiKcS+jz61NiTy4DUa+4iMx9RBJ QBvuMtkviLMRN/zv80FjFeyMhGB0JRtwtJfDNI7vGRVvukNTVFbTxt0AqGI+6cvp2UPL vUbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712226710; x=1712831510; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ejfPUiMbZ+VXCFA0N0LIaJrBvhVfb3UObLj4vbm6hQ4=; b=R0rYo3K5OKdnVU7+Se3LUV+0DmySm0RA95asp3z+kLDzxJT66gCTI3Nhjdqogow4Vl dos4G8UEGHf8qPSVwCiJooJw99znKQ7YmKD3aZ7RzvLrQdy82ZwphYHUYUYVxhn4SBFZ RuXBH9OoFQ+M+bT4WU0SoaOr/0leQ6fgc55QOs7xb2e8nwTawFMpxX/1qF6w4CMD1uVP gEVVNDapuYMYeoV53864lkBnIAVEz4Gw4IeAh5+nuSuhYV5U/lpUtiz6p+hg2HsL0A8f JnsdKzunVmv5b5luyI7Ra+BMRE5ORFVndVbLyuTQWmUxvtqjF/pjSadzUaaYOQVVldUB Z/Qw== X-Forwarded-Encrypted: i=1; AJvYcCW0hmuJXayEMVbXDeyfE/BiThW8MhDvTFE3SQfQ414soTvmOnzhjTJ2etIEpaKclQQz5327FDkdPi7CThAxppF04TLrBexwy3UZ81DE+KdK1i5kSFA= X-Gm-Message-State: AOJu0YwgcChuZJ7z4gaPB5vThQ0P7gQazzEzpAljHIt5ayAQdp2BxJpI pMhCmd4HmukdW7d4Mwd+ERth/srH+dI0PZpoHPUCfDNY26qBRnZ3M+VxurYutsVDLi0Lmmm+II/ Z X-Google-Smtp-Source: AGHT+IGf+SuhD4QMbKzZLyX+b2w938/WHZgqqWnUuEVC+eYR9iyY5YI6eNyEfU0L9ojnOZ5u+08JLg== X-Received: by 2002:a17:906:1999:b0:a51:9149:29d2 with SMTP id g25-20020a170906199900b00a51914929d2mr469709ejd.6.1712226709906; Thu, 04 Apr 2024 03:31:49 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id g4-20020a17090669c400b00a4673706b4dsm8899480ejs.78.2024.04.04.03.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 03:31:49 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 12:31:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: ti: k3-am62p: use eFuse MAC Address for CPSW3G Port 1 To: Siddharth Vadapalli Cc: afd@ti.com, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com References: <20240404081845.622707-1-s-vadapalli@ti.com> <18eb0e55-38ad-44f9-90b7-1917d8c0d5bb@linaro.org> <75b53dda-23aa-4915-944a-4d9a619bd165@ti.com> <903ad855-ab26-4ef3-80bd-249917056188@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_033201_824376_00EE7D66 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/04/2024 12:16, Siddharth Vadapalli wrote: >>> I was following the convention that other mfd-syscon compatible nodes >>> seemed to be using: >>> https://github.com/torvalds/linux/blob/41bccc98fb7931d63d03f326a746ac4d429c1dd3/arch/arm64/boot/dts/ti/k3-am65-main.dtsi#L502 >>> The node is: >>> dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 >>> corresponding to the compatible: >>> "ti,am654-dss-oldi-io-ctrl" >>> which was added by commit: >>> https://github.com/torvalds/linux/commit/cb523495ee2a5938fbdd30b8a35094d386c55c12 >> >> So if that one was wrong, then what? I don't know really what type of >> device is it, but just because one contributor called it that way, does >> not mean you should keep going. Maybe investigate why that contributor >> did not decide to follow Devicetree spec recommendation? > > Yes, it doesn't justify the convention. I seem to have picked a wrong > example when figuring out the convention for naming the node. I plan to > name it as: > ethernet-mac-efuse > while retaining the label "cpsw_mac_efuse" since CPSW is the name of the > Ethernet Switch on the SoC. Please let me know if it is acceptable. I > will post the v3 patch based on your feedback. Label is fine, there is no restriction/guideline on labels, so choose descriptive or something useful for you. Just the node name. If this is syscon, then usually system-controller. If this is efuse, then maybe efuse, even though previously I was looking at this more as a syscon. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel