From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B409C25B6B for ; Thu, 26 Oct 2023 06:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uqa5shp3a182xTQgLErTB1lmjtZyHMcmUSj15IXIWts=; b=kaWkwSRy96arIj zKvP6pvzaYTUpzAjQSI89ELzZQNLalfTViZZKReh7uiIszsjlmAERWc009howSQWXR6DFAbguUeiF JxD9DMjIFHvYD8bX/dO1CJUGh/5A/RCZcTiCeV8lvPMpxvLSiRbR2U1R8bNmwPxpLIzuHFzYuLhVC JvoYlP0D40tI6Z+k9lelEOFYnAg4uQ5vkRhQwpmFu3xdLLjWVsczXWKCiRJjFszT/aF0XNyMKOK9g QFlC72enQKpK8/+J7DxNyFixL9rhsQc8F/LzUkkn3QRKqv0iC2xDXNHcxwzsjP9T0YhEkkNTq1Qlr IIXXodwmmKiiX4BYpvtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvu9Y-00DnGK-02; Thu, 26 Oct 2023 06:47:36 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvu9U-00DnFW-1l for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 06:47:34 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 39Q6lLEP103335; Thu, 26 Oct 2023 01:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1698302841; bh=/vlzh3Yc/MucFOUR1SOQLgHkbnNGyX3rEQeGRfo0TiQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=UtbE3rnCXfJF2e4QegRDfHH4myXrP4lORPqqf4UxgmlU2J52OY9v8U8Iz2mf5Tssy y/0oo3tnhTe6sDMHJhTftjYZ8Q98olP1KMPcrDnd5LDamDScLDoUdPalVJ+qYiN3Rv O6D7jA+cfvkJSr4Sepz7cLBD/VeqXw/rR0gICCWs= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 39Q6lLCd007285 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Oct 2023 01:47:21 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 26 Oct 2023 01:47:21 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 26 Oct 2023 01:47:21 -0500 Received: from [10.24.69.29] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 39Q6lH6Q006204; Thu, 26 Oct 2023 01:47:18 -0500 Message-ID: Date: Thu, 26 Oct 2023 12:17:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes. Content-Language: en-US To: Nishanth Menon CC: , , , , , , , References: <20231025110252.1089979-1-n-yadav@ti.com> <20231025155743.nk7un6pvib7swtxg@decorator> From: Nitin Yadav In-Reply-To: <20231025155743.nk7un6pvib7swtxg@decorator> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_234732_663610_D470A4E3 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/10/23 21:27, Nishanth Menon wrote: > On 16:32-20231025, Nitin Yadav wrote: >> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according >> to AM62a SK datasheet. The Link of datasheet is in the following line: > > SK? line? > > Please rephrase above and just mention the section of the data sheet to > refer to. > >> >> https://www.ti.com/lit/gpn/am62a3 >> >> Section: 6.3.10 GPIO (Page No. 52-55) > >> >> Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' > > What is the single quote for? > Also note the additional comment in the list to drop the extra EoL. > > > Did you check the MCU and WKUP GPIO count as well? if there are bugs > around it, fix it in a single commit please. yes, checked they are good. > >> >> Signed-off-by: Nitin Yadav >> --- >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> index 3198af08fb9f..de36abb243f1 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { >> <193>, <194>, <195>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <87>; >> + ti,ngpio = <92>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 77 0>; >> @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { >> <183>, <184>, <185>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <88>; >> + ti,ngpio = <52>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 78 0>; >> -- >> 2.25.1 >> > -- Regards, Nitin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel