From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D27C433B4 for ; Tue, 6 Apr 2021 10:13:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0C6761279 for ; Tue, 6 Apr 2021 10:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0C6761279 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vpQ4EgTm8Iu1uRTawLHFChF4oEdBgT1pUwYOXxHx/bI=; b=SrY13c18FAVOD4WYPdKivpojO pMio/h0FBtuJQyK1WdA8xcgGXDLsKW30DA7qjdZOVICH/dsKM3R2eAeMT83iaa1VO3JUDj8DHz+Y/ dp21r020ebk7Mhd5MExa13HXqDPWW2N/WROcFZiGzsO/2F39zHNXHBVd0zlg7XP8rX6kYm1OCgX4N k4NWGZ7d41G3BmfqjeOya/zq/m90Zwg+OOgRYcSLWnclQ8ydolQfuaudPBqCGrR/lqYhmZVf9Ce5L chbXdBSVsjdmItPeBiiE7ugmJaoV1Aa1rK7hrbt3HEFJzo04Mk9Hv5PSEVPMnf6j9JUfGZ9RD/BAf vbhZAFi0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTigo-00282O-TQ; Tue, 06 Apr 2021 10:12:07 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTigg-002803-2F for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 10:12:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617703918; x=1649239918; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=QHeh4aDKWHU1FX1EG4pgOrKB2WXgGIU9KkJ44/oni2U=; b=zzPyxL4FqRlfK5oSlys3zQdSbkRyp++RI40p1FvSOoGnMNdRPwvOwMea 8yRHSNy2Yr56syxXSsqJJE7O/90MTnZZxGB+VrsKMk3UxusQAboQbIqnT /So//HVKID2bQsyoEDengBgjn8Eio26inHrhiIyxfGC9I6WwAjFh2MN4K a4R4qf9jg1gkWBFLr9tAAWuOhSLTPsIYrL7TnqM7bvzmleesnintcUbuQ xrOT4mzzE0mGGIlQOcfHBgA96ob5IydUT5a2vnc6/1wBItywGpcCEPPEk LLHzgnQMpHaSufvrqU0Y0vUsmm2tpexc5VzS9vjfPlVst2iOgJHs72X4a w==; IronPort-SDR: oLqUCD1F5AQrTbGamjpwllw75D9wbl0eUAxfueIJDmyqaChXE6QorY5De8LYoLwrXEsOv3Hhoi skAGkzEVkbMVT8wGWHi16r8oFCEeAhV8yT/cfPGJsS+kwuTaHk1MG4JO+ZYelwWKz33jQulgQm /FkOgAgxF+yE3ubwAMzF3YdpsYwguD3xqc0MMgxKR6AOJAHGM3qbhqj4w5hzwWjl0mj8Mu5aU9 rVjnu10e0NLJ+ZNGZDw1KilsVm8phJG4ZSSG/yJnuKwO4zbCqUbXX8Wpie//KbJNsfFO593nKw lUo= X-IronPort-AV: E=Sophos;i="5.81,309,1610434800"; d="scan'208";a="112584352" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 06 Apr 2021 03:11:56 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 6 Apr 2021 03:11:55 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2 via Frontend Transport; Tue, 6 Apr 2021 03:11:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i2rkQwhijRS+7tbNYuPCzJJuT4qF8hpZBDG0nHAIr/zTwIF9NW4pNXontL1WGNpL8EnHWVtLhKrQ73vxmNFA77LGC9zjOwOsgQD/XP1ifbNYRK6ypPyycbxpmvlw3W13WGfZJ1DHkxZwDhoN05lg1jrh/WqUUBKI/NE0Dj6eztsdTDpDg2R6aEZH910Fj67qoBpX7VXmdbvXO+xSgv9pKMLvTqJqvziahPLNoj01mTlW1YW/mDPubbz0HPIYJdYDdnWd/ChDKEOooQyd0FcMqbIMCpCruWhfDcAzJ9RWvHbEI8oR7HIqrI7WZpejJuvJr1v5/sw+QjgaoATV1q2HLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHeh4aDKWHU1FX1EG4pgOrKB2WXgGIU9KkJ44/oni2U=; b=jk5jsHhUzMozeunPapHTiw87OKF19ps2OeMmPWpMILsRZpluyfqtQVqdhy6n8C3CPE3yVoFJiqBcErkSS01yOEO3AVeS9pqsYd4TVVbLSz+NinwPRej+8dRITDoRVDVA/3TnArJNrJGQqplxACFcMa9N1wxa4iVeDIOZCNqjIE9EJOJrW/Ec6fAYmzSDhVtDIqshbvubH7hLARlBH4AwrOSfQ7luR86v2AUDnFPOrBLKkwKHLM+a+iG99dEC0d9r2nX7l0Z/9T1dHXEzkGoenrxeQcTQJjGdIvSlQ8iS/BTvC+mSfZc4RPqt2TS9oCmgIUFl/RCMAV9BXhmM9qqehg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHeh4aDKWHU1FX1EG4pgOrKB2WXgGIU9KkJ44/oni2U=; b=nQbBqpO3k9YjbVyASf/irgWAW3Tj8vDUyEXBLRjYC3RIAChrWd1P0X7wui44ya2SQJc2vqqQwXhUs22aW/39Jx+BbvkYxaFfRZPDk32G8chPNRL4fXGSwKeOCyD/rGVBst4zocsGmzcyqkdt2BHg1ZK22VmP7jzYslwGLncJvfc= Received: from SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) by SN6PR11MB3197.namprd11.prod.outlook.com (2603:10b6:805:c5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 10:11:54 +0000 Received: from SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::49e5:8be7:95d:b6a9]) by SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::49e5:8be7:95d:b6a9%4]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 10:11:54 +0000 From: To: , , , CC: , , Subject: Re: [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() Thread-Topic: [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() Thread-Index: AQHXKs1EiBekPi/xUUuKDb6O6Sublw== Date: Tue, 6 Apr 2021 10:11:53 +0000 Message-ID: References: <20210406085043.32544-1-yuehaibing@huawei.com> In-Reply-To: <20210406085043.32544-1-yuehaibing@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [79.115.63.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2a6d5b6-999d-4bf6-a6dc-08d8f8e46734 x-ms-traffictypediagnostic: SN6PR11MB3197: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:200; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oxs+5P5ZIuIAhgv+klW5HrKQpDFpsFeCDBWEJFYdesCXLfwu8CkoV0gMsKKlYCQzNa6URmKaj3EMS1taMa/FFOjjzUuJ8rCIDjoabZUiAWQZzDAVP+V4WpOg0F3oAhRm5PUuUlEb3Dbvtc2rg/YmGtL7KGNP0Tp4ftARRNLqA2rYDpX2CY/Q2A3PW5BkCfczwgvyHgsDFOBGq2VsbaxmqhfkOVuhhLS1Ov1yNddXdRThXfjDxJ2UgsHKv5TLPiKTKsX8JSAeqgqimRwv5P6i+D4Z3bhW6opGCObqXp29I2qSQHgfJ28iKym7Lw1o4Ir1c0Z34gom55hFb9oQ89nR8cgzDXzqtD6dbzCe6rBCoI+H+I+5GYvri4v/Hf7AsuTdLBB38skcu+j59IrzWqGPUViVDNgub2cpy9zTSW5Dv/3cYZj0dmF/Sav0QaM3CFPWWi7VSb1qKXmPkdUhJ6c2HtUDc4gcVt5QqIW+Hdg3KNVAEV+12Fdkoy41Vxkmw8WGZu7S7IXJCLWopPGpwgTPC2cW+eRIwnqCaO+je9fl06Zpfa5fE3leBA2RZoX9oc/+s6mRqAyM5pgy+Y85qUeNpsi3Ha+ARc7Z300/9EbNw+o/m6cuKBQ1oex0EqrmXfqa6AdTnprZeGcwkzWBu2GfAGMhYTJjAxpgVZn1C6TOu8Xr0SU5vm5LTJa3upJ1PFuieNE8KOgjnbv/aFutrXzyfeeFcrDTaaKgElykWEDCZgs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4874.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(366004)(346002)(396003)(39850400004)(36756003)(6506007)(53546011)(8676002)(66476007)(64756008)(26005)(110136005)(66946007)(71200400001)(2906002)(186003)(6512007)(38100700001)(2616005)(66556008)(91956017)(6636002)(316002)(8936002)(4744005)(4326008)(5660300002)(66446008)(86362001)(31696002)(6486002)(76116006)(31686004)(478600001)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?STErLy9NRDRwck9Fa3dURk05RE4rNndUSWpyOUpOUkY3NHJFSUhvcFduT3Z6?= =?utf-8?B?SUhzUFBoTDc2NUxrbDJxS2RNYnpFeG9Vbjd1QzBMcVRpR3liM2podEZ1K3Bv?= =?utf-8?B?YnEva0VicUtMMDBZaDlITEsvSmlxRXJxNkVEWUJUQS8rd1JUekxBWGZPa052?= =?utf-8?B?MTRnVkpFV0xxTHVyai96dzBrVnRTdzF0VnlCTnY5T1QwMEZQUzZ5dUw5QXpo?= =?utf-8?B?SG04N1FrWVFtcXAxdnFtRzhCWG9CTFVUWWZXOHpBYkhmZVpDcjh1dGVWVkFM?= =?utf-8?B?NUtYN3JmS2dpRWNPZU9ZSllXaWs3RVlOY2hBTmoySHdRVjFJOTYzK2dteHNV?= =?utf-8?B?QmJQa0N6ZDZha1E3RFdTS0NvR052dkRNSXFiYk1uK2FBS0tCbHR0eklIL04y?= =?utf-8?B?QU9mUmJnZ0o0R1dVdUJ3SWY2c09uUlpiRmNUbGs2QkNFU1N3S2JnR0YwSlYx?= =?utf-8?B?Vy8vNU5sSlZkQWFRQkhJdWxhK3BlMG9ibi9rQ25SSEtPdkY0NkhYYUNKTE5Y?= =?utf-8?B?VVFEaUc1VENnd0lCdzVjdkdvZVhOaVZ3Y2NlMXJhT2lrVkdnZU5hREpURTdi?= =?utf-8?B?a0pRZ05nV1JEbXo1SDVEb1NMVGNPVHNwS2xrTlU1RUU1ZlpvcU8vT0FzR0hh?= =?utf-8?B?ZTRid2VIeGlYODdqaVJWM2diTHQ3Szl5N2ZnQUdPRmtBY0FiVUJZVzEwLzJm?= =?utf-8?B?UjU4L1lxWi9kVVNXblI3M0lpQ1pXZkRXMkdhWk1TMjBtRDNZSUJUd1dUYzZi?= =?utf-8?B?M3RPOWhaS09GL3U5UTQ4UHUvZlY2eXlMK09jamxySTMzOFRFNHJqUXExQ2tn?= =?utf-8?B?VjNNT1RlUU9ZOGJTYUJkMTI3d2xYTHpUNVg4bmVielZzaE1lNzhtMHlQK1kr?= =?utf-8?B?YWFuRkV5bmVINjZPRVlqTkd4T0J2eEVaU0tZdUdIUy9CbDNWK2hXQVBkbzZC?= =?utf-8?B?SFh5SHJHajUyZUVCY0tKNHE2bS9LQ0hnM0VWeWFrd1NkL21VOHdhOW5sYjZw?= =?utf-8?B?NWUzMmltRUtiQVlhR3Z5S3l5dVYyWHNhVmtHcmZjOWVGbnBuWWl2RUFUL3J4?= =?utf-8?B?SUpxUWgxWGoxRllYUmgvVlJQYTJEaVlOZFVnamF4TTBHcGE0Qm9IN0JBdG5T?= =?utf-8?B?bHdHWjJGaTgzTGU4ZWx6NUtLVmtFaU1qNnlzY0FFTS9FOEVnUjFZS2M2aXZs?= =?utf-8?B?Q1VzYmh2STJVNGFvL0hsSFVIbmo0TGNXNVBxOGUzVjRjNVJNOFBqSkpDSjh4?= =?utf-8?B?R3RBd3plZWhIR01uS1BMVUgrMHhyUzVFVXR3TUJKZTFoVG83dWQzM3hRbzRs?= =?utf-8?B?M3ZRdmM3VzFod3RhWEk1NFZZdkZJWjdLUnFLS0VoZC9nbmt0clptYjhWSnBk?= =?utf-8?B?eS8zU1NibExOTng4Zk1jaktlUVhZTUJBM3JnSkNIYUY3cG9zekJYSnVMcWRL?= =?utf-8?B?Q3pJdit0OXJHa0d1djBxeVNwbkFyRmFsY2ZRMG9SUkg3K0FDRXNIVFRlQnJW?= =?utf-8?B?bU5MY0xiY2xoN1lHZUJkVWdmdVNNVDNSOWw2NmMxYlZ6RzhhUzdzS2sydG0z?= =?utf-8?B?eFBzczlyWVZNaE90dVZHb044cUJvdThEaHdVL2xBazQ4ZTQwazJIRFpmRkI5?= =?utf-8?B?aGw5dldlMlEyNFp0SlRJWUFxaWlkUnhUYjliRm5Hd1NwaW9BaUMvcnI3L2Uy?= =?utf-8?B?ZW1DelU0MmY3Z1BDTHVDTGZmaG95YVFINjV2WU01eDZ1QVVvMm5KYTc3NS9G?= =?utf-8?Q?AN+zbIFXo7jn2bNa4s=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2a6d5b6-999d-4bf6-a6dc-08d8f8e46734 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 10:11:53.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 38VOA/iOEpzkAA4rCsJ6Vm1IWk20P4fYgRT3bttJZI4Z3EtnKK5RGWCJ3Kp28QwRnORaEcXWI3u+9Xk+Z5WbGdLb3Nus3/fBMVtl7mIsGuw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3197 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_111158_824180_04812F7E X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/6/21 11:50 AM, YueHaibing wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part") > left behind this, so can remove it. Checkpatch complains: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")' but the change is good: Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/dma/at_xdmac.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index fe45ad5d06c4..64a52bf4d737 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan) > return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status); > } > > -static inline int at_xdmac_csize(u32 maxburst) > -{ > - int csize; > - > - csize = ffs(maxburst) - 1; > - if (csize > 4) > - csize = -EINVAL; > - > - return csize; > -}; > - > static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg) > { > return cfg & AT_XDMAC_CC_TYPE_PER_TRAN; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel