From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C3C0C001DE for ; Fri, 18 Aug 2023 11:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9DzAXTMEnmRfsRJjskTfSHwYz5KVSl0+GF0gbHxfgIo=; b=U44W/quCEHc9/c XmRsV05/NehNzqorLpvgn3eCziat/MNKqMJIGJzvQta94FaaqcBjC9XfkhFXqxWlqPz0A+fSqTyE8 Fdrkxob/dfkCm7N4gzptjEBYphs2gnsn0NIuVnQ9BBr8T6yDwNLwpJWaLDUsjULdbMFKOhsPCu15A oJiOYhcUnwKvyoFG6s6IK2XA5GmnVuym/32vyt91zkuUeb5UMxdVnkAlYRJ0OTVT26DAxndR6Au5c tI6y5Lx26G51jhztMSRbCx0pzFdRBMC0R82uTNp8T/hGLDoykbiks0gOnL8L/w5k/Ea28ZmafC1v2 anJuWnGqd1A+ho4fktQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWxJ5-008VKz-2D; Fri, 18 Aug 2023 11:06:19 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWxJ2-008VH2-0p for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 11:06:17 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ff88239785so1090141e87.0 for ; Fri, 18 Aug 2023 04:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692356773; x=1692961573; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UMIktzBcgCZ2Vl0uMoPdLyMfuXFnj8LQIJonADyTrTE=; b=hc7DAw1jAzejV41R4/oXFzjTTyJcG4TEUTMq2mRDdLba4GbIlI6HIu45uZ55hhxcK5 Hk1jHJkCz3PT4fZQh1pWDeERortudXYMit4GMFztCX8fpiiJWh/Se4OOB+bGSysIvy+D Q03npqSi7pZucFaqytpwos/Gs1lJZvhCPMX78z+z3BFIPj6MK89IbZkngBqcxM7t28Na 4TncwsUIeSJlYeXpBeH98lgJrS57JRHmexw0C2s8odiyZY1hBO4u16fQ616TmRIDvtqM 8K5P2SUH+Qt7SWMzeYaMG4fWi/D98DKiBJChjwxhTajd4x+p19nRAqMkW03bI3yTs54D OHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692356773; x=1692961573; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMIktzBcgCZ2Vl0uMoPdLyMfuXFnj8LQIJonADyTrTE=; b=C0gp83i6V+ulda+AGfB03hAbPedPESlbCv8YAheUtFaR9XLAefTyJWuSErcPayF5tj E1schMrsIEPQqZkKClQnE+C3tLBXL5kj+bUpCN8ZTIkSKnAmgmJt+bkK+vASMQdm6MIl geQGafkkHlgIFhnD87ZL4y0rwpZCNulvQ+wc7WOBHhIzh3uf/23JV3yHKzReIcS3Cc/O wtJi+7EQb6I2vyodQVtlg8PYV1yjoJn1Wmxwf20OankKSfUXmJeVXA1Xwl+Z0/A0h2ce 0BrbNUfmQFgOOdagpSiP4iOzgFjfGxmOLWpS/HYj3chcP+r6Y3PQHk1CqZy5AiIikBT/ FDMQ== X-Gm-Message-State: AOJu0YxEwZOGdXZ93PgvR0l+8PuqscFu1I/dhYomRkgvOchoY0d6CH8U 0GvfihJsWXWiVCEfhoqing4ncw== X-Google-Smtp-Source: AGHT+IH0IRqcnpfQ1DcMW1gOJYtBbBbQUGhUUhchG+P2KKAZ3KQNIExD06f+xoIePJauUtb49QueuQ== X-Received: by 2002:a05:6512:2342:b0:4f9:56a9:b98e with SMTP id p2-20020a056512234200b004f956a9b98emr1801620lfu.58.1692356772869; Fri, 18 Aug 2023 04:06:12 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id k19-20020ac257d3000000b004ff91a94156sm290851lfo.121.2023.08.18.04.06.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Aug 2023 04:06:12 -0700 (PDT) Message-ID: Date: Fri, 18 Aug 2023 14:06:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/9] i2c: qcom-cci: Use dev_err_probe in probe function Content-Language: en-GB To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20230728013148.1720978-1-liaochang1@huawei.com> <20230728013148.1720978-6-liaochang1@huawei.com> From: Dmitry Baryshkov In-Reply-To: <20230728013148.1720978-6-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_040616_308571_3CD01A86 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/07/2023 04:31, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Signed-off-by: Liao Chang > --- > drivers/i2c/busses/i2c-qcom-cci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Dmitry Baryshkov > > diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c > index 622dc14add9d..cf13abec05f1 100644 > --- a/drivers/i2c/busses/i2c-qcom-cci.c > +++ b/drivers/i2c/busses/i2c-qcom-cci.c > @@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev) > /* Clocks */ > > ret = devm_clk_bulk_get_all(dev, &cci->clocks); > - if (ret < 1) { > - dev_err(dev, "failed to get clocks %d\n", ret); > - return ret; > - } > + if (ret < 1) > + return dev_err_probe(dev, ret, "failed to get clocks\n"); > cci->nclocks = ret; > > /* Retrieve CCI clock rate */ -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel