From: <Claudiu.Beznea@microchip.com>
To: <herve.codina@bootlin.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
thomas.petazzoni@bootlin.com, sboyd@kernel.org,
gregkh@linuxfoundation.org, mturquette@baylibre.com,
linux-usb@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, Horatiu.Vultur@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: dts: lan966x: Add UDPHS support
Date: Mon, 4 Jul 2022 05:39:21 +0000 [thread overview]
Message-ID: <e88c6b69-1e06-429a-5784-a8c66d13e260@microchip.com> (raw)
In-Reply-To: <20220701160327.102880e5@bootlin.com>
Hi, Herve,
On 01.07.2022 17:03, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Claudiu,>
> On Fri, 1 Jul 2022 10:56:46 +0000
> <Claudiu.Beznea@microchip.com> wrote:
>
>> On 01.07.2022 10:09, Herve Codina wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Add UDPHS (the USB High Speed Device Port controller) support.
>>>
>>> The both lan966x SOCs (LAN9662 and LAN9668) have the same UDPHS
>>> IP. This IP is also the same as the one present in the SAMA5D3
>>> SOC.
>>>
>>> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>>> ---
>>> arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 3cb02fffe716..c98e7075c2b4 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -458,6 +458,17 @@ cpu_ctrl: syscon@e00c0000 {
>>> reg = <0xe00c0000 0x350>;
>>> };
>>>
>>> + udc: usb@e0808000 {
>>> + compatible = "microchip,lan9662-udc",
>>> + "atmel,sama5d3-udc";
>>> + reg = <0x00200000 0x80000>,
>>> + <0xe0808000 0x400>;
>>> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&clks GCK_GATE_UDPHS>, <&nic_clk>;
>>> + clock-names = "pclk", "hclk";
>>> + status = "disabled";
>>> + };
>>> +
>>
>> I have these compilation warnings:
>>
>> DTC arch/arm/boot/dts/lan966x-pcb8291.dtb
>> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg):
>> /soc/usb@e0808000: simple-bus unit address format error, expected "200000"
>> DTC arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
>> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg):
>> /soc/usb@e0808000: simple-bus unit address format error, expected "200000"
>> DTC arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
>> arch/arm/boot/dts/lan966x.dtsi:461.21-470.5: Warning (simple_bus_reg):
>> /soc/usb@e0808000: simple-bus unit address format error, expected "200000"
>
> I am a bit confused but these warnings do not appear on my side (patches
> based on v5.19-rc1).
> What is the exact command that leads to these warning ?
Have you tried with CONFIG_SOC_LAN966 enabled?
Thank you,
Claudiu Beznea
>
> Thanks,
> Hervé
>
> --
> Hervé Codina, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-04 5:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 7:09 [PATCH v4 0/3] Microchip LAN966x USB device support Herve Codina
2022-07-01 7:09 ` [PATCH v4 1/3] clk: lan966x: Fix the lan966x clock gate register address Herve Codina
2022-07-01 7:09 ` [PATCH v4 2/3] dt-bindings: usb: atmel: Add Microchip LAN9662 compatible string Herve Codina
2022-07-01 7:09 ` [PATCH v4 3/3] ARM: dts: lan966x: Add UDPHS support Herve Codina
2022-07-01 10:56 ` Claudiu.Beznea
2022-07-01 14:03 ` Herve Codina
2022-07-04 5:39 ` Claudiu.Beznea [this message]
2022-07-04 5:41 ` Claudiu.Beznea
2022-07-04 10:19 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88c6b69-1e06-429a-5784-a8c66d13e260@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).