From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C91C433E1 for ; Tue, 18 Aug 2020 15:17:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD25A2076E for ; Tue, 18 Aug 2020 15:17:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KaD3ubEC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD25A2076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+b//LKdc8kWPTwlF8hc3t6Vp+uJLdmRkrh18BZ8PPBQ=; b=KaD3ubECxKhb0l8xBq3wjUt3k mM5XPuss8jric9EQpLrfdudaReV9TfL/n1MWdnjzLmi2ekZ2PYv+mS3NIcWFo8ac9qIittignD7/c Sc78CkRkBI6ju2r7GJPCbjDDkadMJQTT8UTyvAoK+v5j6A1ZEI3qG54T7KauCl4S35jfniujMxgzZ Jv+SNjIY1dVzn+HPu5MBiksvsFrQe4lNGhyRwwTkA7M8ngNRnx4fJoB4iQd8N76ReVbm9bac8WQBp HvBAvhM4Scbls3KVzLoV4WrrLEqgyIr6DtLVz6bekDnOicIR8mSP323M1W/9mCpfbMQxxrVv8Tnsu P0Y6msnQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k83LG-0006cb-PZ; Tue, 18 Aug 2020 15:16:02 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k83LE-0006aY-4H for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 15:16:01 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A038779F2590DCA4521A; Tue, 18 Aug 2020 23:15:46 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020 23:15:44 +0800 Subject: Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() To: Andreas Schwab References: <20200818143952.50752-1-yuehaibing@huawei.com> <87ft8katwz.fsf@igel.home> From: Yuehaibing Message-ID: Date: Tue, 18 Aug 2020 23:15:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87ft8katwz.fsf@igel.home> X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_111600_443057_CE3E2CD2 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, ajayg@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, kuba@kernel.org, peppe.cavallaro@st.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/8/18 22:51, Andreas Schwab wrote: > On Aug 18 2020, YueHaibing wrote: > >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >> >> Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") >> Signed-off-by: YueHaibing >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> index f32317fa75c8..b5b558b02e7d 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> @@ -413,7 +413,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) >> } >> >> plat->phy_interface = device_get_phy_mode(&pdev->dev); >> - if (plat->phy_interface < 0) >> + if ((int)plat->phy_interface < 0) >> return ERR_PTR(plat->phy_interface); > > I don't think the conversion to long when passed to ERR_PTR will produce > a negative value either (if long is wider than unsigned int). Thanks, will respin. > > Andreas. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel